Eliminate trying to save local time (#59)

Author: sei-tspencer

Cite.Api/Cite.Api.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
   <PropertyGroup>
-    <Version>1.8.1</Version>
+    <Version>1.8.2</Version>
     <TargetFramework>net8.0</TargetFramework>
     <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
     <NoWarn>CS1591</NoWarn>
@@ -51,4 +51,4 @@
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
   </ItemGroup>
-</Project>
+</Project>

Cite.Api/Services/EvaluationService.cs

@@ -403,17 +403,22 @@ public async Task<Evaluation> UploadJsonAsync(FileForm form, CancellationToken c
                 }
             }
             // okay to update this evaluation
+            await _context.Database.BeginTransactionAsync(ct);
             evaluation.CreatedBy = evaluationToUpdate.CreatedBy;
             evaluation.DateCreated = evaluationToUpdate.DateCreated;
             evaluation.ModifiedBy = _user.GetId();
             evaluation.DateModified = DateTime.UtcNow;
+            evaluation.Submissions = [];
+            evaluation.ScoringModel = null;
+            evaluation.Teams = [];
+            evaluation.Moves = [];
+            evaluation.SituationTime = evaluation.SituationTime.ToUniversalTime();
             _mapper.Map(evaluation, evaluationToUpdate);
-
-            await VerifyOfficialAndTeamSubmissions(evaluationToUpdate, ct);
             _logger.LogDebug("Saving the Evaluation change");
-            _context.Evaluations.Update(evaluationToUpdate);
             await _context.SaveChangesAsync(ct);
-
+            _logger.LogDebug("Verifying required submissions exist");
+            await VerifyOfficialAndTeamSubmissions(evaluationToUpdate, ct);
+            await _context.Database.CommitTransactionAsync(ct);
             evaluation = await GetAsync(evaluationToUpdate.Id, ct);
 
             return evaluation;
@@ -531,7 +536,7 @@ private async Task VerifyOfficialAndTeamSubmissions(EvaluationEntity evaluation,
                             UserId = null,
                             ScoringModelId = evaluation.ScoringModelId,
                             MoveNumber = move.MoveNumber,
-                        DateCreated = DateTime.UtcNow
+                            DateCreated = DateTime.UtcNow
                         };
                         _logger.LogInformation("Make Team submission for move " + move.MoveNumber + "  team=" + submission.TeamId.ToString());
                         await _submissionService.CreateNewSubmission(_context, submission, ct);

Cite.Api/Services/SubmissionService.cs

@@ -658,13 +658,15 @@ private async Task<SubmissionEntity> createRequestedSubmissionAndOthers(ViewMode
         public async Task<SubmissionEntity> CreateNewSubmission(CiteContext citeContext, ViewModels.Submission submission, CancellationToken ct)
         {
             // actually create a new submission
-            submission.Id = Guid.NewGuid();
-            submission.DateCreated = DateTime.UtcNow;
-            submission.CreatedBy = _user.GetId();
-            submission.DateModified = null;
-            submission.ModifiedBy = null;
-            submission.Status = Data.Enumerations.ItemStatus.Active;
             var submissionEntity = _mapper.Map<SubmissionEntity>(submission);
+            submissionEntity.Id = Guid.NewGuid();
+            submissionEntity.DateCreated = DateTime.UtcNow;
+            submissionEntity.CreatedBy = _user.GetId();
+            submissionEntity.DateModified = null;
+            submissionEntity.ModifiedBy = null;
+            submissionEntity.Status = Data.Enumerations.ItemStatus.Active;
+            submissionEntity.Evaluation = null;
+            submissionEntity.ScoringModel = null;
             citeContext.Submissions.Add(submissionEntity);
             // catch race condition if we try to add the same submission twice
             try