css: Move no-masthead-sidebar to pf-m-sidebar
#22342
Conversation
Venefilyn
added
no-test
Venefilyn
force-pushed
the
css/deprecate-page-sidebar-override
branch
from
1bfa114 to
ff792f4
Compare
|
This probably runs in a lot of flakes, started retries. |
Venefilyn
force-pushed
the
css/deprecate-page-sidebar-override
branch
from
ff792f4 to
ff7c5bf
Compare
Seem to not be flakes as they appear again |
|
re-triggered fedora-42/other after we merged #22371 |
jelly
added
the
no-test
Venefilyn
force-pushed
the
css/deprecate-page-sidebar-override
branch
2 times, most recently
from
960f47f to
3faceb0
Compare
|
This pixel diff is just noise, fine. This one is a weird regression or flake, though: The input line suddenly gets focus. I'll retry that one to see if it's stable. |
|
Ah, nevermind, they were already discussed above. This needs a closer look. If it's stable, please just push and queue this after #22241. Thanks! |
No, it isn't noise! We explicitly have |
This is the official class for it so we no longer need our own workaround. Related-to: patternfly/patternfly#7357 Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
force-pushed
the
css/deprecate-page-sidebar-override
branch
from
3faceb0 to
d556c5a
Compare
|
Waiting on fedora-42/devel to go green. |
|
|
||
| return ( | ||
| <Page id="storage" className={"no-masthead-sidebar" + (client.in_anaconda_mode() ? " anaconda" : "")}> | ||
| <Page id="storage" className={"pf-m-no-sidebar" + (client.in_anaconda_mode() ? " anaconda" : "")}> |
There was a problem hiding this comment.
This added line is not executed by any test. Details
|
Let's roll this out to other plugins after the |
4 participants
This is the official class for it so we no longer need our own
workaround.
Related-to: patternfly/patternfly#7357
Signed-off-by: Freya Gustavsson [email protected]