Skip to content

test: drop clearing the screenreader text #22452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: drop clearing the screenreader text #22452

wants to merge 1 commit into from
+1 −6

Conversation

@jelly
Copy link
Member

@jelly jelly commented Sep 23, 2025

This was fixed in PatternFly 6.2.0.

Related: patternfly/patternfly-react#11704

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 23, 2025
Venefilyn
Venefilyn reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, with that fix we still need to modify screenreaderText props on the components to be empty. Currently to not be a breaking change at least they keep the default but allow us to clear out the screenreaderText:

screenReaderText = `${variant} status`,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Venefilyn Venefilyn Venefilyn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

no-test For doc/workflow changes, or experiments which don't need a full CI run,

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jelly @Venefilyn