Skip to content

Commit 766aa4d

Browse files
dhartuniandhartunian
committed
build: min supported version is go 1.23
The minimum version that we test with is now 1.23 which modifies some stacktrace output. This is done so tests can pass reliably. Due to the dependency bump, we cannot continue to support go versions below 1.23 moving forward. Resolves: CRDB-49975
1 parent 5b23426 commit 766aa4d

File tree

15 files changed

+1801
-1797
lines changed

15 files changed

+1801
-1797
lines changed

‎.github/workflows/ci.yaml‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ jobs:
1212
strategy:
1313
matrix:
1414
go:
15-
- "1.18"
16-
- "1.19"
17-
- "1.20"
15+
- "1.23"
16+
- "1.24"
1817
steps:
1918
- uses: actions/checkout@v3
2019

@@ -30,8 +29,8 @@ jobs:
3029
strategy:
3130
matrix:
3231
go:
33-
- "1.20"
34-
- "1.21"
32+
- "1.23"
33+
- "1.24"
3534
steps:
3635
- uses: actions/checkout@v3
3736

‎fmttests/testdata/format/leaves‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ assertmsg oneline
3232
(1) assertion failure
3333
Wraps: (2) attached stack trace
3434
-- stack trace:
35-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
35+
| github.com/cockroachdb/errors/fmttests.init.func17
3636
| <tab><path>:<lineno>
3737
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
3838
| <tab><path>:<lineno>
@@ -80,7 +80,7 @@ assertmsg ‹oneline›
8080
(1) assertion failure
8181
Wraps: (2) attached stack trace
8282
-- stack trace:
83-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
83+
| github.com/cockroachdb/errors/fmttests.init.func17
8484
| <tab><path>:<lineno>
8585
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
8686
| <tab><path>:<lineno>
@@ -115,7 +115,7 @@ Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *erru
115115
(1) assertion failure
116116
Wraps: (2) attached stack trace
117117
-- stack trace:
118-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
118+
| github.com/cockroachdb/errors/fmttests.init.func17
119119
| <tab><path>:<lineno>
120120
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
121121
| <tab><path>:<lineno>
@@ -176,7 +176,7 @@ Title: "*errutil.leafError: assertmsg ×\nvia *withstack.withStack"
176176
<path>:<lineno>:
177177
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
178178
<path>:<lineno>:
179-
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
179+
(github.com/cockroachdb/errors/fmttests.init)...funcNN...
180180

181181
run
182182
ctx-canceled oneline twoline
@@ -659,7 +659,7 @@ twoline
659659
new-style oneline
660660
(1) attached stack trace
661661
-- stack trace:
662-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
662+
| github.com/cockroachdb/errors/fmttests.init.func16
663663
| <tab><path>:<lineno>
664664
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
665665
| <tab><path>:<lineno>
@@ -706,7 +706,7 @@ new-style ‹oneline›
706706
new-style ‹oneline›
707707
(1) attached stack trace
708708
-- stack trace:
709-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
709+
| github.com/cockroachdb/errors/fmttests.init.func16
710710
| <tab><path>:<lineno>
711711
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
712712
| <tab><path>:<lineno>
@@ -740,7 +740,7 @@ Error types: (1) *withstack.withStack (2) *errutil.leafError
740740
<path>:<lineno>: new-style ×
741741
(1) attached stack trace
742742
-- stack trace:
743-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
743+
| github.com/cockroachdb/errors/fmttests.init.func16
744744
| <tab><path>:<lineno>
745745
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
746746
| <tab><path>:<lineno>
@@ -799,7 +799,7 @@ Title: "*errutil.leafError: new-style ×\nvia *withstack.withStack"
799799
<path>:<lineno>:
800800
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
801801
<path>:<lineno>:
802-
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
802+
(github.com/cockroachdb/errors/fmttests.init)...funcNN...
803803

804804
run
805805
newf-attached oneline twoline
@@ -842,7 +842,7 @@ twoline: payload
842842
new-style oneline
843843
(1) attached stack trace
844844
-- stack trace:
845-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
845+
| github.com/cockroachdb/errors/fmttests.init.func18
846846
| <tab><path>:<lineno>
847847
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
848848
| <tab><path>:<lineno>
@@ -870,7 +870,7 @@ Wraps: (2) secondary error attachment
870870
| payload
871871
| (1) attached stack trace
872872
| -- stack trace:
873-
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
873+
| | github.com/cockroachdb/errors/fmttests.init.func18
874874
| | <tab><path>:<lineno>
875875
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
876876
| | <tab><path>:<lineno>
@@ -919,7 +919,7 @@ new-style ‹oneline›
919919
new-style ‹oneline›
920920
(1) attached stack trace
921921
-- stack trace:
922-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
922+
| github.com/cockroachdb/errors/fmttests.init.func18
923923
| <tab><path>:<lineno>
924924
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
925925
| <tab><path>:<lineno>
@@ -947,7 +947,7 @@ Wraps: (2) secondary error attachment
947947
| payload
948948
| (1) attached stack trace
949949
| -- stack trace:
950-
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
950+
| | github.com/cockroachdb/errors/fmttests.init.func18
951951
| | <tab><path>:<lineno>
952952
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
953953
| | <tab><path>:<lineno>
@@ -983,7 +983,7 @@ Error types: (1) *withstack.withStack (2) *secondary.withSecondaryError (3) *err
983983
<path>:<lineno>: new-style ×
984984
(1) attached stack trace
985985
-- stack trace:
986-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
986+
| github.com/cockroachdb/errors/fmttests.init.func18
987987
| <tab><path>:<lineno>
988988
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
989989
| <tab><path>:<lineno>
@@ -1011,7 +1011,7 @@ Wraps: (2) secondary error attachment
10111011
| payload
10121012
| (1) attached stack trace
10131013
| -- stack trace:
1014-
| | github.com/cockroachdb/errors/fmttests.glob...funcNN...
1014+
| | github.com/cockroachdb/errors/fmttests.init.func18
10151015
| | <tab><path>:<lineno>
10161016
| | github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
10171017
| | <tab><path>:<lineno>
@@ -1074,7 +1074,7 @@ Title: "*errutil.leafError: new-style ×\nvia *withstack.withStack"
10741074
<path>:<lineno>:
10751075
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
10761076
<path>:<lineno>:
1077-
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
1077+
(github.com/cockroachdb/errors/fmttests.init)...funcNN...
10781078

10791079
run
10801080
nofmt oneline twoline
@@ -1450,7 +1450,7 @@ twoline
14501450
== %+v
14511451
oneline
14521452
twoline
1453-
github.com/cockroachdb/errors/fmttests.glob...funcNN...
1453+
github.com/cockroachdb/errors/fmttests.init.func9
14541454
<tab><path>:<lineno>
14551455
github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
14561456
<tab><path>:<lineno>
@@ -1487,7 +1487,7 @@ oneline
14871487
(1) oneline
14881488
| twoline
14891489
-- stack trace:
1490-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
1490+
| github.com/cockroachdb/errors/fmttests.init.func9
14911491
| <tab><path>:<lineno>
14921492
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
14931493
| <tab><path>:<lineno>
@@ -1528,7 +1528,7 @@ Error types: (1) *errors.fundamental
15281528
(1) ‹oneline›
15291529
‹ | twoline›
15301530
-- stack trace:
1531-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
1531+
| github.com/cockroachdb/errors/fmttests.init.func9
15321532
| <tab><path>:<lineno>
15331533
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
15341534
| <tab><path>:<lineno>
@@ -1561,7 +1561,7 @@ Error types: (1) *errors.fundamental
15611561
(1) ×
15621562
×
15631563
-- stack trace:
1564-
| github.com/cockroachdb/errors/fmttests.glob...funcNN...
1564+
| github.com/cockroachdb/errors/fmttests.init.func9
15651565
| <tab><path>:<lineno>
15661566
| github.com/cockroachdb/errors/fmttests.TestDatadriven.func2.1
15671567
| <tab><path>:<lineno>
@@ -1616,7 +1616,7 @@ Title: "*errors.fundamental: ×"
16161616
<path>:<lineno>:
16171617
(github.com/cockroachdb/errors/fmttests.TestDatadriven.func2) 1()
16181618
<path>:<lineno>:
1619-
(github.com/cockroachdb/errors/fmttests.glob.)...funcNN...
1619+
(github.com/cockroachdb/errors/fmttests.init)...funcNN...
16201620

16211621
run
16221622
safefmt oneline twoline

0 commit comments

Comments
 (0)