test(utils): make spinner symbol defaults os-indepedent in tests

Author: matejchalk

packages/utils/src/lib/logger.int.test.ts

@@ -2,6 +2,7 @@ import ansis from 'ansis';
 import cliSpinners from 'cli-spinners';
 import logSymbols from 'log-symbols';
 import os from 'node:os';
+import process from 'node:process';
 import type { MockInstance } from 'vitest';
 import { Logger } from './logger.js';
 
@@ -26,6 +27,7 @@ describe('Logger', () => {
   let output = '';
   let consoleLogSpy: MockInstance<unknown[], void>;
   let processStderrSpy: MockInstance<[], typeof process.stderr>;
+  let processPlatformSpy: MockInstance<[], typeof process.platform>;
   let performanceNowSpy: MockInstance<[], number>;
   let mathRandomSpy: MockInstance<[], number>;
 
@@ -56,6 +58,12 @@ describe('Logger', () => {
     processStderrSpy = vi
       .spyOn(process, 'stderr', 'get')
       .mockReturnValue(mockProcessStderr as typeof process.stderr);
+
+    // ora uses is-unicode-supported to determine if dots or line is default spinner
+    processPlatformSpy = vi
+      .spyOn(process, 'platform', 'get')
+      .mockReturnValue('linux');
+    vi.stubEnv('TERM', 'xterm');
   });
 
   beforeEach(() => {
@@ -72,6 +80,7 @@ describe('Logger', () => {
     vi.useRealTimers();
     consoleLogSpy.mockReset();
     processStderrSpy.mockReset();
+    processPlatformSpy.mockReset();
     performanceNowSpy.mockReset();
     mathRandomSpy.mockReset();
   });
@@ -308,7 +317,7 @@ ${ansis.magenta('└')} ${ansis.green(`Total line coverage is ${ansis.bold('82%'
       await expect(task).resolves.toBeUndefined();
 
       expect(output).toBe(
-        `${logSymbols.success} Uploaded report to portal ${ansis.gray('(42 ms)')}\n`,
+        `${ansis.green('✔')} Uploaded report to portal ${ansis.gray('(42 ms)')}\n`,
       );
     });
 
@@ -322,7 +331,7 @@ ${ansis.magenta('└')} ${ansis.green(`Total line coverage is ${ansis.bold('82%'
       await expect(task).rejects.toThrow('GraphQL error: Invalid API key');
 
       expect(output).toBe(
-        `${logSymbols.error} Uploading report to portal → ${ansis.red('Error: GraphQL error: Invalid API key')}\n`,
+        `${ansis.red('✖')} Uploading report to portal → ${ansis.red('Error: GraphQL error: Invalid API key')}\n`,
       );
     });
 
@@ -361,7 +370,7 @@ ${logSymbols.success} Uploaded report to portal ${ansis.gray('(42 ms)')}
 
       expect(output).toBe(
         `
-${logSymbols.error} Uploading report to portal ${ansis.red.bold('[SIGINT]')}
+${ansis.red('✖')} Uploading report to portal ${ansis.red.bold('[SIGINT]')}
 
 ${ansis.red.bold('Cancelled by SIGINT')}
 `.trimStart(),
@@ -417,7 +426,7 @@ ${logSymbols.success} Uploaded report to portal ${ansis.gray('(42 ms)')}
 
       expect(output).toBe(
         `
-${logSymbols.error} Uploading report to portal → ${ansis.red('Error: GraphQL error: Invalid API key')}
+${ansis.red('✖')} Uploading report to portal → ${ansis.red('Error: GraphQL error: Invalid API key')}
   ${ansis.gray('Sent request to Portal API')}
   ${ansis.gray('Received response from Portal API')}
 `.trimStart(),
@@ -470,7 +479,7 @@ ${logSymbols.error} Uploading report to portal → ${ansis.red('Error: GraphQL e
       await expect(command).resolves.toBeUndefined();
 
       expect(output).toBe(
-        `${logSymbols.success} ${ansis.green('$')} npx eslint . --format=json ${ansis.gray('(42 ms)')}\n`,
+        `${ansis.green('✔')} ${ansis.green('$')} npx eslint . --format=json ${ansis.gray('(42 ms)')}\n`,
       );
     });
 
@@ -489,7 +498,7 @@ ${logSymbols.error} Uploading report to portal → ${ansis.red('Error: GraphQL e
       await expect(command).rejects.toThrow('Process failed with exit code 1');
 
       expect(output).toBe(
-        `${logSymbols.error} ${ansis.red('$')} npx eslint . --format=json\n`,
+        `${ansis.red('✖')} ${ansis.red('$')} npx eslint . --format=json\n`,
       );
     });
   });