Skip to content

Commit f7a705d

Browse files
committed
ci: update local node version
1 parent 3b5db5b commit f7a705d

File tree

12 files changed

+25
-21
lines changed

12 files changed

+25
-21
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Set up Node.js
2323
uses: actions/setup-node@v4
2424
with:
25-
node-version-file: .nvmrc
25+
node-version-file: .node-version
2626
cache: npm
2727
- name: Set base and head for Nx affected commands
2828
uses: nrwl/nx-set-shas@v4
@@ -42,7 +42,7 @@ jobs:
4242
- name: Set up Node.js
4343
uses: actions/setup-node@v4
4444
with:
45-
node-version-file: .nvmrc
45+
node-version-file: .node-version
4646
cache: npm
4747
- name: Set base and head for Nx affected commands
4848
uses: nrwl/nx-set-shas@v4
@@ -66,7 +66,7 @@ jobs:
6666
- name: Set up Node.js
6767
uses: actions/setup-node@v4
6868
with:
69-
node-version-file: .nvmrc
69+
node-version-file: .node-version
7070
cache: npm
7171
- name: Set base and head for Nx affected commands
7272
uses: nrwl/nx-set-shas@v4
@@ -90,7 +90,7 @@ jobs:
9090
- name: Set up Node.js
9191
uses: actions/setup-node@v4
9292
with:
93-
node-version-file: .nvmrc
93+
node-version-file: .node-version
9494
cache: npm
9595
- name: Set base and head for Nx affected commands
9696
uses: nrwl/nx-set-shas@v4
@@ -114,7 +114,7 @@ jobs:
114114
- name: Set up Node.js
115115
uses: actions/setup-node@v4
116116
with:
117-
node-version-file: .nvmrc
117+
node-version-file: .node-version
118118
cache: npm
119119
- name: Set base and head for Nx affected commands
120120
uses: nrwl/nx-set-shas@v4
@@ -134,7 +134,7 @@ jobs:
134134
- name: Set up Node.js
135135
uses: actions/setup-node@v4
136136
with:
137-
node-version-file: .nvmrc
137+
node-version-file: .node-version
138138
cache: npm
139139
- name: Set base and head for Nx affected commands
140140
uses: nrwl/nx-set-shas@v4

.github/workflows/code-coverage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Set up Node.js
1919
uses: actions/setup-node@v4
2020
with:
21-
node-version-file: .nvmrc
21+
node-version-file: .node-version
2222
cache: npm
2323
- name: Install dependencies
2424
run: npm ci
@@ -43,7 +43,7 @@ jobs:
4343
- name: Set up Node.js
4444
uses: actions/setup-node@v4
4545
with:
46-
node-version-file: .nvmrc
46+
node-version-file: .node-version
4747
cache: npm
4848
- name: Install dependencies
4949
run: npm ci

.github/workflows/code-pushup-fork.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Set up Node.js
3131
uses: actions/setup-node@v4
3232
with:
33-
node-version-file: .nvmrc
33+
node-version-file: .node-version
3434
cache: npm
3535
- name: Set base and head for Nx affected commands
3636
uses: nrwl/nx-set-shas@v4

.github/workflows/code-pushup.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: Set up Node.js
3333
uses: actions/setup-node@v4
3434
with:
35-
node-version-file: .nvmrc
35+
node-version-file: .node-version
3636
cache: npm
3737
- name: Set base and head for Nx affected commands
3838
uses: nrwl/nx-set-shas@v4

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
- name: Set up Node.js
4040
uses: actions/setup-node@v4
4141
with:
42-
node-version-file: .nvmrc
42+
node-version-file: .node-version
4343
cache: npm
4444
- name: Install dependencies
4545
run: npm ci
@@ -74,7 +74,7 @@ jobs:
7474
- name: Set up Node.js
7575
uses: actions/setup-node@v4
7676
with:
77-
node-version-file: .nvmrc
77+
node-version-file: .node-version
7878
cache: npm
7979
- name: Install dependencies
8080
run: npm ci

.node-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
24.8.0

.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

.tool-versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Prerequisites:
66

7-
- Node.js installed (LTS version)
7+
- Node.js installed (version specified in [`.node-version`](./.node-version))
88

99
Make sure to install dependencies:
1010

eslint.config.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import nxEslintPlugin from '@nx/eslint-plugin';
22
import jestExtendedPlugin from 'eslint-plugin-jest-extended';
33
import jsoncParser from 'jsonc-eslint-parser';
4+
import fs from 'node:fs/promises';
45
import tseslint from 'typescript-eslint';
56
import node from '@code-pushup/eslint-config/node.js';
67
import typescript from '@code-pushup/eslint-config/typescript.js';
@@ -123,6 +124,16 @@ export default tseslint.config(
123124
'sonarjs/no-duplicate-string': 'off',
124125
},
125126
},
127+
{
128+
// tests need only be compatible with local Node version
129+
// publishable packages should pick up version range from "engines" in their package.json
130+
files: ['e2e/**/*.ts', 'testing/**/*.ts'],
131+
settings: {
132+
node: {
133+
version: await fs.readFile('.node-version', 'utf8'),
134+
},
135+
},
136+
},
126137
{
127138
ignores: [
128139
'**/*.mock.*',

0 commit comments

Comments
 (0)