feat: add caching options to cli #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Project documentation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 4553888 with previous commit 49adbf3. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories
👎 2 groups regressed, 👍 1 audit improved, 👎 4 audits regressed, 15 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
590 other audits are unchanged. |
5 tasks
@code-pushup/ci
@code-pushup/core
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
…o-cli # Conflicts: # e2e/cli-e2e/tests/collect.e2e.test.ts # packages/cli/src/lib/implementation/core-config.middleware.ts # packages/core/src/lib/collect-and-persist.ts
matejchalk
reviewed
Aug 12, 2025
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
reviewed
Aug 12, 2025
matejchalk
reviewed
Aug 12, 2025
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
previously approved these changes
Aug 12, 2025
matejchalk
approved these changes
Aug 12, 2025
This was referenced Aug 13, 2025
BioPhoton
added a commit
that referenced
this pull request
Aug 28, 2025
**Followup of:** - #1059 **Precondition:** - #1061 **This PR includes:** - ~add helper to load envVars~ - adjusted `nx.json` - add `defaultTargets` for main and plugin `code-pushup` targets - add default inputs - add plugin caching to code-pushup target - cache js-packages and invalidate daily - GH adjustments - added `affected` and `--parallel=3` - Adjust path helper that that created Nx project graph to use `readCachedProjectGraph` to avoid problems when running plugins in parallel > [!note] > I cache the `js-packges` plugin target, against our discussion, as only in this PR I would have saved ~4min **Followup Todos:** - move `zod2md.ts` under `tools` and leverage `"!{projectRoot}/tools/**/*"` in `nx.json#namedInputs.production` - rename `nx-plugin/mock` to `models/mocks` and adjust inputs - cleanup e2e targets leverage `nx.json#targetDefaults` - include only relevant projects in `plugin-eslint` config - stricter task dependencies to avoid running tracked libs e.g. `nx run test-nx-utils:unit-test` is executed ATM - understand why e2e tests fail if `nx.json#defaultTargets[N].@nx/vite:test` as empty (`{}`) target is removed **Followup PRs:** - #1035 --------- Co-authored-by: John Doe <[email protected]> Co-authored-by: Matěj Chalk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on:
This PR includes:
--cacheoptions and caching--skipReports)Suggested followup PR would be to implement Nx caching. This is partially started here: #1035.
Note
Potential changes arrive after #1058 is merged
Closes #1048