Add tests for new Path-based methods

Co-authored-by: slachiewicz <[email protected]>

Author: Copilot

src/test/java/org/codehaus/plexus/components/io/attributes/AttributeUtilsTest.java

@@ -1,6 +1,8 @@
 package org.codehaus.plexus.components.io.attributes;
 
 import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.nio.file.attribute.PosixFilePermission;
 import java.util.Set;
 
@@ -62,4 +64,20 @@ void chmodBackAndForth() throws Exception {
         assertTrue(secondAttrs.isOwnerWritable());
         assertTrue(secondAttrs.isOwnerExecutable());
     }
+
+    @Test
+    @DisabledOnOs(OS.WINDOWS)
+    void chmodBackAndForthWithPath() throws Exception {
+        final Path bxx = Files.createTempFile("bxx", "ff");
+        AttributeUtils.chmod(bxx, 0422);
+        PlexusIoResourceAttributes firstAttrs = new FileAttributes(bxx);
+        assertTrue(firstAttrs.isOwnerReadable());
+        assertFalse(firstAttrs.isOwnerWritable());
+        assertFalse(firstAttrs.isOwnerExecutable());
+        AttributeUtils.chmod(bxx, 0777);
+        PlexusIoResourceAttributes secondAttrs = new FileAttributes(bxx);
+        assertTrue(secondAttrs.isOwnerReadable());
+        assertTrue(secondAttrs.isOwnerWritable());
+        assertTrue(secondAttrs.isOwnerExecutable());
+    }
 }

src/test/java/org/codehaus/plexus/components/io/attributes/FileAttributesTest.java

@@ -18,6 +18,7 @@
 
 import java.io.File;
 import java.nio.file.Files;
+import java.nio.file.Path;
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledOnOs;
@@ -52,4 +53,28 @@ void fileAttributesHandlesIOException() throws Exception {
             tempFile.delete();
         }
     }
+
+    @Test
+    @DisabledOnOs(OS.WINDOWS)
+    void getPosixFileAttributesWithPath() throws Exception {
+        Path path = java.nio.file.Paths.get(".");
+        PlexusIoResourceAttributes fa = new FileAttributes(path);
+        assertNotNull(fa);
+    }
+
+    @Test
+    void fileAttributesHandlesIOExceptionWithPath() throws Exception {
+        // Test that FileAttributes can be constructed for a regular file using Path
+        // even if ownership information is not available (e.g., WSL2 mapped network drives)
+        Path tempPath = Files.createTempFile("plexus-io-test", ".tmp");
+        try {
+            // This should not throw even if ownership info is unavailable
+            PlexusIoResourceAttributes fa = new FileAttributes(tempPath);
+            assertNotNull(fa);
+            // The attributes object should be usable even if userName/groupName are null
+            assertNotNull(fa.toString());
+        } finally {
+            Files.deleteIfExists(tempPath);
+        }
+    }
 }

src/test/java/org/codehaus/plexus/components/io/attributes/PlexusIoResourceAttributeUtilsTest.java

@@ -19,6 +19,7 @@
 import java.io.File;
 import java.net.URL;
 import java.nio.file.NoSuchFileException;
+import java.nio.file.Path;
 import java.util.Map;
 
 import org.codehaus.plexus.util.StringUtils;
@@ -326,4 +327,50 @@ void mergeAttributesDefault() {
         assertNull(attributes.getGroupName());
         assertEquals(0, attributes.getOctalMode());
     }
+
+    @Test
+    @DisabledOnOs(OS.WINDOWS)
+    void getAttributesForThisTestClassWithPath() throws Exception {
+        URL resource = Thread.currentThread()
+                .getContextClassLoader()
+                .getResource(getClass().getName().replace('.', '/') + ".class");
+
+        if (resource == null) {
+            throw new IllegalStateException("SOMETHING IS VERY WRONG. CANNOT FIND THIS TEST CLASS IN THE CLASSLOADER.");
+        }
+
+        Path path = java.nio.file.Paths.get(resource.getPath().replaceAll("%20", " "));
+
+        Map<String, PlexusIoResourceAttributes> attrs =
+                PlexusIoResourceAttributeUtils.getFileAttributesByPath(path, true);
+
+        PlexusIoResourceAttributes fileAttrs = attrs.get(path.toFile().getAbsolutePath());
+
+        assertNotNull(fileAttrs);
+        assertTrue(fileAttrs.isOwnerReadable());
+        assertEquals(System.getProperty("user.name"), fileAttrs.getUserName());
+    }
+
+    @Test
+    @DisabledOnOs(OS.WINDOWS)
+    void srcResourceWithPath() throws Exception {
+        Path dir = java.nio.file.Paths.get("src/test/resources/symlinks");
+        final Map<String, PlexusIoResourceAttributes> fileAttributesByPathScreenScrape =
+                PlexusIoResourceAttributeUtils.getFileAttributesByPath(dir, true);
+        assertNotNull(fileAttributesByPathScreenScrape);
+        PlexusIoResourceAttributes pr = null;
+        for (String s : fileAttributesByPathScreenScrape.keySet()) {
+            if (s.endsWith("targetFile.txt")) pr = fileAttributesByPathScreenScrape.get(s);
+        }
+        assertNotNull(pr);
+
+        assertTrue(pr.getOctalMode() > 0);
+    }
+
+    @Test
+    void nonExistingDirectoryWithPath() {
+        Path dir = java.nio.file.Paths.get("src/test/noSuchDirectory");
+        assertThrows(
+                NoSuchFileException.class, () -> PlexusIoResourceAttributeUtils.getFileAttributesByPath(dir, true));
+    }
 }

src/test/java/org/codehaus/plexus/components/io/attributes/SymlinkUtilsTest.java

@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.file.Files;
+import java.nio.file.Path;
 
 import org.apache.commons.io.FileUtils;
 import org.junit.jupiter.api.BeforeEach;
@@ -57,6 +58,27 @@ void create_read_symbolic_link_to_directory() throws Exception {
         assertEquals(new File("aSubDir"), SymlinkUtils.readSymbolicLink(new File(target, "symlinkToDir")));
     }
 
+    @Test
+    void create_read_symbolic_link_to_file_with_path() throws Exception {
+        Path symlink = target.toPath().resolve("symlinkToTarget");
+        File relativePath = createTargetFile(target);
+        SymlinkUtils.createSymbolicLink(symlink, relativePath.toPath());
+        assertEquals(expected, FileUtils.readFileToString(symlink.toFile(), UTF_8));
+        assertEquals(java.nio.file.Paths.get("actualFile"), SymlinkUtils.readSymbolicLink(symlink));
+    }
+
+    @Test
+    void create_read_symbolic_link_to_directory_with_path() throws Exception {
+        File subDir = new File(target, "aSubDir");
+        createTargetFile(subDir);
+        Path symlink = target.toPath().resolve("symlinkToDir");
+        SymlinkUtils.createSymbolicLink(symlink, java.nio.file.Paths.get("aSubDir"));
+        assertEquals(
+                expected,
+                FileUtils.readFileToString(symlink.resolve("actualFile").toFile(), UTF_8));
+        assertEquals(java.nio.file.Paths.get("aSubDir"), SymlinkUtils.readSymbolicLink(symlink));
+    }
+
     private File createTargetFile(File target) throws IOException {
         File relativePath = new File("actualFile");
         File actualFile = new File(target, relativePath.getPath());

src/test/java/org/codehaus/plexus/components/io/resources/ResourceFactoryPathTest.java

@@ -0,0 +1,41 @@
+package org.codehaus.plexus.components.io.resources;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.apache.commons.io.FileUtils;
+import org.junit.jupiter.api.Test;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class ResourceFactoryPathTest {
+
+    @Test
+    void testCreateResourceWithPath() throws IOException {
+        Path tempPath = Files.createTempFile("test", ".txt");
+        try {
+            FileUtils.write(tempPath.toFile(), "test content", UTF_8);
+            PlexusIoResource resource = ResourceFactory.createResource(tempPath);
+            assertNotNull(resource);
+            assertTrue(resource.isExisting());
+        } finally {
+            Files.deleteIfExists(tempPath);
+        }
+    }
+
+    @Test
+    void testCreateResourceWithPathAndName() throws IOException {
+        Path tempPath = Files.createTempFile("test", ".txt");
+        try {
+            FileUtils.write(tempPath.toFile(), "test content", UTF_8);
+            PlexusIoResource resource = ResourceFactory.createResource(tempPath, "custom-name.txt");
+            assertNotNull(resource);
+            assertTrue(resource.isExisting());
+        } finally {
+            Files.deleteIfExists(tempPath);
+        }
+    }
+}