Skip to content

Conversation

MickLesk
Copy link
Member

@MickLesk MickLesk commented Sep 8, 2025

✍️ Description

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@github-actions github-actions bot added the update script A change that updates a script label Sep 8, 2025
@vhsdream
Copy link
Member

vhsdream commented Sep 8, 2025

@MickLesk - question: are we offering a way to upgrade existing LXCs to 13, or is that going to be another thing entirely?

@MickLesk
Copy link
Member Author

MickLesk commented Sep 8, 2025

That are 4 lines Code. An sed, an Update, an upgrade and dist-upgrade

Maybe. @CrazyWolf13 ?

@CrazyWolf13 CrazyWolf13 marked this pull request as ready for review September 8, 2025 15:08
@CrazyWolf13 CrazyWolf13 requested review from a team as code owners September 8, 2025 15:08
@CrazyWolf13 CrazyWolf13 marked this pull request as draft September 8, 2025 15:09
@CrazyWolf13
Copy link
Member

@vhsdream @MickLesk technically it's very easy and & could definitely spin up a PR, but I'm honestly not sure if it's a good time now.

As you can see in #7332

There are quite some things that don't work.
Namely all python based, all php based, a lot don't even have debian packages yet or are elsewhere broken.

Ultimately it's up to all contributors if we want to support the migration at the current time and all issues.

@michelroegl-brunner @tremor021

@michelroegl-brunner
Copy link
Member

I would offer a guide with code snippets in the disscussions on how to do, maybe in the thread @MickLesk already started.

One thing we could offer in a few weeks time a standalone script wich dose the updating wich would check some sort of a db, json, text file if the currently installed app is os upgradeable?

@tremor021
Copy link
Member

tremor021 commented Sep 8, 2025

I agree with @MickLesk, its just a couple of bash lines to get it done. But, as we don't really know for sure the extent to which something might not work, i would offer a tutorial to the user to do it manually as @michelroegl-brunner said, if its really important for them to upgrade. Obviously doing a backup/snapshot beforehand.

We can always do a update to the script at a later date, when we get a feel how many scripts will need some sort of fixing.

@CrazyWolf13
Copy link
Member

done in #7489 @vhsdream

@vhsdream
Copy link
Member

@MickLesk - are we looking to support both Debian 12 and 13 for each LXC for the time being? I recall that was an option previously, between 11 and 12.

@MickLesk
Copy link
Member Author

Too much effort for some Scripts, because deps Changed. I think in next weeks should all PVE Hosts updated to Support deb13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants