Fix producev() detection (#115)

Author: edenhill

confluent_kafka/src/Producer.c

@@ -325,7 +325,7 @@ static PyObject *Producer_produce (Handle *self, PyObject *args,
         if (timestamp) {
                 PyErr_Format(PyExc_NotImplementedError,
                              "Producer timestamps require librdkafka "
-                             "version >=v0.9.3 (currently on %s)",
+                             "version >=v0.9.4 (currently on %s)",
                              rd_kafka_version_str());
                 return NULL;
         }
@@ -461,7 +461,7 @@ static PyMethodDef Producer_methods[] = {
 	  "  :param func on_delivery(err,msg): Delivery report callback to call "
 	  "(from :py:func:`poll()` or :py:func:`flush()`) on successful or "
 	  "failed delivery\n"
-          "  :param int timestamp: Message timestamp (CreateTime) in microseconds since epoch UTC (requires librdkafka >= v0.9.3, api.version.request=true, and broker >= 0.10.0.0). Default value is current time.\n"
+          "  :param int timestamp: Message timestamp (CreateTime) in microseconds since epoch UTC (requires librdkafka >= v0.9.4, api.version.request=true, and broker >= 0.10.0.0). Default value is current time.\n"
 	  "\n"
 	  "  :rtype: None\n"
 	  "  :raises BufferError: if the internal producer message queue is "
@@ -495,7 +495,7 @@ static PyMethodDef Producer_methods[] = {
 	  "   This is a convenience method that calls :py:func:`poll()` until "
 	  ":py:func:`len()` is zero or the optional timeout elapses.\n"
 	  "\n"
-          "  :param: float timeout: Maximum time to block (requires librdkafka >= v0.9.3).\n"
+          "  :param: float timeout: Maximum time to block (requires librdkafka >= v0.9.4).\n"
           "  :returns: Number of messages still in queue.\n"
           "\n"
 	  ".. note:: See :py:func:`poll()` for a description on what "

confluent_kafka/src/confluent_kafka.h

@@ -29,7 +29,7 @@
 /**
  * librdkafka feature detection
  */
-#if RD_KAFKA_VERSION >= 0x00090300
+#ifdef RD_KAFKA_V_TIMESTAMP
 #define HAVE_PRODUCEV  1 /* rd_kafka_producev() */
 #endif
 

examples/integration_test.py

@@ -120,7 +120,7 @@ def verify_producer():
     try:
         p.produce(topic, value='with a timestamp', timestamp=123456789000)
     except NotImplementedError:
-        if confluent_kafka.libversion()[1] >= 0x00090300:
+        if confluent_kafka.libversion()[1] >= 0x00090400:
             raise
 
     # Produce even more messages

tests/test_Producer.py

@@ -42,13 +42,13 @@ def test_produce_timestamp():
                   'error_cb': error_cb,
                   'default.topic.config': {'message.timeout.ms': 10}})
 
-    # Requires librdkafka >=v0.9.3
+    # Requires librdkafka >=v0.9.4
 
     try:
         p.produce('mytopic', timestamp=1234567)
     except NotImplementedError:
         # Should only fail on non-supporting librdkafka
-        if libversion()[1] >= 0x00090300:
+        if libversion()[1] >= 0x00090400:
             raise
 
     p.flush()