ci: fix release workflows to block if version check fails (#7350)

* ci: fix release workflows to block if version check fails

* fix: better readline for cli

* fix: npm run lint fixes

Author: sestinj

.github/workflows/main.yaml

@@ -26,8 +26,24 @@ jobs:
             echo "should_run=false" >> $GITHUB_OUTPUT
           fi
 
+  check-version:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0 # This ensures all tags are fetched
+
+      - name: Checkout tag
+        run: git checkout ${GITHUB_REF#refs/tags/}
+
+      - name: Make sure version isn't odd
+        run: |
+          cd extensions/vscode
+          node scripts/versionCheck.js
+
   build:
-    needs: check_release_name
+    needs: [check_release_name, check-version]
     if: needs.check_release_name.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
     runs-on: ${{ matrix.os }}
     strategy:
@@ -88,22 +104,6 @@ jobs:
           name: ${{ matrix.platform }}-${{ matrix.arch }}-vsix
           path: "extensions/vscode/*.vsix"
 
-  check-version:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-        with:
-          fetch-depth: 0 # This ensures all tags are fetched
-
-      - name: Checkout tag
-        run: git checkout ${GITHUB_REF#refs/tags/}
-
-      - name: Make sure version isn't odd
-        run: |
-          cd extensions/vscode
-          node scripts/versionCheck.js
-
   release:
     permissions:
       contents: write

extensions/cli/package-lock.json

@@ -77,7 +77,6 @@
     "@types/jszip": "^3.4.0",
     "@types/nock": "^10.0.3",
     "@types/react": "^19.1.8",
-    "@types/readline-sync": "^1.4.8",
     "@types/shell-quote": "^1.7.5",
     "@types/supertest": "^6.0.3",
     "@types/turndown": "^5.0.5",
@@ -122,7 +121,6 @@
     "prettier": "^3.6.2",
     "prettier-plugin-tailwindcss": "^0.6.14",
     "react": "^19.1.0",
-    "readline-sync": "^1.4.10",
     "semantic-release": "^24.2.7",
     "shell-quote": "^1.8.3",
     "supertest": "^7.1.3",

extensions/cli/package.json

@@ -1,8 +1,7 @@
 import { ModelConfig } from "@continuedev/config-yaml";
 import chalk from "chalk";
-import type { ChatHistoryItem, Session } from "core/index.js";
+import { ChatHistoryItem, Session } from "core";
 import { ChatDescriber } from "core/util/chatDescriber.js";
-import * as readlineSync from "readline-sync";
 
 import { compactChatHistory, findCompactionIndex } from "../compaction.js";
 import { processCommandFlags } from "../flags/flagProcessor.js";
@@ -25,6 +24,7 @@ import { startTUIChat } from "../ui/index.js";
 import { gracefulExit } from "../util/exit.js";
 import { formatAnthropicError, formatError } from "../util/formatError.js";
 import { logger } from "../util/logger.js";
+import { question } from "../util/prompt.js";
 import {
   calculateContextUsagePercentage,
   countChatHistoryTokens,
@@ -454,7 +454,7 @@ async function runHeadlessMode(
     const userInput =
       isFirstMessage && initialUserInput
         ? initialUserInput
-        : readlineSync.question(`\n${chalk.bold.green("You:")} `);
+        : await question(`\n${chalk.bold.green("You:")} `);
 
     isFirstMessage = false;
 

extensions/cli/src/commands/chat.ts

@@ -4,14 +4,14 @@ import * as path from "path";
 
 import chalk from "chalk";
 import open from "open";
-import * as readlineSync from "readline-sync";
 
 import { env } from "./env.js";
 import {
-  isValidAnthropicApiKey,
   getApiKeyValidationError,
+  isValidAnthropicApiKey,
 } from "./util/apiKeyValidation.js";
 import { gracefulExit } from "./util/exit.js";
+import { question, questionWithChoices } from "./util/prompt.js";
 import { updateAnthropicModelInYaml } from "./util/yamlConfigUpdater.js";
 
 const CONFIG_PATH = path.join(env.continueHome, "config.yaml");
@@ -52,10 +52,12 @@ export async function handleMaxedOutFreeTrial(
   console.log(chalk.white("1. 💳 Sign up for models add-on"));
   console.log(chalk.white("2. 🔑 Enter your Anthropic API key"));
 
-  const choice = readlineSync.question(chalk.yellow("\nEnter choice (1): "), {
-    limit: ["1", "2", ""],
-    limitMessage: chalk.dim("Please enter 1 or 2"),
-  });
+  const choice = await questionWithChoices(
+    chalk.yellow("\nEnter choice (1): "),
+    ["1", "2", ""],
+    "1",
+    chalk.dim("Please enter 1 or 2"),
+  );
 
   if (choice === "1" || choice === "") {
     // Option 1: Open models setup page
@@ -81,15 +83,12 @@ export async function handleMaxedOutFreeTrial(
     }
 
     // Wait for user to acknowledge
-    readlineSync.question(chalk.dim("\nPress Enter to exit..."));
+    await question(chalk.dim("\nPress Enter to exit..."));
     await gracefulExit(0);
   } else if (choice === "2") {
     // Option 2: Enter Anthropic API key
-    const apiKey = readlineSync.question(
+    const apiKey = await question(
       chalk.white("\nEnter your Anthropic API key: "),
-      {
-        hideEchoBack: true,
-      },
     );
 
     if (!isValidAnthropicApiKey(apiKey)) {

extensions/cli/src/freeTrialTransition.ts

@@ -5,7 +5,6 @@ import { AssistantUnrolled, ModelConfig } from "@continuedev/config-yaml";
 import { BaseLlmApi } from "@continuedev/openai-adapters";
 import { DefaultApiInterface } from "@continuedev/sdk/dist/api/dist/index.js";
 import chalk from "chalk";
-import * as readlineSync from "readline-sync";
 
 import { processPromptOrRule } from "./args.js";
 import { AuthConfig, isAuthenticated, login } from "./auth/workos.js";
@@ -16,6 +15,7 @@ import {
   getApiKeyValidationError,
   isValidAnthropicApiKey,
 } from "./util/apiKeyValidation.js";
+import { question, questionWithChoices } from "./util/prompt.js";
 import { updateAnthropicModelInYaml } from "./util/yamlConfigUpdater.js";
 
 const CONFIG_PATH = path.join(env.continueHome, "config.yaml");
@@ -97,10 +97,12 @@ async function runOnboardingFlow(
   console.log(chalk.white("1. ⏩ Log in with Continue"));
   console.log(chalk.white("2. 🔑 Enter your Anthropic API key"));
 
-  const choice = readlineSync.question(chalk.yellow("\nEnter choice (1): "), {
-    limit: ["1", "2", ""],
-    limitMessage: chalk.dim("Please enter 1 or 2"),
-  });
+  const choice = await questionWithChoices(
+    chalk.yellow("\nEnter choice (1): "),
+    ["1", "2", ""],
+    "1",
+    chalk.dim("Please enter 1 or 2"),
+  );
 
   if (choice === "1" || choice === "") {
     const newAuthConfig = await login();
@@ -111,11 +113,8 @@ async function runOnboardingFlow(
     const result = await initialize(finalAuthConfig, undefined);
     return { ...result, wasOnboarded: true };
   } else if (choice === "2") {
-    const apiKey = readlineSync.question(
+    const apiKey = await question(
       chalk.white("\nEnter your Anthropic API key: "),
-      {
-        hideEchoBack: true,
-      },
     );
 
     if (!isValidAnthropicApiKey(apiKey)) {