missingIncludePrefixes only works with subdirectories

[K-ballo]

Changing the test to include <llvm/ThisHeaderDoesNotExist.h> causes it to fail:

mrdocs/test-files/golden-tests/config/missing-include-prefixes/main.cpp

Line 2 in 940c33f

#include <llvm/IR/ThisHeaderDoesNotExist.h>

The code seems to be literally looking for the string "llvm/" in the paths, missing the case where the path doesn't include the trailing slash. This works when the path is "llvm/IR" instead.

[K-ballo]

The source code mentions a forgive-missing-includes configuration option taking glob patterns:

mrdocs/src/lib/AST/MrDocsFileSystem.hpp

Lines 33 to 37 in 3197a59

	// We have a config option where the user can specify the glob patterns
	// for include files that should be treated this way. The name
	// of the option is `forgive-missing-includes`. The user can specify
	// the "**" pattern to forgive all missing includes or specific
	// patterns like "llvm/**" to forgive all includes from LLVM.

That sounds like a much better option to have than string matching.

[alandefreitas]

The comment is out of date. The option names are in Semantic Parsing in the ConfigOptions.json file.

You can define prefixes (which can also be files, IIRC) and specific shims. I've never seen a case where a more expensive pattern would be needed and the way clang resolves paths in the logical filesystem makes it hard to match patterns there.