Bug fix (#1189)

* Fix the function calls in the memory allocation adapter

* Fix the missing semicolon

* Fix the return value

* Fix the memory allocation logic to ensure that the correct exact size is reserved

* Add branch in the copy function

* Fix the type comparison in the algorithm

* Fix the require condition

* Fix the types in the functions and correct the parameter order

* Fix the operator from left-shift to right-shift

* Fix some problems

Author: puji4810

include/fast_io_core_impl/allocation/adapters.h

@@ -129,7 +129,7 @@ class generic_allocator_adapter
 			{
 				return allocator_type::allocate(n);
 			}
-			else if constexpr (::fast_io::details::has_allocate_aligned_at_least_impl<alloc>)
+			else if constexpr (::fast_io::details::has_allocate_at_least_impl<alloc>)
 			{
 				return allocator_type::allocate_at_least(n).ptr;
 			}
@@ -141,7 +141,7 @@ class generic_allocator_adapter
 			{
 				return allocator_type::allocate_zero(n);
 			}
-			else if constexpr (::fast_io::details::has_allocate_aligned_at_least_impl<alloc>)
+			else if constexpr (::fast_io::details::has_allocate_zero_at_least_impl<alloc>)
 			{
 				return allocator_type::allocate_zero_at_least(n).ptr;
 			}
@@ -1211,7 +1211,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			return static_cast<T *>(alloc::allocate_aligned(n * sizeof(T), alignof(T)));
+			return static_cast<T *>(alloc::allocate_aligned(alignof(T), n * sizeof(T)));
 		}
 	}
 
@@ -1248,7 +1248,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			auto newres{alloc::allocate_aligned_at_least(n * sizeof(T), alignof(T))};
+			auto newres{alloc::allocate_aligned_at_least(alignof(T), n * sizeof(T))};
 			return {reinterpret_cast<T *>(newres.ptr), newres.count / sizeof(T)};
 		}
 	}
@@ -1274,7 +1274,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			return static_cast<T *>(alloc::allocate_zero_aligned(n * sizeof(T), alignof(T)));
+			return static_cast<T *>(alloc::allocate_zero_aligned(alignof(T), n * sizeof(T)));
 		}
 	}
 
@@ -1311,7 +1311,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			auto newres{alloc::allocate_zero_aligned_at_least(n * sizeof(T), alignof(T))};
+			auto newres{alloc::allocate_zero_aligned_at_least(alignof(T), n * sizeof(T))};
 			return {reinterpret_cast<T *>(newres.ptr), newres.count / sizeof(T)};
 		}
 	}
@@ -1339,7 +1339,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			return static_cast<T *>(alloc::reallocate_aligned(ptr, n * sizeof(T), alignof(T)));
+			return static_cast<T *>(alloc::reallocate_aligned(ptr, alignof(T), n * sizeof(T)));
 		}
 	}
 
@@ -1365,7 +1365,7 @@ class typed_generic_allocator_adapter
 		}
 		else
 		{
-			auto newres{alloc::reallocate_aligned_zero_at_least(ptr, n * sizeof(T), alignof(T))};
+			auto newres{alloc::reallocate_aligned_zero_at_least(ptr, alignof(T), n * sizeof(T))};
 			return {reinterpret_cast<T *>(newres.ptr), newres.count / sizeof(T)};
 		}
 	}

include/fast_io_core_impl/allocation/custom.h

@@ -6,7 +6,7 @@ namespace fast_io
 class custom_global_allocator;
 
 #if defined(FAST_IO_DISABLE_CUSTOM_THREAD_LOCAL_ALLOCATOR)
-using custom_thread_local_allocator = custom_global_allocator
+using custom_thread_local_allocator = custom_global_allocator;
 #else
 class custom_thread_local_allocator;
 #endif

include/fast_io_core_impl/concat/concat_general.h

@@ -86,7 +86,7 @@ inline constexpr T basic_general_concat_decay_impl_precise(T& str,Arg arg)
 		++precise_size_with_line;
 	constexpr std::size_t local_cap{strlike_sso_size(io_strlike_type<ch_type,T>)};
 	if(local_cap<precise_size_with_line)
-		strlike_reserve(io_strlike_type<ch_type,T>,str,local_cap);
+		strlike_reserve(io_strlike_type<ch_type,T>,str,precise_size_with_line);
 	auto first{strlike_begin(io_strlike_type<ch_type,T>,str)};
 	print_reserve_precise_define(io_reserve_type<ch_type,Arg>,first,precise_size,arg);
 	auto ptr{first+precise_size};

include/fast_io_core_impl/concepts/type.h

@@ -35,7 +35,7 @@ struct basic_message_hdr
 	int           flags;      /* Flags (unused) */
 	inline operator basic_message_hdr<void>() const noexcept requires(!std::same_as<T,void>)
 	{
-		return {name,namelen*sizeof(T),iov,iovlen*sizeof(T),control,controllen,flags};
+		return {name,namelen,iov,iovlen,control,controllen,flags};
 	}
 };
 

include/fast_io_core_impl/dynamic_io_buffer.h

@@ -116,7 +116,7 @@ inline constexpr void dynamic_io_buffer_write_impl_unhappy(dynamic_io_buffer<::s
 template<std::integral ch_type>
 inline constexpr void oreserve(dynamic_io_buffer<ch_type>& ob,std::size_t new_capacity)  noexcept
 {
-	if(static_cast<std::size_t>(ob.buffer_end-ob.buffer_begin)<=new_capacity)
+	if(static_cast<std::size_t>(ob.buffer_end-ob.buffer_begin)>=new_capacity) // return if enough space
 		return;
 	details::dynamic_io_buffer_oreallocate_impl(ob,new_capacity);
 }
@@ -159,7 +159,7 @@ inline constexpr void write(dynamic_io_buffer<ch_type>& ob,Iter first,Iter last)
 			details::dynamic_io_buffer_write_impl_unhappy(ob,first,diff);
 			return;
 		}
-		ob.buffer_curr=details::non_overlapped_copy(first,last,ob.buffer_begin);
+		ob.buffer_curr=details::non_overlapped_copy(first,last,ob.buffer_curr); // copy to buffer_curr, not buffer_begin
 	}
 }
 

include/fast_io_core_impl/freestanding/algorithm.h

@@ -82,6 +82,10 @@ inline constexpr output_iter copy(input_iter first, input_iter last, output_iter
 		{
 			*result = static_cast<::std::byte>(*first);
 		}
+		else
+		{
+			*result = *first;
+		}
 		++first;
 		++result;
 	}
@@ -403,8 +407,7 @@ inline constexpr output_iter my_copy(input_iter first, input_iter second, output
 				  ::std::is_trivially_copyable_v<output_value_type> &&
 				  (::std::same_as<input_value_type, output_value_type> ||
 				   (::std::integral<input_value_type> && ::std::integral<output_value_type> &&
-					sizeof(::std::is_trivially_copyable_v<input_value_type>) ==
-						sizeof(::std::is_trivially_copyable_v<output_value_type>))))
+					sizeof(input_value_type) == sizeof(output_value_type))))
 	{
 		my_copy_n(first, static_cast<::std::size_t>(second - first), result);
 		return result + (second - first);
@@ -486,7 +489,7 @@ inline constexpr bool my_compare_iter_n(input_iter first, ::std::size_t n, outpu
 					   (::std::integral<input_value_type> && ::std::integral<output_value_type> &&
 						sizeof(input_value_type) == sizeof(output_value_type))))
 		{
-			return my_memcmp(::std::to_address(first), ::std::to_address(outier), n) == 0;
+			return my_memcmp(::std::to_address(first), ::std::to_address(outier), sizeof(input_value_type) * n) == 0;
 		}
 		else
 		{

include/fast_io_core_impl/freestanding/array.h

@@ -4,7 +4,7 @@ namespace fast_io::freestanding
 {
 
 template <typename T, ::std::size_t N>
-	requires(sizeof(N) != 0)
+	requires(N != 0)
 struct array
 {
 	using value_type = T;

include/fast_io_core_impl/integers/crypto_hash.h

@@ -303,7 +303,7 @@ inline constexpr hash_compress_t<digest_format::upper,ctx> hash_compress_upper(T
 	}
 	else
 	{
-		return {reinterpret_cast<std::byte const*>(::std::ranges::data(t)),static_cast<std::size_t>(::std::ranges::size(t))*sizeof(T)};
+		return {reinterpret_cast<std::byte const*>(::std::ranges::data(t)),static_cast<std::size_t>(::std::ranges::size(t))*sizeof(::std::ranges::range_value_t<T>)};
 	}
 }
 
@@ -317,7 +317,7 @@ inline constexpr hash_compress_t<digest_format::raw_bytes,ctx> hash_compress_raw
 	}
 	else
 	{
-		return {reinterpret_cast<std::byte const*>(::std::ranges::data(t)),static_cast<std::size_t>(::std::ranges::size(t))*sizeof(T)};
+		return {reinterpret_cast<std::byte const*>(::std::ranges::data(t)),static_cast<std::size_t>(::std::ranges::size(t))*sizeof(::std::ranges::range_value_t<T>)};
 	}
 }
 
@@ -511,7 +511,7 @@ inline constexpr char_type* prv_srv_hash_compress_df_impl(char_type* iter,std::b
 			{
 				std::byte buffer[digest_size];
 				auto ret{cal_hash_internal_impl<T>(base,len,buffer)};
-				return ::fast_io::details::copy_to_hash_df_commom_impl<d==::fast_io::manipulators::digest_format::upper>(buffer,iter,static_cast<std::size_t>(ret-buffer));
+				return ::fast_io::details::copy_to_hash_df_commom_impl<d==::fast_io::manipulators::digest_format::upper>(iter,buffer,static_cast<std::size_t>(ret-buffer));
 			}
 			else
 #endif

include/fast_io_core_impl/simd/gcc_clang.h

@@ -191,7 +191,7 @@ struct simd_vector
 	}
 	inline constexpr simd_vector<T,N>& operator>>=(simd_vector<T,N> const& other) noexcept
 	{
-		value<<=other.value;
+		value>>=other.value;
 		return *this;
 	}
 

include/fast_io_hosted/filesystem/nt.h

@@ -357,7 +357,7 @@ struct basic_nt_family_recursive_directory_generator
 	constexpr basic_nt_family_recursive_directory_generator(basic_nt_family_recursive_directory_generator&& __restrict other) noexcept:root_handle(other.root_handle),entry(other.entry)
 	{
 		other.root_handle=nullptr;
-		entry=nullptr;
+		other.entry=nullptr;
 	}
 	constexpr basic_nt_family_recursive_directory_generator& operator=(basic_nt_family_recursive_directory_generator&& __restrict other) noexcept
 	{