Naming missmatch between `classification` and `particle_type` group in HDF5EventSource

This came up using the `HDF5EventSource` to stream in some DL2 data with applied particle classifier where i got:
```
Unknown DL2 stereo group particle_type
Unknown DL2 telescope group particle_type
```

It tries to read in the `classification` group defined here:
https://github.com/cta-observatory/ctapipe/blob/e6eeae9747e96d4e021f661da36f80f4c5027694/src/ctapipe/io/hdf5eventsource.py#L66-L72

but the group is named "particle_type" via the `ReconstructionProperty`-Class
https://github.com/cta-observatory/ctapipe/blob/e6eeae9747e96d4e021f661da36f80f4c5027694/src/ctapipe/reco/reconstructor.py#L25-L45

I think "particle_type" would be the better naming here (more specific, fits better to geometry, energy). 
To be more coherent, we could also adapt the `ReconstructedContainer`-Field here:
https://github.com/cta-observatory/ctapipe/blob/e6eeae9747e96d4e021f661da36f80f4c5027694/src/ctapipe/containers.py#L1087-L1090

from `classification` to `particle_type` or just `particle`.

	DL2_CONTAINERS = {
	"energy": ReconstructedEnergyContainer,
	"geometry": ReconstructedGeometryContainer,
	"classification": ParticleClassificationContainer,
	"impact": TelescopeImpactParameterContainer,
	"disp": DispContainer,
	}

	class ReconstructionProperty(Flag):
	"""
	Primary particle properties estimated by a `Reconstructor`

	These properties are of enum.Flag type and can thus be
	combined using bitwise operators to indicate a reconstructor
	provides several properties at once.
	"""

	#: Energy if the primary particle
	ENERGY = auto()
	#: Geometric properties of the primary particle,
	#: direction and impact point
	GEOMETRY = auto()
	#: Prediction score that a particle belongs to a certain class
	PARTICLE_TYPE = auto()
	#: Disp, distance of the source position from the Hillas COG along the main axis
	DISP = auto()

	def __str__(self):
	return f"{self.name.lower()}"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Naming missmatch between `classification` and `particle_type` group in HDF5EventSource #2759

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	classification = Field(
	default_factory=partial(Map, ParticleClassificationContainer),
	description="map of algorithm to classification parameters",
	)

Uh oh!

Naming missmatch between classification and particle_type group in HDF5EventSource #2759

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Naming missmatch between `classification` and `particle_type` group in HDF5EventSource #2759