Minor fixes

- Remove Logger.debug(...)
- add removing trailing "." to safe_folder_name (for Windows)

Author: jk-lamb

lib/kanta/backend.ex

@@ -38,13 +38,9 @@ defmodule Kanta.Backend do
 
       # When `mix gettext extract` create POT/PO files based on this backend usage (ex. getext(...) call) across the application codebase.
       if Gettext.Extractor.extracting?() do
-        Logger.debug("#{__MODULE__} OFF")
         use Gettext.Backend, opts
 
-        Kanta.Utils.GettextRecompiler.setup_recompile_flag(
-          @flag_file,
-          "Setting gettext recompile flag for #{__MODULE__}"
-        )
+        Kanta.Utils.GettextRecompiler.setup_recompile_flag(@flag_file)
       else
         Logger.debug("#{__MODULE__} ON")
         opts = Keyword.merge(opts, priv: "priv/#{ModuleFolder.safe_folder_name(__MODULE__)}")
@@ -69,13 +65,9 @@ defmodule Kanta.Backend do
                bindings
              ) do
           {:ok, translation} ->
-            Logger.debug("Kanta for \"#{msgid}\"")
-
             {:ok, translation}
 
           {:error, :not_found} ->
-            Logger.debug("Gettext for \"#{msgid}\"")
-
             backend = fallback_backend()
             backend.lgettext(locale, domain, msgctxt, msgid, bindings)
         end
@@ -100,11 +92,9 @@ defmodule Kanta.Backend do
                bindings
              ) do
           {:ok, translation} ->
-            Logger.debug("Kanta for \"#{msgid}\"")
             {:ok, translation}
 
           {:error, :not_found} ->
-            Logger.debug("Gettext for \"#{msgid}\"")
             backend = fallback_backend()
 
             backend.lngettext(

lib/kanta/backend/fallback_backend.ex

@@ -16,18 +16,12 @@ defmodule Kanta.Backend.GettextFallback do
 
         # When `mix gettext extract` create empty stub so that the  Kanta.Backend can compile.
         if Gettext.Extractor.extracting?() do
-          Logger.debug("#{__MODULE__} OFF")
-
           def lgettext(_locale, _domain, _msgctxt, _msgid, _bindings), do: nil
           def lngettext(_locale, _domain, _msgctxt, _msgid, _msgid_plural, _n, _bindings), do: nil
 
-          Kanta.Utils.GettextRecompiler.setup_recompile_flag(
-            @flag_file,
-            "Setting fallback recompile flag #{__MODULE__}"
-          )
+          Kanta.Utils.GettextRecompiler.setup_recompile_flag(@flag_file)
         else
           # ...otherwise generate the Gettext.Backend interface
-          Logger.debug("#{__MODULE__} ON")
           use Gettext.Backend, opts
         end
 

lib/kanta/utils/gettext_recompiler.ex

@@ -1,9 +1,8 @@
 defmodule Kanta.Utils.GettextRecompiler do
   require Logger
 
-  def setup_recompile_flag(flag_file, message) do
+  def setup_recompile_flag(flag_file) do
     if Gettext.Extractor.extracting?() do
-      Logger.debug(message)
       File.mkdir_p!(Path.dirname(flag_file))
       File.touch!(flag_file)
     end

lib/kanta/utils/module_folder.ex

@@ -16,15 +16,14 @@ defmodule Kanta.Utils.ModuleFolder do
       iex> ModuleFolder.safe_folder_name("Elixir.MyApp.Module", replace_with: "-")
       "MyApp-Module"
   """
-  def safe_folder_name(module, opts \\ []) when is_atom(module) or is_binary(module) do
-    lowercase? = Keyword.get(opts, :lowercase, true)
-    replacement = Keyword.get(opts, :replace_with, "_")
+  def safe_folder_name(module) when is_atom(module) or is_binary(module) do
+    replacement = "_"
 
     module
     |> module_to_string()
     |> remove_elixir_prefix()
     |> replace_invalid_chars(replacement)
-    |> maybe_downcase(lowercase?)
+    |> String.downcase()
   end
 
   defp module_to_string(module) when is_atom(module), do: Atom.to_string(module)
@@ -39,8 +38,7 @@ defmodule Kanta.Utils.ModuleFolder do
     |> String.replace(~r/[^\w\-\.]/, replacement)
     # Collapse multiple replacements
     |> String.replace(~r/#{replacement}+/, replacement)
+    # Comply with Windows naming rules
+    |> String.trim_trailing(".")
   end
-
-  defp maybe_downcase(name, true), do: String.downcase(name)
-  defp maybe_downcase(name, false), do: name
 end