GUI: fix crashes

jdupak · jdupak · commit 0d0e88d6e177 · 2024-02-15T14:49:40.000+01:00
diff --git a/src/gui/windows/messages/messagesmodel.cpp b/src/gui/windows/messages/messagesmodel.cpp
@@ -105,7 +105,9 @@ void MessagesModel::insert_line(
 }
 
 void MessagesModel::clear_messages() {
-    beginRemoveRows(QModelIndex(), 0, rowCount() - 1);
+    auto row_count = rowCount();
+    if (row_count == 0) return;
+    beginRemoveRows(QModelIndex(), 0, row_count - 1);
     while (!messages.isEmpty()) {
         delete messages.takeFirst();
     }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,9 @@ void MessagesModel::insert_line(`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`void MessagesModel::clear_messages() {`
`108`		`- beginRemoveRows(QModelIndex(), 0, rowCount() - 1);`
	`108`	`+ auto row_count = rowCount();`
	`109`	`+ if (row_count == 0) return;`
	`110`	`+ beginRemoveRows(QModelIndex(), 0, row_count - 1);`
`109`	`111`	`while (!messages.isEmpty()) {`
`110`	`112`	`delete messages.takeFirst();`
`111`	`113`	`}`