Make more possible combinations of start and stop points emit warnings

Author: wxtim

cylc/flow/config.py

@@ -433,6 +433,7 @@ def __init__(
         self.process_start_cycle_point()
         self.process_final_cycle_point()
         self.process_stop_cycle_point()
+        self.start_point_checks()
 
         # Parse special task cycle point offsets, and replace family names.
         LOG.debug("Parsing [special tasks]")
@@ -756,6 +757,7 @@ def process_start_cycle_point(self) -> None:
             if self.options.startcp == 'now':
                 self.options.startcp = get_current_time_string()
             self.start_point = get_point(self.options.startcp).standardise()
+
         elif starttask:
             # Start from designated task(s).
             # Select the earliest start point for use in pre-initial ignore.
@@ -774,6 +776,30 @@ def process_start_cycle_point(self) -> None:
             # Start from the initial point.
             self.start_point = self.initial_point
 
+    def start_point_checks(self):
+        """Check that the start point makes sense.
+        """
+        if not self.start_point:
+            return
+        elif self.start_point < self.initial_point:
+            LOG.warning(
+                f"Start cycle point '{self.start_point}' will have no "
+                "effect as it is before the initial cycle "
+                f"point '{self.initial_point}'."
+            )
+        elif self.start_point > self.final_point:
+            LOG.warning(
+                f"Start cycle point '{self.start_point}' will have no "
+                "effect as it is after the final cycle "
+                f"point '{self.final_point}'."
+            )
+        elif self.start_point > self.stop_point:
+            LOG.warning(
+                f"Stop cycle point '{self.stop_point}' will have no "
+                "effect as it is before the start cycle "
+                f"point '{self.start_point}'."
+            )
+
     def process_final_cycle_point(self) -> None:
         """Validate and set the final cycle point from flow.cylc or options.
 
@@ -864,6 +890,16 @@ def process_stop_cycle_point(self) -> None:
                     f"point '{self.final_point}'."
                 )
                 self.stop_point = None
+            if (
+                self.stop_point is not None
+                and self.stop_point < self.initial_point
+            ):
+                LOG.warning(
+                    f"Stop cycle point '{self.stop_point}' will have no "
+                    "effect as it is before the initial cycle "
+                    f"point '{self.initial_point}'."
+                )
+                self.stop_point = None
             stopcp_str = str(self.stop_point) if self.stop_point else None
             self.cfg['scheduling']['stop after cycle point'] = stopcp_str
 

tests/integration/test_config.py

@@ -681,9 +681,16 @@ async def test_invalid_starttask(one_conf, flow, scheduler, start):
             "Stop cycle point '20030101T0000Z' will have no effect as it"
             " is after the final cycle point '20020101T0000Z'."
         ),
-        # Not detectable from validate
-        # ('initial', 'stop', 'start', 'final', False, "asdf"),
-        # ('initial', 'stop', 'final', 'start', False, "asdf"),
+        (
+            'initial', 'stop', 'start', 'final', False,
+            "Stop cycle point '20010101T0000Z' will have no effect as it"
+            " is before the start cycle point '20020101T0000Z'."
+        ),
+        (
+            'initial', 'stop', 'final', 'start', False,
+            "Start cycle point '20030101T0000Z' will have no effect as it"
+            " is after the final cycle point '20020101T0000Z'."
+        ),
         (
             'initial', 'final', 'start', 'stop', True,
             "Stop cycle point '20030101T0000Z' will have no effect as it"
@@ -694,7 +701,11 @@ async def test_invalid_starttask(one_conf, flow, scheduler, start):
             "Stop cycle point '20020101T0000Z' will have no effect as it"
             " is after the final cycle point '20010101T0000Z'."
         ),
-        # ('start', 'initial', 'stop', 'final', True, "asdf"),
+        (
+            'start', 'initial', 'stop', 'final', False,
+            "Start cycle point '20000101T0000Z' will have no effect as it"
+            " is before the initial cycle point '20010101T0000Z'."
+        ),
         (
             'start', 'initial', 'final', 'stop', True,
             "Stop cycle point '20030101T0000Z' will have no effect as it"
@@ -734,8 +745,19 @@ async def test_invalid_starttask(one_conf, flow, scheduler, start):
         ('final', 'stop', 'start', 'initial', True, WorkflowConfigError),
     )
 )
-def test_milestone_cycle_points(
-    a, b, c, d, validation_fail, err, flow, validate, scheduler, start, caplog
+async def test_milestone_cycle_points(
+    a,
+    b,
+    c,
+    d,
+    validation_fail,
+    err,
+    flow,
+    validate,
+    scheduler,
+    start,
+    log_filter,
+    caplog,
 ):
     """Ensure that all combinations of 
     """
@@ -749,11 +771,18 @@ def test_milestone_cycle_points(
             'graph': {'P1Y': 'foo'}
         },
     })
-    if not err:
-        validate(wid)
-    elif isinstance(err, str):
-        validate(wid)
-        assert err in caplog.messages
-    else:
-        with pytest.raises(err):
+    if validation_fail:
+        if not err:
             validate(wid)
+        elif isinstance(err, str):
+            validate(wid)
+            assert err in caplog.messages
+        else:
+            with pytest.raises(err):
+                validate(wid)
+
+    else:
+        schd = scheduler(wid, startcp=str(order['start']))
+        async with start(schd) as log:
+            assert err in caplog.messages
+