Pseudo private function _convertCase

Validate convertCase option values

Author: danivek

lib/JSONAPISerializer.js

@@ -22,7 +22,7 @@ module.exports = class JSONAPISerializer {
       })).default({}),
       topLevelLinks: joi.object().default({}),
       topLevelMeta: joi.object().default({}),
-      convertCase: joi.string(),
+      convertCase: joi.string().valid('kebab-case', 'snake_case', 'camelCase'),
     }).required();
 
     const validated = joi.validate(options, optionsSchema);
@@ -115,7 +115,7 @@ module.exports = class JSONAPISerializer {
     let serializedAttributes = _.pick(data, _.difference(Object.keys(data), _.concat([options.id], Object.keys(options.relationships), options.blacklist)));
 
     if (options.convertCase) {
-      serializedAttributes = this.convertCase(serializedAttributes, options.convertCase);
+      serializedAttributes = this._convertCase(serializedAttributes, options.convertCase);
     }
 
     return serializedAttributes;
@@ -132,7 +132,7 @@ module.exports = class JSONAPISerializer {
         data: this.serializeRelationship(rOptions.type, data[relationship], this.schemas[options.relationships[relationship].type][schema], included),
       };
 
-      relationship = (options.convertCase) ? this.convertCase(relationship, options.convertCase) : relationship;
+      relationship = (options.convertCase) ? this._convertCase(relationship, options.convertCase) : relationship;
 
       _.set(serializedRelationships, relationship, serializeRelationship);
     });
@@ -187,14 +187,14 @@ module.exports = class JSONAPISerializer {
     return !_.isEmpty(processedOptions) ? processedOptions : undefined;
   }
 
-  convertCase(data, convertCaseOptions) {
+  _convertCase(data, convertCaseOptions) {
     let converted;
     if (_.isArray(data) || _.isPlainObject(data)) {
       converted = _.transform(data, (result, value, key) => {
         if (_.isArray(value) || _.isPlainObject(value)) {
-          result[this.convertCase(key, convertCaseOptions)] = this.convertCase(value, convertCaseOptions);
+          result[this._convertCase(key, convertCaseOptions)] = this._convertCase(value, convertCaseOptions);
         } else {
-          result[this.convertCase(key, convertCaseOptions)] = value;
+          result[this._convertCase(key, convertCaseOptions)] = value;
         }
       });
     } else {
@@ -208,9 +208,7 @@ module.exports = class JSONAPISerializer {
         case 'camelCase':
           converted = _.camelCase(data);
           break;
-        default:
-          converted = data;
-          break;
+        default: // Do nothing
       }
     }
 

test/unit/JSONAPISerializer.test.js

@@ -417,30 +417,6 @@ describe('JSONAPISerializer', function() {
       expect(serializedAttributes.address).to.have.property('zipCode');
       done();
     });
-
-    it('should not convert attributes with unsupported format', function(done) {
-      const Serializer = new JSONAPISerializer();
-      Serializer.register('articles', {
-        convertCase: 'unsupported'
-      });
-      const data = {
-        id: '1',
-        firstName: 'firstName',
-        lastName: 'lastName',
-        articles: [{
-          createdAt: '2016-06-04T06:09:24.864Z'
-        }],
-        address: {
-          zipCode: 123456
-        }
-      };
-      const serializedAttributes = Serializer.serializeAttributes(data, Serializer.schemas.articles.default);
-      expect(serializedAttributes).to.have.property('firstName');
-      expect(serializedAttributes).to.have.property('lastName');
-      expect(serializedAttributes.articles[0]).to.have.property('createdAt');
-      expect(serializedAttributes.address).to.have.property('zipCode');
-      done();
-    });
   });
 
   describe('serializeIncluded', function() {