Connection manager with macros

Author: satyamsufi

src/e2e-test/features/servicenowmultisource/DesignTimeValidation.feature

@@ -26,11 +26,6 @@ Feature: ServiceNow Multi Source - Design time validation scenarios
     And Click on the Validate button
     Then Verify mandatory property error for below listed properties:
       | referenceName   |
-      | clientId        |
-      | clientSecret    |
-      | restApiEndpoint |
-      | user            |
-      | password        |
 
   @TS-SN-MULTI-DSGN-ERROR-02
   Scenario: Verify validation message for invalid table name

src/e2e-test/features/servicenowmultisource/DesignTimeWithMacros.feature

@@ -39,6 +39,6 @@ Feature: ServiceNow Multi Source - Design time scenarios (macro)
     And Navigate to the properties page of plugin: "ServiceNow Multi Source"
     And Fill Reference Name
     And Click plugin property: "switch-useConnection"
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     And Click on the Macro button of Property: "tableNames" and set the value to: "tableNames"
     Then Validate "ServiceNow Multi Source" plugin properties

src/e2e-test/features/servicenowmultisource/RunTimeWithMacros.feature

@@ -154,7 +154,7 @@ Feature: ServiceNow Multi Source - Run time scenarios (macro)
     Then Click on the Test Connection button
     And Verify the test connection is successful
     Then Click on the Create button
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     Then Validate "ServiceNow Multi Source" plugin properties
     And Close the Plugin Properties page
     And Select Sink plugin: "BigQueryMultiTable" from the plugins list

src/e2e-test/features/servicenowsink/DesignTimeValidation.feature

@@ -25,11 +25,6 @@ Feature: ServiceNow Sink - Design time validation scenarios
     And Click on the Validate button
     Then Verify mandatory property error for below listed properties:
       | referenceName   |
-      | clientId        |
-      | clientSecret    |
-      | restApiEndpoint |
-      | user            |
-      | password        |
 
   @TS-SN-DSGN-SINK-ERROR-02
   Scenario: Verify invalid credentials validation messages

src/e2e-test/features/servicenowsink/DesignTimeWithMacro.feature

@@ -83,7 +83,7 @@ Feature: ServiceNow Sink - Design time validation scenarios (macro)
     And Navigate to the properties page of plugin: "ServiceNow"
     And Fill Reference Name
     And Click plugin property: "switch-useConnection"
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     And Enter input plugin property: "tableName" with value: "receiving_slip_line"
     Then Validate "ServiceNow" plugin properties
 

src/e2e-test/features/servicenowsink/RunTimeWithMacros.feature

@@ -213,7 +213,7 @@ Feature: ServiceNow Sink - Run time scenarios (macro)
     And Fill Reference Name
     And Select radio button plugin property: "operation" with value: "INSERT"
     And Click on the Macro button of Property: "tableName" and set the value to: "tableName"
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     And Validate "ServiceNow" plugin properties
     And Close the Plugin Properties page
     And Preview and run the pipeline

src/e2e-test/features/servicenowsource/DesignTimeValidation.feature

@@ -26,11 +26,6 @@ Feature: ServiceNow Source - Design time validation scenarios
     And Click on the Validate button
     Then Verify mandatory property error for below listed properties:
       | referenceName   |
-      | clientId        |
-      | clientSecret    |
-      | restApiEndpoint |
-      | user            |
-      | password        |
 
   @TS-SN-DSGN-ERROR-02
   Scenario: Verify invalid credentials validation messages

src/e2e-test/features/servicenowsource/DesignTimeWithMacros.feature

@@ -57,5 +57,5 @@ Feature: ServiceNow Source - Design time scenarios (macro)
     And Select mode as: "TABLE"
     And Click on the Macro button of Property: "tableName" and set the value to: "tableName"
     And Click plugin property: "switch-useConnection"
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     Then Validate "ServiceNow" plugin properties

src/e2e-test/features/servicenowsource/RunTimeWithMacros.feature

@@ -203,7 +203,7 @@ Feature: ServiceNow Source - Run time scenarios (macro)
     Then Click on the Test Connection button
     And Verify the test connection is successful
     Then Click on the Create button
-    And Click on the Macro button of Property: "Connection" and set the value to: "Connection"
+    And Click on the Macro button of Property: "connection" and set the value to: "Connection"
     Then Validate "ServiceNow" plugin properties
     And Close the Plugin Properties page
     And Select Sink plugin: "BigQueryTable" from the plugins list