Add WHERE IN support for constants

Author: michaelmior

src/modules/relexp.js

@@ -254,6 +254,30 @@ function convertExpr(
         return expr.value;
       }
 
+    case 'InExpressionListPredicate':
+      if (expr.right.type !== 'ExpressionList') {
+        // Currently IN expressions are only supported with lists of values
+        throw new Error('Query not supported');
+      }
+
+      let orIn: Array<any> = [];
+      for (const inSetElem of expr.right.value) {
+        const inExpr = {
+          type: 'ComparisonBooleanPrimary',
+          left: expr.left,
+          operator: '=',
+          right: inSetElem,
+        };
+        addToExpr(orIn, inExpr, types, tables);
+      }
+      const inOrExpr = {or: {clauses: orIn}};
+
+      if (expr.hasNot === 'NOT') {
+        return {not: {clause: inOrExpr}};
+      } else {
+        return inOrExpr;
+      }
+
     default:
       console.log(expr);
       // Produce an error if the expression is unsupported

src/modules/relexp.test.js

@@ -766,3 +766,53 @@ it('should remove quotes from string literals', () => {
     },
   });
 });
+
+/** @test {relexp} */
+it('should convert conditions with IN', () => {
+  const sql = parser.parse('SELECT * FROM foo WHERE id IN (1, 2)');
+  const action = exprFromSql(sql.value, {foo: ['id']});
+  expect(reducer({}, action)).toMatchObject({
+    expr: {
+      selection: {
+        arguments: {
+          select: {
+            or: {
+              clauses: [
+                {cmp: {lhs: 'id', op: '$eq', rhs: '1'}},
+                {cmp: {lhs: 'id', op: '$eq', rhs: '2'}},
+              ],
+            },
+          },
+        },
+        children: [{relation: 'foo'}],
+      },
+    },
+  });
+});
+
+/** @test {relexp} */
+it('should convert conditions with IN', () => {
+  const sql = parser.parse('SELECT * FROM foo WHERE id NOT IN (1, 2)');
+  const action = exprFromSql(sql.value, {foo: ['id']});
+  expect(reducer({}, action)).toMatchObject({
+    expr: {
+      selection: {
+        arguments: {
+          select: {
+            not: {
+              clause: {
+                or: {
+                  clauses: [
+                    {cmp: {lhs: 'id', op: '$eq', rhs: '1'}},
+                    {cmp: {lhs: 'id', op: '$eq', rhs: '2'}},
+                  ],
+                },
+              },
+            },
+          },
+        },
+        children: [{relation: 'foo'}],
+      },
+    },
+  });
+});