Merge pull request #96 from dbt-msft/v0.19.0_for_real

V0.19.0 for real

Author: mikaelene

CHANGELOG.md

@@ -0,0 +1,85 @@
+# Changelog
+
+### v0.19.0
+
+#### New Features:
+- dbt-sqlserver's snapshotting now 100% aligneed logically to dbt's snapshotting behavior! Users can now snapshot 'hard-deleted' record as mentioned in the [dbt v0.19.0 release notes](https://github.com/fishtown-analytics/dbt/releases/tag/v0.19.0). An added benefit is that it makes maintaining `dbt-sqlserver` by decreasing code footprint. [#81](https://github.com/dbt-msft/dbt-sqlserver/pull/81)  [fishtown-analytics/dbt#3003](https://github.com/fishtown-analytics/dbt/issues/3003)
+#### Fixes:
+- small snapshot bug addressed via [#81](https://github.com/dbt-msft/dbt-sqlserver/pull/81)
+- support for clustered columnstore index creation pre SQL Server 2016. [#88](https://github.com/dbt-msft/dbt-sqlserver/pull/88) thanks [@alangsbo](https://github.com/alangsbo)
+- support for scenarios where the target db's collation is different than the server's [#87](https://github.com/dbt-msft/dbt-sqlserver/pull/87) [@alangsbo](https://github.com/alangsbo)
+
+#### Under the hood:
+- This adapter has separate CI tests to ensure all the connection methods are working as they should [#75](https://github.com/dbt-msft/dbt-sqlserver/pull/75)
+
+### v0.18.1
+#### New Features:
+Adds support for:
+- SQL Server down to version 2012 
+- authentication via:
+    - Azure CLI (see #71, thanks @JCZuurmond !), and
+    - MSFT ODBC Active Directory options (#53 #55 #58 thanks to @NandanHegde15 and @alieus) 
+- using a named instance (#51 thanks @alangsbo)
+- Adds support down to SQL Server 2012
+- The adapter is now automatically tested with Fishtowns official adapter-tests to increase stability when making 
+changes and upgrades to the adapter.
+
+#### Fixes:
+- Fix for lack of precision in the snapshot check strategy. Previously when executing two check snapshots the same
+second, there was inconsistent data as a result. This was mostly noted when running the automatic adapter tests. 
+NOTE: This fix will create a new snapshot version in the target table
+on first run after upgrade.
+
+### v0.18.0.1
+#### New Features:
+- Adds support for Azure Active Directory as authentication provider
+
+#### Fixes:
+- Fix for lack of precision in the snapshot check strategy. (#74 and #56 thanks @qed) Previously when executing two check snapshots the same second, there was inconsistent data as a result. This was mostly noted when running the automatic adapter tests. 
+NOTE: This fix will create a new snapshot version in the target table
+on first run after upgrade.
+- #52 Fix deprecation warning (Thanks @jnoynaert)
+
+#### Testing
+- The adapter is now automatically tested with Fishtowns official adapter-tests to increase stability when making changes and upgrades to the adapter. (#62 #64 #69 #74)
+- We are also now testing specific target configs to make the devs more confident that everything is in working order (#75)
+
+### v0.18.0
+#### New Features:
+- Adds support for dbt v0.18.0
+
+### v0.15.3.1
+
+#### Fixes:
+- Snapshots did not work on dbt v0.15.1 to v0.15.3
+
+### v0.15.3
+
+#### Fixes:
+- Fix output of sql in the log files.
+- Limited the version of dbt to 0.15, since later versions are unsupported.
+
+### v0.15.2
+
+#### Fixes:
+- Fixes an issue with clustered columnstore index not beeing created.
+
+
+### v0.15.1
+#### New Features:
+- Ability to define an index in a poosthook
+
+#### Fixes:
+- Previously when a model run was interupted unfinished models prevented the next run and you had to manually delete them. This is now fixed so that unfinished models will be deleted on next run.
+
+### v0.15.0.1
+Fix release for v0.15.0
+#### Fixes:
+- Setting the port had no effect. Issue #9
+- Unable to generate docs. Issue #12
+
+### v0.15.0
+Requires dbt v0.15.0 or greater
+
+### pre v0.15.0
+Requires dbt v0.14.x

README.md

@@ -183,74 +183,4 @@ Example of applying Unique clustered index on two columns, Ordinary index on one
 
 ## Changelog
 
-### v0.18.1
-#### New Features:
-Adds support for:
-- SQL Server down to version 2012 
-- authentication via:
-    - Azure CLI (see #71, thanks @JCZuurmond !), and
-    - MSFT ODBC Active Directory options (#53 #55 #58 thanks to @NandanHegde15 and @alieus) 
-- using a named instance (#51 thanks @alangsbo)
-- Adds support down to SQL Server 2012
-- The adapter is now automatically tested with Fishtowns official adapter-tests to increase stability when making 
-changes and upgrades to the adapter.
-
-#### Fixes:
-- Fix for lack of precision in the snapshot check strategy. Previously when executing two check snapshots the same
-second, there was inconsistent data as a result. This was mostly noted when running the automatic adapter tests. 
-NOTE: This fix will create a new snapshot version in the target table
-on first run after upgrade.
-
-### v0.18.0.1
-#### New Features:
-- Adds support for Azure Active Directory as authentication provider
-
-#### Fixes:
-- Fix for lack of precision in the snapshot check strategy. (#74 and #56 thanks @qed) Previously when executing two check snapshots the same second, there was inconsistent data as a result. This was mostly noted when running the automatic adapter tests. 
-NOTE: This fix will create a new snapshot version in the target table
-on first run after upgrade.
-- #52 Fix deprecation warning (Thanks @jnoynaert)
-
-#### Testing
-- The adapter is now automatically tested with Fishtowns official adapter-tests to increase stability when making changes and upgrades to the adapter. (#62 #64 #69 #74)
-- We are also now testing specific target configs to make the devs more confident that everything is in working order (#75)
-
-### v0.18.0
-#### New Features:
-- Adds support for dbt v0.18.0
-
-### v0.15.3.1
-
-#### Fixes:
-- Snapshots did not work on dbt v0.15.1 to v0.15.3
-
-### v0.15.3
-
-#### Fixes:
-- Fix output of sql in the log files.
-- Limited the version of dbt to 0.15, since later versions are unsupported.
-
-### v0.15.2
-
-#### Fixes:
-- Fixes an issue with clustered columnstore index not beeing created.
-
-
-### v0.15.1
-#### New Features:
-- Ability to define an index in a poosthook
-
-#### Fixes:
-- Previously when a model run was interupted unfinished models prevented the next run and you had to manually delete them. This is now fixed so that unfinished models will be deleted on next run.
-
-### v0.15.0.1
-Fix release for v0.15.0
-#### Fixes:
-- Setting the port had no effect. Issue #9
-- Unable to generate docs. Issue #12
-
-### v0.15.0
-Requires dbt v0.15.0 or greater
-
-### pre v0.15.0
-Requires dbt v0.14.x
+See [the changelog](CHANGELOG.md)

dbt/__init__.py

@@ -1 +1 @@
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)

dbt/adapters/__init__.py

@@ -1 +1 @@
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)

dbt/adapters/sqlserver/__version__.py

@@ -1 +1 @@
-version = '0.19.0rc2'
+version = '0.19.0'

dbt/include/__init__.py

@@ -1 +1 @@
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)

dbt/include/sqlserver/macros/adapters.sql

@@ -128,7 +128,12 @@
   {%- set cci_name = relation.schema ~ '_' ~ relation.identifier ~ '_cci' -%}
   {%- set relation_name = relation.schema ~ '_' ~ relation.identifier -%}
   {%- set full_relation = relation.schema ~ '.' ~ relation.identifier -%}
-  DROP INDEX IF EXISTS {{relation_name}}.{{cci_name}}
+  if EXISTS (
+        SELECT * FROM
+        sys.indexes WHERE name = '{{cci_name}}'
+        AND object_id=object_id('{{relation_name}}')
+    )
+  DROP index {{full_relation}}.{{cci_name}}
   CREATE CLUSTERED COLUMNSTORE INDEX {{cci_name}}
     ON {{full_relation}}
 {% endmacro %}
@@ -193,8 +198,8 @@
           UNION ALL
           select
               ordinal_position,
-              column_name,
-              data_type,
+              column_name collate database_default,
+              data_type collate database_default,
               character_maximum_length,
               numeric_precision,
               numeric_scale
@@ -219,4 +224,4 @@
 {% macro sqlserver__snapshot_string_as_time(timestamp) -%}
     {%- set result = "CONVERT(DATETIME2, '" ~ timestamp ~ "')" -%}
     {{ return(result) }}
-{%- endmacro %}
+{%- endmacro %}

requirements.txt

@@ -1,4 +1,4 @@
-dbt-core==0.19.0rc2
+dbt-core==0.19.0
 pyodbc>=4.0.27
 azure-identity>=1.4.0
 black~=20.8b1

setup.py

@@ -57,7 +57,7 @@ def _dbt_sqlserver_version():
         ]
     },
     install_requires=[
-        'dbt-core==0.19.0rc2',
+        'dbt-core~=0.19.0',
         "pyodbc>=4.0.27",
         "azure-identity>=1.4.0",
     ]