Skip to content

Commit a2eb26f

Browse files
committed
Fix two e2e test, add back a flappy test comment
This needed for last build to build.
1 parent 9ef9b55 commit a2eb26f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

tests/e2e-wdio7/specs/embcom.sort-order-op-likes-btn-txt.2br.ec.e2e.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ describe("embcom.sort-order-op-likes-btn-txt.2br.ec TyTEMBSORTLIKETXT", () => {
242242
it("Maria adds a comment", async () => {
243243
// Wait until Maria's data added, otherwise if clicking Reply before that,
244244
// the login dialog pops up and the test breaks.
245+
// E2EBUG flappy & Breaks anyway, just like before.
245246
await mariasBrowser.switchToEmbeddedCommentsIrame();
246247
await mariasBrowser.waitForMyDataAdded();
247248
await mariasBrowser.complex.replyToEmbeddingBlogPost("Hi I am here");

tests/e2e-wdio7/specs/modn-ban-from-disc-page.2br.f.e2e.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,11 +302,12 @@ describe(`modn-ban-from-disc-page.2br.f TyTEBANFROMDISC`, () => {
302302
it(`... it's been deleted`, async () => {
303303
await modya_brA.topic.waitUntilPageDeleted();
304304
});
305+
/*
305306
it(`... and Mallory's two comments (same page) also deleted`, async () => {
306-
// Ooops but these won't be loaded ,since deld.
307+
// Ooops but [deleted_comment_not_loaded].
307308
await modya_brA.topic.waitForPostVisibleAsDeleted(c.FirstReplyNr);
308309
await modya_brA.topic.waitForPostVisibleAsDeleted(c.SecondReplyNr);
309-
});
310+
}); */
310311

311312
it(`Modya goes to Mallory's other new topic`, async () => {
312313
await modya_brA.go2(mallorysPagesFn().topicTwoUrl);
@@ -323,7 +324,8 @@ describe(`modn-ban-from-disc-page.2br.f TyTEBANFROMDISC`, () => {
323324
const counts = await modya_brA.topic.countReplies();
324325
assert.deepEq(counts, {
325326
numNormal: 0, numDrafts: 0, numPreviews: 0, numUnapproved: 0,
326-
// Deleted comments aren't loaded, unless there's non-deleted replies to them.
327+
// Currently, [deleted_comment_not_loaded], unless there's non-deleted
328+
// replies to them.
327329
numDeleted: 0 });
328330
});
329331

tests/e2e-wdio7/utils/ty-e2e-test-browser.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5873,7 +5873,6 @@ export class TyE2eTestBrowser {
58735873
if (!isGone)
58745874
throw `Not yet gone: ${submitSelector}`;
58755875
});
5876-
await this.waitUntilModalGone();
58775876
}
58785877
};
58795878

0 commit comments

Comments
 (0)