Centralize logging of the profile exceptions (#5673)

mikhail-dcl · m3taphysics · web-flow · commit 79bd6e19c7b2 · 2025-10-15T13:52:42.000Z
* Introduce a custom retry policy for profiles (which is more Catalyst aware)
* NOT_FOUND - to contain the enforced lambdas URL
* Clean up local profile-related exceptions
* Properly suppress exceptions where they are not expected

Signed-off-by: Ashley Canning &lt;ashley.canning@decentraland.org&gt;
Co-authored-by: Ashley Canning &lt;ashley.canning@decentraland.org&gt;
diff --git a/Explorer/Assets/DCL/Chat/_Refactor/ChatCommands/CreateChannelViewModelCommand.cs b/Explorer/Assets/DCL/Chat/_Refactor/ChatCommands/CreateChannelViewModelCommand.cs
@@ -9,6 +9,7 @@
 using DCL.Profiles;
 using DCL.UI.ProfileElements;
 using DCL.UI.Profiles.Helpers;
+using DCL.Utilities.Extensions;
 using DCL.VoiceChat;
 using System;
 using System.Threading;
@@ -126,7 +127,7 @@ private async UniTaskVoid FetchCommunityThumbnailAndUpdateAsync(CommunityChannel
 
         private async UniTaskVoid FetchProfileAndUpdateAsync(UserChannelViewModel viewModel, CancellationToken ct)
         {
-            Profile? profile = await profileRepository.GetProfileAsync(viewModel.Id.Id, ct);
+            Profile? profile = await profileRepository.GetProfileAsync(viewModel.Id.Id, ct).SuppressAnyExceptionWithFallback(null);
 
             if (ct.IsCancellationRequested) return;
 
diff --git a/Explorer/Assets/DCL/Friends/UI/FriendPanel/Sections/Friends/FriendListRequestManager.cs b/Explorer/Assets/DCL/Friends/UI/FriendPanel/Sections/Friends/FriendListRequestManager.cs
@@ -2,6 +2,7 @@
 using DCL.Diagnostics;
 using DCL.Profiles;
 using DCL.UI.Profiles.Helpers;
+using DCL.Utilities.Extensions;
 using SuperScrollView;
 using System;
 using System.Collections.Generic;
diff --git a/Explorer/Assets/DCL/Infrastructure/MVC/MVCFacade/MVCManagerMenusAccessFacade.cs b/Explorer/Assets/DCL/Infrastructure/MVC/MVCFacade/MVCManagerMenusAccessFacade.cs
@@ -107,7 +107,7 @@ public async UniTask ShowChatEntryMenuPopupAsync(ChatEntryMenuPopupData data, Ca
         public async UniTask ShowUserProfileContextMenuFromWalletIdAsync(Web3Address walletId, Vector3 position, Vector2 offset, CancellationToken ct, UniTask closeMenuTask,
             Action onHide = null, MenuAnchorPoint anchorPoint = MenuAnchorPoint.DEFAULT, Action onShow = null)
         {
-            Profile profile = await profileRepository.GetAsync(walletId, ct);
+            Profile? profile = await profileRepository.GetAsync(walletId, ct);
 
             if (profile == null)
                 return;
@@ -120,7 +120,7 @@ public async UniTask ShowCommunityPlayerEntryContextMenuAsync(string participant
             if (string.IsNullOrEmpty(participantWalletId)) return;
 
             Web3Address walletId = new Web3Address(participantWalletId);
-            Profile profile = await profileRepository.GetAsync(walletId, ct);
+            Profile? profile = await profileRepository.GetAsync(walletId, ct);
 
             if (profile == null) return;
 
diff --git a/Explorer/Assets/DCL/Multiplayer/Profiles/RemoteProfiles/RemoteProfiles.cs b/Explorer/Assets/DCL/Multiplayer/Profiles/RemoteProfiles/RemoteProfiles.cs
@@ -104,27 +104,17 @@ private async UniTaskVoid TryDownloadAsync(RemoteAnnouncement remoteAnnouncement
                 Profile? profile = await profileRepository.GetAsync(remoteAnnouncement.WalletId, remoteAnnouncement.Version, lambdasEndpoint, cts.Token);
 
                 if (profile is null)
-                {
-                    ReportHub.LogError(ReportCategory.PROFILE, $"Profile not found {remoteAnnouncement} after {(DateTime.Now - startedAt).TotalSeconds} s.");
                     return;
-                }
 
                 // Take the room source from the dictionary as the value could be updated
                 remoteProfiles.Add(new RemoteProfile(profile, remoteAnnouncement.WalletId, pendingProfiles[remoteAnnouncement.WalletId].FromRoom));
 
                 ReportHub.Log(ReportCategory.PROFILE,
                     $"{remoteAnnouncement} was downloaded for {(DateTime.Now - startedAt).TotalSeconds} s.");
             }
-            catch (OperationCanceledException)
-            {
-                // ignore cancellation
-            }
             catch (Exception)
             {
-                ReportHub.Log(ReportCategory.PROFILE,
-                    $"{remoteAnnouncement} threw an exception after {(DateTime.Now - startedAt).TotalSeconds} s.");
-
-                throw;
+                // exceptions are logged by the remote repository
             }
             finally
             {
diff --git a/Explorer/Assets/DCL/Notifications/NotificationsMenu/NotificationsMenuController.cs b/Explorer/Assets/DCL/Notifications/NotificationsMenu/NotificationsMenuController.cs
@@ -10,6 +10,7 @@
 using DCL.UI.SharedSpaceManager;
 using DCL.UI.Utilities;
 using DCL.Utilities;
+using DCL.Utilities.Extensions;
 using DCL.Web3.Identities;
 using DCL.WebRequests;
 using MVC;
@@ -267,7 +268,7 @@ private void ClickedNotification(NotificationType notificationType, INotificatio
             NotificationsBusController.Instance.ClickNotification(notificationType, notification);
         }
 
-        private async UniTask LoadNotificationThumbnailAsync(INotificationView notificationImage, INotification notificationData,
+        private async UniTaskVoid LoadNotificationThumbnailAsync(INotificationView notificationImage, INotification notificationData,
             DefaultNotificationThumbnail defaultThumbnail, CancellationToken ct)
         {
             if (notificationData.Type == NotificationType.REFERRAL_INVITED_USERS_ACCEPTED)
@@ -315,7 +316,7 @@ private async UniTask LoadNotificationThumbnailAsync(INotificationView notificat
 
             async UniTask<Sprite?> DownloadProfileThumbnailAsync(string user)
             {
-                Profile? profile = await profileRepository.GetProfileAsync(user, ct);
+                Profile? profile = await profileRepository.GetProfileAsync(user, ct).SuppressAnyExceptionWithFallback(null);
 
                 if (profile != null)
                     return await profileRepository.GetProfileThumbnailAsync(profile.Avatar.FaceSnapshotUrl, ct);
diff --git a/Explorer/Assets/DCL/Passport/Modules/EquippedItems_PassportModuleController.cs b/Explorer/Assets/DCL/Passport/Modules/EquippedItems_PassportModuleController.cs
@@ -264,7 +264,7 @@ CancellationToken ct
             {
                 const string ERROR_MESSAGE = "There was an error while trying to load the equipped items. Please try again!";
                 passportErrorsController.Show(ERROR_MESSAGE);
-                ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
+                ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
             }
         }
 
@@ -281,7 +281,7 @@ private async UniTaskVoid WaitForThumbnailAsync(IWearable itemWearable, Equipped
                 itemView.EquippedItemThumbnail.sprite = null;
                 const string ERROR_MESSAGE = "There was an error while trying to load wearable thumbnails. Please try again!";
                 passportErrorsController.Show(ERROR_MESSAGE);
-                ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
+                ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
             }
         }
 
@@ -298,7 +298,7 @@ private async UniTaskVoid WaitForThumbnailAsync(IEmote itemEmote, EquippedItem_P
                 itemView.EquippedItemThumbnail.sprite = null;
                 const string ERROR_MESSAGE = "There was an error while trying to load emote thumbnails. Please try again!";
                 passportErrorsController.Show(ERROR_MESSAGE);
-                ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
+                ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
             }
         }
 
diff --git a/Explorer/Assets/DCL/Passport/PassportController.cs b/Explorer/Assets/DCL/Passport/PassportController.cs
@@ -567,11 +567,10 @@ private async UniTaskVoid LoadPassportSectionAsync(string userId, PassportSectio
                 alreadyLoadedSections |= sectionToLoad;
             }
             catch (OperationCanceledException) { }
-            catch (Exception e)
+            catch (Exception)
             {
                 const string ERROR_MESSAGE = "There was an error while opening the Passport. Please try again!";
                 passportErrorsController!.Show(ERROR_MESSAGE);
-                ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
             }
         }
 
@@ -729,7 +728,7 @@ private async UniTaskVoid OpenPassportFromBadgeNotificationAsync(string badgeIdT
             {
                 const string ERROR_MESSAGE = "There was an error while opening the Badges section into the Passport. Please try again!";
                 passportErrorsController!.Show(ERROR_MESSAGE);
-                ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");
+                ReportHub.LogException(e, ReportCategory.PROFILE);
             }
         }
 
diff --git a/Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/Handlers/StaticDebouncer.cs b/Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/Handlers/StaticDebouncer.cs
@@ -11,9 +11,25 @@ public partial class StaticDebouncer : IReportsDebouncer
     {
         private readonly HashSet<ReportMessageFingerprint> fingerprints = new ();
 
-        public ReportHandler AppliedTo => ReportHandler.All;
+        public StaticDebouncer() : this(ReportHandler.All) { }
+
+        internal StaticDebouncer(ReportHandler appliedTo)
+        {
+            AppliedTo = appliedTo;
+        }
+
+        public ReportHandler AppliedTo { get; }
 
         public bool Debounce(ReportMessageFingerprint fingerprint) =>
             !fingerprints.Add(fingerprint);
     }
+
+    /// <summary>
+    ///     <inheritdoc cref="StaticDebouncer" />. Applies only to Sentry reports.
+    /// </summary>
+    [Singleton(SingletonGenerationBehavior.ALLOW_IMPLICIT_CONSTRUCTION)]
+    public partial class SentryStaticDebouncer : StaticDebouncer
+    {
+        public SentryStaticDebouncer() : base(ReportHandler.Sentry) { }
+    }
 }
diff --git a/Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportsHandlingSettingsProduction.asset b/Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportsHandlingSettingsProduction.asset
@@ -394,6 +394,8 @@ MonoBehaviour:
       Severity: 0
     - Category: DEBUG
       Severity: 0
+    - Category: PROFILE
+      Severity: 0
   sentryMatrix:
     entries:
     - Category: AUDIO_SOURCES
diff --git a/Explorer/Assets/DCL/Profiles/Repository/CatalystRetryPolicy.cs b/Explorer/Assets/DCL/Profiles/Repository/CatalystRetryPolicy.cs
@@ -0,0 +1,22 @@
+﻿using DCL.WebRequests;
+
+namespace DCL.Profiles
+{
+    /// <summary>
+    ///     Catalysts are prone to huge replication delays.
+    ///     This special non-strict policy allows more retry attempts with bigger delays between them.
+    /// </summary>
+    public static class CatalystRetryPolicy
+    {
+        /// <summary>
+        ///     k=1 → 2000 × 2^0 = 2000 ms (2.00 s) <br />
+        ///     k=2 → 2000 × 2^1 = 4000 ms (4.00 s) <br />
+        ///     k=3 → 2000 × 2^2 = 8000 ms (8.00 s) <br />
+        ///     k=4 → 2000 × 2^3 = 16000 ms (16.00 s) <br />
+        ///     k=5 → 2000 × 2^4 = 32000 ms (32.00 s) <br />
+        ///     k=6 → 2000 × 2^5 = 64000 ms → capped at 60000 ms (60.00 s) <br />
+        ///     Total wait time ≈ 122 s (~2.0 minutes)
+        /// </summary>
+        public static readonly RetryPolicy VALUE = RetryPolicy.Enforce(6, 2000, 2);
+    }
+}
diff --git a/Explorer/Assets/DCL/Profiles/Repository/CatalystRetryPolicy.cs.meta b/Explorer/Assets/DCL/Profiles/Repository/CatalystRetryPolicy.cs.meta
diff --git a/Explorer/Assets/DCL/Profiles/Repository/RealmProfileRepository.cs b/Explorer/Assets/DCL/Profiles/Repository/RealmProfileRepository.cs
@@ -126,7 +126,9 @@ private static IpfsProfileEntity NewPublishProfileEntity(Profile profile, GetPro
             try
             {
                 URLAddress url = Url(id, fromCatalyst);
-                GenericDownloadHandlerUtils.Adapter<GenericGetRequest, GenericGetArguments> response = webRequestController.GetAsync(new CommonArguments(url), ct, ReportCategory.REALM, ignoreErrorCodes: IWebRequestController.IGNORE_NOT_FOUND);
+
+                // Suppress logging errors here as we have very custom errors handling below
+                GenericDownloadHandlerUtils.Adapter<GenericGetRequest, GenericGetArguments> response = webRequestController.GetAsync(new CommonArguments(url, CatalystRetryPolicy.VALUE), ct, ReportCategory.PROFILE, suppressErrors: true);
 
                 using GetProfileJsonRootDto? root = await response.CreateFromNewtonsoftJsonAsync<GetProfileJsonRootDto>(
                     createCustomExceptionOnFailure: (exception, text) => new ProfileParseException(id, version, text, exception),
@@ -150,11 +152,19 @@ private static IpfsProfileEntity NewPublishProfileEntity(Profile profile, GetPro
 
                 return profile;
             }
-            catch (UnityWebRequestException e)
+            catch (UnityWebRequestException e) when (e is { ResponseCode: WebRequestUtils.NOT_FOUND })
             {
-                if (e.ResponseCode == WebRequestUtils.NOT_FOUND)
-                    return null;
+                // Report to console every time
+                // Report to Sentry only once per session (protect from spamming)
+                ReportHub.LogError(new ReportData(ReportCategory.PROFILE, new ReportDebounce(SentryStaticDebouncer.Instance)),
+                    $"Profile not found (Version: {version}, WalletId: {id})\nFrom Catalyst: {fromCatalyst}");
 
+                return null;
+            }
+            catch (Exception e) when (e is not OperationCanceledException)
+            {
+                // Report other exceptions normally
+                ReportHub.LogException(e, ReportCategory.PROFILE);
                 throw;
             }
             finally
diff --git a/Explorer/Assets/DCL/Profiles/SharedAPI/IProfileRepository.cs b/Explorer/Assets/DCL/Profiles/SharedAPI/IProfileRepository.cs
@@ -12,18 +12,22 @@ public interface IProfileRepository
 
         UniTask SetAsync(Profile profile, CancellationToken ct);
 
+        /// <returns>
+        ///     'Null' if Not Found; <br />
+        ///     Logs and re-throws all exceptions. They should be caught on the caller side if needed. Logging on the caller side is optional; <br />
+        /// </returns>
         UniTask<Profile?> GetAsync(string id, int version, URLDomain? fromCatalyst, CancellationToken ct, bool getFromCacheIfPossible = true);
     }
 
     public static class ProfileRepositoryExtensions
     {
+        /// <summary>
+        ///     Suppresses inner exceptions to 'Null' return value
+        /// </summary>
         public static UniTask<Profile?> GetAsync(this IProfileRepository profileRepository, string id, CancellationToken ct) =>
-            profileRepository.GetAsync(id, 0, null, ct);
+            profileRepository.GetAsync(id, 0, null, ct).SuppressAnyExceptionWithFallback(null);
 
         public static UniTask<Profile?> GetAsync(this IProfileRepository profileRepository, string id, int version, CancellationToken ct, bool getFromCacheIfPossible = true) =>
             profileRepository.GetAsync(id, version, null, ct, getFromCacheIfPossible);
-
-        public static async UniTask<Profile> EnsuredProfileAsync(this IProfileRepository profileRepository, string id, CancellationToken ct) =>
-            (await profileRepository.GetAsync(id, ct)).EnsureNotNull();
     }
 }
diff --git a/Explorer/Assets/DCL/UI/Profiles/ProfileElements/SimpleProfileView.cs b/Explorer/Assets/DCL/UI/Profiles/ProfileElements/SimpleProfileView.cs
@@ -1,6 +1,7 @@
 using Cysharp.Threading.Tasks;
 using DCL.Profiles;
 using DCL.UI.Profiles.Helpers;
+using DCL.Utilities.Extensions;
 using DCL.Web3;
 using MVC;
 using System;
@@ -40,7 +41,7 @@ public async UniTaskVoid SetupAsync(Web3Address playerId, ProfileRepositoryWrapp
         {
             this.profileRepositoryWrapper = profileDataProvider;
             currentWalledId = new Web3Address("");
-            Profile? profile = await profileRepositoryWrapper.GetProfileAsync(playerId, ct);
+            Profile? profile = await profileRepositoryWrapper.GetProfileAsync(playerId, ct).SuppressAnyExceptionWithFallback(null);
 
             connectionStatusIndicatorContainer.gameObject.SetActive(profile != null);
 
diff --git a/Explorer/Assets/DCL/VoiceChat/PrivateVoiceChatController.cs b/Explorer/Assets/DCL/VoiceChat/PrivateVoiceChatController.cs
@@ -3,6 +3,7 @@
 using DCL.Profiles;
 using DCL.UI.Profiles.Helpers;
 using DCL.Utilities;
+using DCL.Utilities.Extensions;
 using LiveKit.Proto;
 using LiveKit.Rooms;
 using LiveKit.Rooms.Participants;
@@ -80,7 +81,7 @@ private async UniTaskVoid OnActiveSpeakersUpdatedAsync(CancellationToken ct)
             {
                 foreach (string activeSpeaker in voiceChatRoom.ActiveSpeakers)
                 {
-                    Profile? profileAsync = await profileDataProvider.GetProfileAsync(activeSpeaker, ct);
+                    Profile? profileAsync = await profileDataProvider.GetProfileAsync(activeSpeaker, ct).SuppressAnyExceptionWithFallback(null);
                     if (profileAsync != null) userName = profileAsync.Name;
                 }
             }
diff --git a/Explorer/Assets/DCL/WebRequests/GenericDownloadHandlerUtils.cs b/Explorer/Assets/DCL/WebRequests/GenericDownloadHandlerUtils.cs
diff --git a/Explorer/Assets/DCL/WebRequests/RetryPolicy.cs b/Explorer/Assets/DCL/WebRequests/RetryPolicy.cs
diff --git a/Explorer/Assets/DCL/WebRequests/SignedWebRequestControllerExtensions.cs b/Explorer/Assets/DCL/WebRequests/SignedWebRequestControllerExtensions.cs
diff --git a/Explorer/DCL.Profiles.csproj.DotSettings b/Explorer/DCL.Profiles.csproj.DotSettings

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ CancellationToken ct`
`264`	`264`	`{`
`265`	`265`	`const string ERROR_MESSAGE = "There was an error while trying to load the equipped items. Please try again!";`
`266`	`266`	`passportErrorsController.Show(ERROR_MESSAGE);`
`267`		`- ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
	`267`	`+ ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`
`@@ -281,7 +281,7 @@ private async UniTaskVoid WaitForThumbnailAsync(IWearable itemWearable, Equipped`
`281`	`281`	`itemView.EquippedItemThumbnail.sprite = null;`
`282`	`282`	`const string ERROR_MESSAGE = "There was an error while trying to load wearable thumbnails. Please try again!";`
`283`	`283`	`passportErrorsController.Show(ERROR_MESSAGE);`
`284`		`- ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
	`284`	`+ ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
`285`	`285`	`}`
`286`	`286`	`}`
`287`	`287`
`@@ -298,7 +298,7 @@ private async UniTaskVoid WaitForThumbnailAsync(IEmote itemEmote, EquippedItem_P`
`298`	`298`	`itemView.EquippedItemThumbnail.sprite = null;`
`299`	`299`	`const string ERROR_MESSAGE = "There was an error while trying to load emote thumbnails. Please try again!";`
`300`	`300`	`passportErrorsController.Show(ERROR_MESSAGE);`
`301`		`- ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
	`301`	`+ ReportHub.LogError(ReportCategory.WEARABLE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
`302`	`302`	`}`
`303`	`303`	`}`
`304`	`304`
Original file line number	Diff line number	Diff line change
`@@ -567,11 +567,10 @@ private async UniTaskVoid LoadPassportSectionAsync(string userId, PassportSectio`
`567`	`567`	`alreadyLoadedSections \|= sectionToLoad;`
`568`	`568`	`}`
`569`	`569`	`catch (OperationCanceledException) { }`
`570`		`- catch (Exception e)`
	`570`	`+ catch (Exception)`
`571`	`571`	`{`
`572`	`572`	`const string ERROR_MESSAGE = "There was an error while opening the Passport. Please try again!";`
`573`	`573`	`passportErrorsController!.Show(ERROR_MESSAGE);`
`574`		`- ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
`575`	`574`	`}`
`576`	`575`	`}`
`577`	`576`
`@@ -729,7 +728,7 @@ private async UniTaskVoid OpenPassportFromBadgeNotificationAsync(string badgeIdT`
`729`	`728`	`{`
`730`	`729`	`const string ERROR_MESSAGE = "There was an error while opening the Badges section into the Passport. Please try again!";`
`731`	`730`	`passportErrorsController!.Show(ERROR_MESSAGE);`
`732`		`- ReportHub.LogError(ReportCategory.PROFILE, $"{ERROR_MESSAGE} ERROR: {e.Message}");`
	`731`	`+ ReportHub.LogException(e, ReportCategory.PROFILE);`
`733`	`732`	`}`
`734`	`733`	`}`
`735`	`734`