fix

Signed-off-by: Yaroslav Borbat <[email protected]>

Author: yaroslavborbat

images/virtualization-artifact/pkg/controller/volumemigration/internal/handler/migration.go

@@ -19,6 +19,7 @@ package handler
 import (
 	"cmp"
 	"context"
+	"log/slog"
 	"slices"
 	"time"
 
@@ -33,6 +34,7 @@ import (
 	commonvd "github.com/deckhouse/virtualization-controller/pkg/common/vd"
 	commonvmop "github.com/deckhouse/virtualization-controller/pkg/common/vmop"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
+	"github.com/deckhouse/virtualization-controller/pkg/logger"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
 )
@@ -59,14 +61,20 @@ func (h *MigrationHandler) Handle(ctx context.Context, vd *v1alpha2.VirtualDisk)
 		return reconcile.Result{}, nil
 	}
 
+	log, ctx := logger.GetHandlerContext(ctx, MigrationHandlerName)
+	log.Info("Detected VirtualDisk with changed StorageClass")
+
 	ready, _ := conditions.GetCondition(vdcondition.ReadyType, vd.Status.Conditions)
-	if ready.Status != metav1.ConditionTrue {
+	if ready.Status != metav1.ConditionTrue && conditions.IsLastUpdated(ready, vd) {
+
+		log.Info("VirtualDisk is not ready. Cannot be migrated now. Skip...")
 		return reconcile.Result{}, nil
 	}
 
 	vm, err := h.getVirtualMachine(ctx, vd)
 	if err != nil {
 		if k8serrors.IsNotFound(err) {
+			log.Info("VirtualMachine not found. Cannot be migrated now. Skip...")
 			return reconcile.Result{RequeueAfter: 30 * time.Second}, nil
 		}
 		return reconcile.Result{}, err
@@ -78,6 +86,7 @@ func (h *MigrationHandler) Handle(ctx context.Context, vd *v1alpha2.VirtualDisk)
 	}
 
 	if len(migratingVMOPs) > 0 {
+		log.Info("VirtualMachine is already migrating. Skip...")
 		return reconcile.Result{}, nil
 	}
 
@@ -87,23 +96,33 @@ func (h *MigrationHandler) Handle(ctx context.Context, vd *v1alpha2.VirtualDisk)
 		// wait for 3 seconds before creating the vmop
 		// this needs to be several virtual disks will be changed if needed.
 		h.delay[vm.UID] = now.Add(3 * time.Second)
+
+		log.Info("Waiting for 3 seconds before creating the vmop")
+
 		return reconcile.Result{RequeueAfter: 3 * time.Second}, nil
 	}
 
+	log.Info("Delay is set. Waiting for the delay")
+
 	if now.Before(delay) {
 		requeueAfter := delay.Sub(now)
+
+		log.Info("VMOP will be created after the delay", slog.Duration("delay", requeueAfter))
 		return reconcile.Result{RequeueAfter: requeueAfter}, nil
 	}
 
 	backoff := h.calculateBackoff(finishedVMOPs)
 	if backoff > 0 {
+		log.Info("VMOP will be created after the backoff", slog.Duration("backoff", backoff))
 		return reconcile.Result{RequeueAfter: backoff}, nil
 	}
 
 	vmop := newVolumeMigrationVMOP(vm.Name, vm.Namespace)
+	log.Info("Create VMOP", slog.String("vmop.generate-name", vmop.GenerateName), slog.String("vmop.namespace", vmop.Namespace))
 	if err := h.client.Create(ctx, vmop); err != nil {
 		return reconcile.Result{}, err
 	}
+	log.Debug("VMOP created", slog.String("vmop.name", vmop.Name), slog.String("vmop.namespace", vmop.Namespace))
 
 	delete(h.delay, vm.UID)