fix(vmop): fix the validation of VirtualDisk names during VirtualMachine cloning (#1496)

Fix the validation of VirtualDisk names during the cloning process of a VirtualMachine.

Signed-off-by: Dmitry Lopatin <[email protected]>

Author: LopatinDmitr

images/virtualization-artifact/pkg/controller/service/restorer/common/common.go

@@ -20,13 +20,13 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/deckhouse/virtualization-controller/pkg/common/validate"
 	virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2"
 )
 
 const (
-	// MaxKubernetesResourceNameLength defines the maximum allowed length for Kubernetes resource names
-	// according to DNS label standard (RFC 1123) - 63 characters for labels
-	MaxKubernetesResourceNameLength = 63
+	// MaxKubernetesResourceNameLength specifies the maximum allowable length for Kubernetes resource names.
+	MaxKubernetesResourceNameLength = 253
 )
 
 var (
@@ -72,12 +72,22 @@ func OverrideName(kind, name string, rules []virtv2.NameReplacement) string {
 	return name
 }
 
-// ValidateResourceNameLength validates that the resource name does not exceed
-// the maximum allowed length for Kubernetes resources
-func ValidateResourceNameLength(resourceName string) error {
-	if len(resourceName) > MaxKubernetesResourceNameLength {
+// ValidateResourceNameLength checks if the given resource name exceeds
+// the maximum allowed length for the specified Kubernetes resource kind.
+// By default, the maximum length is set to MaxKubernetesResourceNameLength,
+// but for VirtualMachine and VirtualDisk resources, it uses
+// MaxVirtualMachineNameLen and MaxDiskNameLen respectively.
+func ValidateResourceNameLength(resourceName, kind string) error {
+	maxLength := MaxKubernetesResourceNameLength
+	switch kind {
+	case virtv2.VirtualMachineKind:
+		maxLength = validate.MaxVirtualMachineNameLen
+	case virtv2.VirtualDiskKind:
+		maxLength = validate.MaxDiskNameLen
+	}
+	if len(resourceName) > maxLength {
 		return fmt.Errorf("name %q too long (%d > %d): %w",
-			resourceName, len(resourceName), MaxKubernetesResourceNameLength, ErrResourceNameTooLong)
+			resourceName, len(resourceName), maxLength, ErrResourceNameTooLong)
 	}
 	return nil
 }

images/virtualization-artifact/pkg/controller/service/restorer/restorers/provisioner_restorer.go

@@ -97,7 +97,7 @@ func (v *ProvisionerHandler) ValidateRestore(ctx context.Context) error {
 }
 
 func (v *ProvisionerHandler) ValidateClone(ctx context.Context) error {
-	if err := common.ValidateResourceNameLength(v.secret.Name); err != nil {
+	if err := common.ValidateResourceNameLength(v.secret.Name, v.secret.Kind); err != nil {
 		return err
 	}
 

images/virtualization-artifact/pkg/controller/service/restorer/restorers/vd_restorer.go

@@ -97,7 +97,7 @@ func (v *VirtualDiskHandler) ValidateRestore(ctx context.Context) error {
 }
 
 func (v *VirtualDiskHandler) ValidateClone(ctx context.Context) error {
-	if err := common.ValidateResourceNameLength(v.vd.Name); err != nil {
+	if err := common.ValidateResourceNameLength(v.vd.Name, v.vd.Kind); err != nil {
 		return err
 	}
 

images/virtualization-artifact/pkg/controller/service/restorer/restorers/vm_restorer.go

@@ -138,7 +138,7 @@ func (v *VirtualMachineHandler) ValidateRestore(ctx context.Context) error {
 }
 
 func (v *VirtualMachineHandler) ValidateClone(ctx context.Context) error {
-	if err := common.ValidateResourceNameLength(v.vm.Name); err != nil {
+	if err := common.ValidateResourceNameLength(v.vm.Name, v.vm.Kind); err != nil {
 		return err
 	}
 

images/virtualization-artifact/pkg/controller/service/restorer/restorers/vmbda_restorer.go

@@ -112,7 +112,7 @@ func (v *VMBlockDeviceAttachmentHandler) ValidateRestore(ctx context.Context) er
 }
 
 func (v *VMBlockDeviceAttachmentHandler) ValidateClone(ctx context.Context) error {
-	if err := common.ValidateResourceNameLength(v.vmbda.Name); err != nil {
+	if err := common.ValidateResourceNameLength(v.vmbda.Name, v.vmbda.Kind); err != nil {
 		return err
 	}