Skip to content

Commit d25d321

Browse files
authored
Merge pull request #158 from deeptools/develop
Bug with boolean fix
2 parents 9cb9b6d + 015d1ba commit d25d321

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

pygenometracks/tracksClass.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,8 @@ def parse_tracks(self, tracks_file):
419419
" parameter {} but there is no more parameter"
420420
" with space in name. Will be substituted by {}."
421421
"".format(section_name, old_name, name))
422+
else:
423+
old_name = name
422424
# end
423425
SYNONYMOUS_PROPERTIES = track_class.SYNONYMOUS_PROPERTIES
424426
# If the name is part of the synonymous we substitute by
@@ -430,14 +432,20 @@ def parse_tracks(self, tracks_file):
430432
track_options[name] = value
431433
elif name in track_class.BOOLEAN_PROPERTIES:
432434
try:
435+
# I need to use old_name here else I get a KeyError:
433436
track_options[name] = parser.getboolean(section_name,
434-
name)
437+
old_name)
438+
# In the next 1.0 should be:
439+
# track_options[name] = parser.getboolean(section_name,
440+
# name)
435441
except ValueError:
436442
raise InputError("In section {}, {} was set to {}"
437443
" whereas we should have a boolean "
438444
"value. Please, use true or false."
439-
"".format(section_name, name,
445+
"".format(section_name, old_name,
440446
value))
447+
# In the next 1.0 should be:
448+
# "".format(section_name, name,
441449
if value.lower() not in ['true', 'false']:
442450
log.warning("Deprecation Warning: "
443451
"In section {}, {} was set to {}"

0 commit comments

Comments
 (0)