Skip to content

Commit ce1d935

Browse files
committed
Fix #334: SimpleDMRS no longer requires top/index
1 parent 95d66e8 commit ce1d935

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,17 @@
66

77
* REPP mask (`=`) operator and full masking support ([#331])
88

9+
### Fixed
10+
11+
* SimpleDMRS no longer requires `index` or `top` to be specified when
12+
decoding ([#334])
13+
914
### Changed
1015

1116
* REPP no longer requires iterative group calls to appear after the
1217
group definitions ([#308])
1318

19+
1420
## [v1.5.1]
1521

1622
**Release date: 2021-01-05**
@@ -1508,3 +1514,4 @@ information about changes, except for
15081514
[#323]: https://github.com/delph-in/pydelphin/issues/323
15091515
[#324]: https://github.com/delph-in/pydelphin/issues/324
15101516
[#331]: https://github.com/delph-in/pydelphin/issues/331
1517+
[#334]: https://github.com/delph-in/pydelphin/issues/334

delphin/codecs/simpledmrs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ def _decode_dmrs(lexer):
193193
links.append(_decode_link(nodeid, lexer))
194194
lexer.expect_type(RBRACE)
195195

196-
return DMRS(top=int(top),
197-
index=int(index),
196+
return DMRS(top=int(top) if top is not None else None,
197+
index=int(index) if index is not None else None,
198198
nodes=nodes,
199199
links=links,
200200
lnk=lnk,

tests/codecs/simpledmrs_test.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ def test_encode(it_rains_heavily_dmrs, abrams_barked_dmrs):
7171
' 30:ARG1/NEQ -> 20;'
7272
' }')
7373

74+
7475
def test_decode(it_rains_heavily_dmrs):
7576
d = simpledmrs.decode(
7677
'dmrs {'
@@ -129,3 +130,22 @@ def test_loads(it_rains_heavily_dmrs):
129130
assert ds[1].index == it_rains_heavily_dmrs.index
130131
assert ds[1].nodes == it_rains_heavily_dmrs.nodes
131132
assert ds[1].links == it_rains_heavily_dmrs.links
133+
134+
135+
def test_decode_no_index_issue_334():
136+
# https://github.com/delph-in/pydelphin/issues/334
137+
d = simpledmrs.decode(
138+
'dmrs {'
139+
' [top=10]'
140+
' 10 [_rain_v_1<3:9> e TENSE=past];'
141+
'}'
142+
)
143+
assert d.index is None
144+
145+
d = simpledmrs.decode(
146+
'dmrs {'
147+
' 10 [_rain_v_1<3:9> e TENSE=past];'
148+
'}'
149+
)
150+
assert d.top is None
151+
assert d.index is None

0 commit comments

Comments
 (0)