Skip to content

Commit 1aa7f66

Browse files
committed
impl pr feedback
1 parent 7866bb1 commit 1aa7f66

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kernel/src/transaction/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,15 +204,15 @@ impl Transaction {
204204

205205
// Step 3: Generate add actions and get data for domain metadata actions (e.g. row tracking high watermark)
206206
let commit_version = self.read_snapshot.version() + 1;
207-
let (add_actions, row_tracking_high_watermark) =
207+
let (add_actions, row_tracking_domain_metadata) =
208208
self.generate_adds(engine, commit_version)?;
209209

210210
// Step 4: Generate all domain metadata actions (user and system domains)
211211
let domain_metadata_actions = Self::generate_domain_metadata_actions(
212212
engine,
213213
&self.domain_metadatas,
214214
&self.read_snapshot,
215-
row_tracking_high_watermark,
215+
row_tracking_domain_metadata,
216216
)?;
217217

218218
// Step 5: Commit the actions as a JSON file to the Delta log
@@ -272,7 +272,7 @@ impl Transaction {
272272
/// Set domain metadata to be written to the Delta log.
273273
/// Note that each domain can only appear once per transaction. That is, multiple configurations
274274
/// of the same domain are disallowed in a single transaction, as well as setting and removing
275-
/// the same domain in a single transaction. If a duplicate domain is included, the `commit` will
275+
/// the same domain in a single transaction. If a duplicate domain is included, the commit will
276276
/// fail (that is, we don't eagerly check domain validity here).
277277
pub fn with_domain_metadata(mut self, domain: String, configuration: String) -> Self {
278278
self.domain_metadatas

0 commit comments

Comments
 (0)