Skip to content

Commit 305ddbf

Browse files
committed
ai suggested fixes
1 parent a52ec16 commit 305ddbf

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

kernel/tests/write.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,8 +1174,8 @@ async fn test_set_domain_metadata_basic() -> Result<(), Box<dyn std::error::Erro
11741174
let domain2 = "spark.settings";
11751175
let config2 = r#"{"cores": 4}"#;
11761176

1177-
txn.set_domain_metadata(domain1.into(), config1.into())?;
1178-
txn.set_domain_metadata(domain2.into(), config2.into())?;
1177+
txn.set_domain_metadata(domain1.to_string(), config1.to_string())?;
1178+
txn.set_domain_metadata(domain2.to_string(), config2.to_string())?;
11791179
txn.commit(&engine)?;
11801180

11811181
let commit_data = store
@@ -1227,15 +1227,13 @@ async fn test_set_domain_metadata_errors() -> Result<(), Box<dyn std::error::Err
12271227
let mut txn = snapshot.transaction()?;
12281228

12291229
// System domain rejection
1230-
assert!(txn
1231-
.set_domain_metadata("delta.system".into(), "config".into())
1232-
.is_err());
1230+
let err = txn.set_domain_metadata("delta.system".to_string(), "config".to_string()).unwrap_err();
1231+
assert!(err.to_string().contains("system-controlled 'delta.*' domain"));
12331232

12341233
// Duplicate domain rejection
1235-
txn.set_domain_metadata("app.config".into(), "v1".into())?;
1236-
assert!(txn
1237-
.set_domain_metadata("app.config".into(), "v2".into())
1238-
.is_err());
1234+
txn.set_domain_metadata("app.config".to_string(), "v1".to_string())?;
1235+
let err = txn.set_domain_metadata("app.config".to_string(), "v2".to_string()).unwrap_err();
1236+
assert!(err.to_string().contains("already specified in this transaction"));
12391237
}
12401238
Ok(())
12411239
}

0 commit comments

Comments
 (0)