Skip to content

Commit 292407d

Browse files
committed
Require context
1 parent 4283bc5 commit 292407d

File tree

6 files changed

+23
-18
lines changed

6 files changed

+23
-18
lines changed

account.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package detectlanguage
22

3-
// UserStatusResponse is the resource containing account status information
3+
import "context"
4+
5+
// AccountStatusResponse is the resource containing account status information
46
type AccountStatusResponse struct {
57
Date string `json:"date,omitempty"`
68
Requests int `json:"requests"`
@@ -12,8 +14,8 @@ type AccountStatusResponse struct {
1214
Status string `json:"status"`
1315
}
1416

15-
// UserStatus fetches account status
16-
func (c *Client) AccountStatus() (out *AccountStatusResponse, err error) {
17-
err = c.get(nil, "account/status", &out)
17+
// AccountStatus fetches account status
18+
func (c *Client) AccountStatus(ctx context.Context) (out *AccountStatusResponse, err error) {
19+
err = c.get(ctx, "account/status", &out)
1820
return
1921
}

account_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package detectlanguage_test
22

33
import (
4+
"context"
45
"testing"
56

67
"github.com/stretchr/testify/assert"
78
)
89

910
func TestAccountStatus(t *testing.T) {
10-
response, err := client.AccountStatus()
11+
response, err := client.AccountStatus(context.TODO())
1112

1213
if assert.NoError(t, err) {
1314
assert.NotEmpty(t, response.Date)

detect.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ type DetectBatchRequest struct {
1919
}
2020

2121
// Detect executes language detection for a single text
22-
func (c *Client) Detect(in string) (out []*DetectionResult, err error) {
22+
func (c *Client) Detect(ctx context.Context, in string) (out []*DetectionResult, err error) {
2323
var response []*DetectionResult
24-
err = c.post(context.TODO(), "detect", &DetectRequest{Query: in}, &response)
24+
err = c.post(ctx, "detect", &DetectRequest{Query: in}, &response)
2525

2626
if err != nil {
2727
return nil, err
@@ -31,8 +31,8 @@ func (c *Client) Detect(in string) (out []*DetectionResult, err error) {
3131
}
3232

3333
// DetectCode executes language detection for a single text and returns detected language code
34-
func (c *Client) DetectCode(in string) (out string, err error) {
35-
detections, err := c.Detect(in)
34+
func (c *Client) DetectCode(ctx context.Context, in string) (out string, err error) {
35+
detections, err := c.Detect(ctx, in)
3636

3737
if err != nil {
3838
return "", err
@@ -47,9 +47,9 @@ func (c *Client) DetectCode(in string) (out string, err error) {
4747

4848
// DetectBatch executes language detection with multiple texts.
4949
// It is significantly faster than doing a separate request for each text indivdually.
50-
func (c *Client) DetectBatch(in []string) (out [][]*DetectionResult, err error) {
50+
func (c *Client) DetectBatch(ctx context.Context, in []string) (out [][]*DetectionResult, err error) {
5151
var response [][]*DetectionResult
52-
err = c.post(nil, "detect-batch", &DetectBatchRequest{Query: in}, &response)
52+
err = c.post(ctx, "detect-batch", &DetectBatchRequest{Query: in}, &response)
5353

5454
if err != nil {
5555
return nil, err

detect_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package detectlanguage_test
22

33
import (
4+
"context"
45
"testing"
56

67
"github.com/stretchr/testify/assert"
78
)
89

910
func TestDetect(t *testing.T) {
10-
detections, err := client.Detect("labas rytas")
11+
detections, err := client.Detect(context.TODO(), "labas rytas")
1112

1213
if assert.NoError(t, err) {
1314
assert.Equal(t, "lt", detections[0].Language)
@@ -16,23 +17,23 @@ func TestDetect(t *testing.T) {
1617
}
1718

1819
func TestDetectCode(t *testing.T) {
19-
code, err := client.DetectCode("labas rytas")
20+
code, err := client.DetectCode(context.TODO(), "labas rytas")
2021

2122
if assert.NoError(t, err) {
2223
assert.Equal(t, "lt", code)
2324
}
2425
}
2526

2627
func TestDetectCodeFailure(t *testing.T) {
27-
code, err := client.DetectCode(" ")
28+
code, err := client.DetectCode(context.TODO(), " ")
2829

2930
assert.EqualError(t, err, "Language not detected")
3031
assert.Equal(t, code, "")
3132
}
3233

3334
func TestDetectBatch(t *testing.T) {
3435
query := []string{"labas rytas", "good morning"}
35-
detections, err := client.DetectBatch(query)
36+
detections, err := client.DetectBatch(context.TODO(), query)
3637

3738
if assert.NoError(t, err) {
3839
assert.Equal(t, "lt", detections[0][0].Language)

languages.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type Language struct {
99
}
1010

1111
// Languages retrieves the list of supported languages
12-
func (c *Client) Languages() (out []*Language, err error) {
13-
err = c.get(context.TODO(), "languages", &out)
12+
func (c *Client) Languages(ctx context.Context) (out []*Language, err error) {
13+
err = c.get(ctx, "languages", &out)
1414
return
1515
}

languages_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package detectlanguage_test
22

33
import (
4+
"context"
45
"testing"
56

67
"github.com/stretchr/testify/assert"
78
)
89

910
func TestLanguages(t *testing.T) {
10-
languages, err := client.Languages()
11+
languages, err := client.Languages(context.TODO())
1112

1213
if assert.NoError(t, err) {
1314
assert.NotEmpty(t, languages[0].Code)

0 commit comments

Comments
 (0)