go/ir: permit rangefunc yield functions to be synthetic wihle having syntax

dominikh · dominikh · commit 4719a063e8c6 · 2024-05-25T19:51:26.000+02:00
diff --git a/go/ir/sanity.go b/go/ir/sanity.go
@@ -10,6 +10,7 @@ package ir
 import (
 	"bytes"
 	"fmt"
+	"go/ast"
 	"go/types"
 	"io"
 	"os"
@@ -462,7 +463,10 @@ func (s *sanity) checkFunction(fn *Function) bool {
 		}
 	}
 	if syn, src := fn.Synthetic == 0, fn.source != nil; src != syn {
-		s.errorf("got fromSource=%t, hasSyntax=%t; want same values", src, syn)
+		if _, ok := fn.source.(*ast.RangeStmt); !ok || fn.Synthetic != SyntheticRangeOverFuncYield {
+			// Only range-over-func yield functions are synthetic and have syntax
+			s.errorf("got fromSource=%t, hasSyntax=%t; want same values", src, syn)
+		}
 	}
 	for i, l := range fn.Locals {
 		if l.Parent() != fn {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ package ir`
`10`	`10`	`import (`
`11`	`11`	`"bytes"`
`12`	`12`	`"fmt"`
	`13`	`+ "go/ast"`
`13`	`14`	`"go/types"`
`14`	`15`	`"io"`
`15`	`16`	`"os"`
`@@ -462,7 +463,10 @@ func (s sanity) checkFunction(fn Function) bool {`
`462`	`463`	`}`
`463`	`464`	`}`
`464`	`465`	`if syn, src := fn.Synthetic == 0, fn.source != nil; src != syn {`
`465`		`- s.errorf("got fromSource=%t, hasSyntax=%t; want same values", src, syn)`
	`466`	`+ if _, ok := fn.source.(*ast.RangeStmt); !ok \|\| fn.Synthetic != SyntheticRangeOverFuncYield {`
	`467`	`+ // Only range-over-func yield functions are synthetic and have syntax`
	`468`	`+ s.errorf("got fromSource=%t, hasSyntax=%t; want same values", src, syn)`
	`469`	`+ }`
`466`	`470`	`}`
`467`	`471`	`for i, l := range fn.Locals {`
`468`	`472`	`if l.Parent() != fn {`