MS.CA.VB resources cleanup

Author: Youssef1313

src/Compilers/VisualBasic/Portable/Compilation/VisualBasicCompilation.vb

@@ -943,7 +943,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
 
                 For Each tree As SyntaxTree In trees
                     If tree Is Nothing Then
-                        Throw New ArgumentNullException(String.Format(VBResources.Trees0, i))
+                        Throw New ArgumentNullException($"trees({i})")
                     End If
 
                     If Not tree.HasCompilationUnitRoot Then
@@ -955,7 +955,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                     End If
 
                     If declMap.ContainsKey(tree) Then
-                        Throw New ArgumentException(VBResources.SyntaxTreeAlreadyPresent, String.Format(VBResources.Trees0, i))
+                        Throw New ArgumentException(VBResources.SyntaxTreeAlreadyPresent, $"trees({i})")
                     End If
 
                     AddSyntaxTreeToDeclarationMapAndTable(tree, _options, Me.IsSubmission, declMap, declTable, referenceDirectivesChanged) ' declMap and declTable passed ByRef

src/Compilers/VisualBasic/Portable/Errors/ErrorFacts.vb

@@ -450,7 +450,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                      ERRID.ERR_NameNotEvent2,
                      ERRID.ERR_AddOrRemoveHandlerEvent,
                      ERRID.ERR_UnrecognizedEnd,
-                     ERRID.ERR_ArrayInitForNonArray2,
                      ERRID.ERR_EndRegionNoRegion,
                      ERRID.ERR_ExpectedEndRegion,
                      ERRID.ERR_InheritsStmtWrongOrder,
@@ -1425,7 +1424,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                      ERRID.WRN_MissingAsClauseinOperator,
                      ERRID.WRN_ConstraintsFailedForInferredArgs2,
                      ERRID.WRN_ConditionalNotValidOnFunction,
-                     ERRID.WRN_UseSwitchInsteadOfAttribute,
                      ERRID.WRN_TupleLiteralNameMismatch,
                      ERRID.WRN_ReferencedAssemblyDoesNotHaveStrongName,
                      ERRID.WRN_RecursiveAddHandlerCall,

src/Compilers/VisualBasic/Portable/Errors/Errors.vb

@@ -528,7 +528,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
         ERR_AddOrRemoveHandlerEvent = 30677
         ERR_UnrecognizedEnd = 30678
 
-        ERR_ArrayInitForNonArray2 = 30679
+        ' ERR_ArrayInitForNonArray2 = 30679 - unused
 
         ERR_EndRegionNoRegion = 30680
         ERR_ExpectedEndRegion = 30681
@@ -1857,7 +1857,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
 
         WRN_ConstraintsFailedForInferredArgs2 = 41006
         WRN_ConditionalNotValidOnFunction = 41007
-        WRN_UseSwitchInsteadOfAttribute = 41008
+        ' WRN_UseSwitchInsteadOfAttribute = 41008 - unused
         WRN_TupleLiteralNameMismatch = 41009
 
         '// AVAILABLE                             41010 - 41199

src/Compilers/VisualBasic/Portable/Generated/ErrorFacts.Generated.vb

@@ -117,9 +117,6 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
-  <data name="Trees0" xml:space="preserve">
-    <value>trees({0})</value>
-  </data>
   <data name="TreesMustHaveRootNode" xml:space="preserve">
     <value>trees({0}) must have root node with SyntaxKind.CompilationUnit.</value>
   </data>
@@ -210,12 +207,6 @@
   <data name="ERR_NoSources" xml:space="preserve">
     <value>no input sources specified</value>
   </data>
-  <data name="WRN_FileAlreadyIncluded" xml:space="preserve">
-    <value>source file '{0}' specified multiple times</value>
-  </data>
-  <data name="WRN_FileAlreadyIncluded_Title" xml:space="preserve">
-    <value>Source file specified multiple times</value>
-  </data>
   <data name="ERR_CantOpenFileWrite" xml:space="preserve">
     <value>can't open '{0}' for writing: {1}</value>
   </data>
@@ -240,12 +231,6 @@
   <data name="WRN_NoConfigInResponseFile_Title" xml:space="preserve">
     <value>Ignoring /noconfig option because it was specified in a response file</value>
   </data>
-  <data name="WRN_InvalidWarningId" xml:space="preserve">
-    <value>warning number '{0}' for the option '{1}' is either not configurable or not valid</value>
-  </data>
-  <data name="WRN_InvalidWarningId_Title" xml:space="preserve">
-    <value>Warning number is either not configurable or not valid</value>
-  </data>
   <data name="ERR_NoSourcesOut" xml:space="preserve">
     <value>cannot infer an output file name from resource only input files; provide the '/out' option</value>
   </data>
@@ -1527,9 +1512,6 @@
   <data name="ERR_UnrecognizedEnd" xml:space="preserve">
     <value>'End' statement not valid.</value>
   </data>
-  <data name="ERR_ArrayInitForNonArray2" xml:space="preserve">
-    <value>Array initializers are valid only for arrays, but the type of '{0}' is '{1}'.</value>
-  </data>
   <data name="ERR_EndRegionNoRegion" xml:space="preserve">
     <value>'#End Region' must be preceded by a matching '#Region'.</value>
   </data>
@@ -3784,12 +3766,6 @@
   <data name="WRN_ConditionalNotValidOnFunction_Title" xml:space="preserve">
     <value>Attribute 'Conditional' is only valid on 'Sub' declarations</value>
   </data>
-  <data name="WRN_UseSwitchInsteadOfAttribute" xml:space="preserve">
-    <value>Use command-line option '{0}' or appropriate project settings instead of '{1}'.</value>
-  </data>
-  <data name="WRN_UseSwitchInsteadOfAttribute_Title" xml:space="preserve">
-    <value>Use command-line option /keyfile, /keycontainer, or /delaysign instead of AssemblyKeyFileAttribute, AssemblyKeyNameAttribute, or AssemblyDelaySignAttribute</value>
-  </data>
   <data name="WRN_RecursiveAddHandlerCall" xml:space="preserve">
     <value>Statement recursively calls the containing '{0}' for event '{1}'.</value>
   </data>
@@ -4198,12 +4174,6 @@
   <data name="WRN_RelDelegatePassedToRemoveHandler_Title" xml:space="preserve">
     <value>The 'AddressOf' expression has no effect in this context because the method argument to 'AddressOf' requires a relaxed conversion to the delegate type of the event</value>
   </data>
-  <data name="WRN_QueryMissingAsClauseinVarDecl" xml:space="preserve">
-    <value>Range variable is assumed to be of type Object because its type cannot be inferred. Use an 'As' clause to specify a different type.</value>
-  </data>
-  <data name="WRN_QueryMissingAsClauseinVarDecl_Title" xml:space="preserve">
-    <value>Range variable is assumed to be of type Object because its type cannot be inferred</value>
-  </data>
   <data name="ERR_MultilineLambdaMissingFunction" xml:space="preserve">
     <value>Multiline lambda expression is missing 'End Function'.</value>
   </data>
@@ -5740,4 +5710,4 @@
     <value>'MethodImplAttribute.Async' cannot be manually applied to methods.</value>
     <remarks>'MethodImplAttribute.Async' is not localizable.</remarks>
   </data>
-</root>
+</root>