Skip to content

Commit 064bfd7

Browse files
committed
changes by gpt5, most of which I don't understand yet
1 parent 21a68e9 commit 064bfd7

File tree

4 files changed

+142
-20
lines changed

4 files changed

+142
-20
lines changed

src/components/CodeEditor/index.jsx

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { Editor } from "@monaco-editor/react";
2+
import { useEffect, useRef } from "react";
23
import { useDiagram, useSettings } from "../../hooks";
34
import { Button, Toast } from "@douyinfe/semi-ui";
45
import { useTranslation } from "react-i18next";
@@ -9,6 +10,7 @@ import "./styles.css";
910
export default function CodeEditor({
1011
showCopyButton,
1112
extraControls,
13+
markers = [],
1214
...props
1315
}) {
1416
const { settings } = useSettings();
@@ -24,14 +26,49 @@ export default function CodeEditor({
2426
});
2527
};
2628

29+
const editorRef = useRef(null);
30+
const monacoRef = useRef(null);
31+
2732
const handleEditorMount = (editor, monaco) => {
2833
setUpDBML(monaco, database);
2934

3035
setTimeout(() => {
3136
editor.getAction("editor.action.formatDocument").run();
3237
}, 300);
38+
39+
editorRef.current = editor;
40+
monacoRef.current = monaco;
41+
42+
// Apply existing markers after mount
43+
try {
44+
const model = editor.getModel();
45+
if (model) {
46+
const normalized = markers.map((m) => ({
47+
severity: m.severity ?? monaco.MarkerSeverity.Error,
48+
...m,
49+
}));
50+
monaco.editor.setModelMarkers(model, "dbml", normalized);
51+
}
52+
} catch (err) {
53+
console.warn("Failed to set initial markers", err);
54+
}
3355
};
3456

57+
useEffect(() => {
58+
if (!editorRef.current || !monacoRef.current) return;
59+
try {
60+
const model = editorRef.current.getModel();
61+
if (!model) return;
62+
const normalized = markers.map((m) => ({
63+
severity: m.severity ?? monacoRef.current.MarkerSeverity.Error,
64+
...m,
65+
}));
66+
monacoRef.current.editor.setModelMarkers(model, "dbml", normalized);
67+
} catch (err) {
68+
console.warn("Failed to update markers", err);
69+
}
70+
}, [markers]);
71+
3572
return (
3673
<div className="relative h-full">
3774
<Editor

src/components/EditorSidePanel/DBMLEditor.jsx

Lines changed: 89 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,109 @@
11
import { useEffect, useState } from "react";
22
import { useDiagram, useEnums, useLayout } from "../../hooks";
33
import { toDBML } from "../../utils/exportAs/dbml";
4+
import { fromDBML } from "../../utils/importFrom/dbml";
45
import { Button, Tooltip } from "@douyinfe/semi-ui";
56
import { IconTemplate } from "@douyinfe/semi-icons";
67
import { useTranslation } from "react-i18next";
78
import CodeEditor from "../CodeEditor";
89

910
export default function DBMLEditor() {
10-
const { tables: currentTables, relationships } = useDiagram();
1111
const diagram = useDiagram();
12-
const { enums } = useEnums();
12+
const {
13+
tables: currentTables,
14+
relationships,
15+
setTables,
16+
setRelationships,
17+
database,
18+
} = diagram;
19+
const { enums, setEnums } = useEnums();
1320
const [value, setValue] = useState(() => toDBML({ ...diagram, enums }));
1421
const { setLayout } = useLayout();
22+
const { setExternalIssues } = diagram;
1523
const { t } = useTranslation();
1624

1725
const toggleDBMLEditor = () => {
1826
setLayout((prev) => ({ ...prev, dbmlEditor: !prev.dbmlEditor }));
1927
};
2028

2129
useEffect(() => {
22-
setValue(toDBML({ tables: currentTables, enums, relationships }));
23-
}, [currentTables, enums, relationships]);
30+
const normalized = toDBML({
31+
tables: currentTables,
32+
enums,
33+
relationships,
34+
database,
35+
});
36+
setValue(normalized);
37+
}, [currentTables, enums, relationships, database]);
38+
39+
useEffect(() => {
40+
const currentDbml = toDBML({
41+
tables: currentTables,
42+
enums,
43+
relationships,
44+
database,
45+
});
46+
47+
if (value === currentDbml) return;
48+
49+
const handle = setTimeout(() => {
50+
try {
51+
const parsed = fromDBML(value);
52+
// Preserve coordinates when table names match existing ones
53+
const nameToExisting = new Map(
54+
currentTables.map((t) => [t.name, { x: t.x, y: t.y }]),
55+
);
56+
parsed.tables = parsed.tables.map((t) => {
57+
const coords = nameToExisting.get(t.name);
58+
return coords ? { ...t, ...coords } : t;
59+
});
60+
setTables(parsed.tables);
61+
setRelationships(parsed.relationships);
62+
setEnums(parsed.enums);
63+
// Clear any previous external issues on success
64+
setExternalIssues([]);
65+
} catch (err) {
66+
const message = err?.message || String(err);
67+
// Put parse error into Issues panel instead of toast spam
68+
setExternalIssues([message]);
69+
setEditorMarkersFromError(message);
70+
}
71+
}, 700);
72+
73+
return () => clearTimeout(handle);
74+
}, [
75+
value,
76+
currentTables,
77+
enums,
78+
relationships,
79+
database,
80+
setTables,
81+
setRelationships,
82+
setEnums,
83+
setExternalIssues,
84+
]);
85+
86+
// Translate DBML parse error message to Monaco markers
87+
const [markers, setMarkers] = useState([]);
88+
const setEditorMarkersFromError = (message) => {
89+
// Try to extract line/column like: "line X, column Y" or "(X:Y)"
90+
const lineColMatch =
91+
/line\s+(\d+)\s*,\s*column\s*(\d+)/i.exec(message) ||
92+
/\((\d+)\s*[:|,]\s*(\d+)\)/.exec(message);
93+
94+
const lineNumber = lineColMatch ? parseInt(lineColMatch[1], 10) : 1;
95+
const column = lineColMatch ? parseInt(lineColMatch[2], 10) : 1;
96+
97+
setMarkers([
98+
{
99+
startLineNumber: lineNumber,
100+
startColumn: column,
101+
endLineNumber: lineNumber,
102+
endColumn: column + 1,
103+
message,
104+
},
105+
]);
106+
};
24107

25108
return (
26109
<CodeEditor
@@ -29,8 +112,9 @@ export default function DBMLEditor() {
29112
language="dbml"
30113
onChange={setValue}
31114
height="100%"
115+
markers={markers}
32116
options={{
33-
readOnly: true,
117+
readOnly: false,
34118
minimap: { enabled: false },
35119
}}
36120
extraControls={

src/components/EditorSidePanel/Issues.jsx

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,24 @@ export default function Issues() {
1010
const { t } = useTranslation();
1111
const { settings } = useSettings();
1212
const { enums } = useEnums();
13-
const { tables, relationships, database } = useDiagram();
13+
const { tables, relationships, database, externalIssues } = useDiagram();
1414
const [issues, setIssues] = useState([]);
1515

1616
useEffect(() => {
17-
const findIssues = async () => {
18-
const newIssues = getIssues({
19-
tables: tables,
20-
relationships: relationships,
21-
types: types,
22-
database: database,
23-
enums: enums,
24-
});
17+
const newIssues = getIssues({
18+
tables: tables,
19+
relationships: relationships,
20+
types: types,
21+
database: database,
22+
enums: enums,
23+
});
2524

26-
if (!arrayIsEqual(newIssues, issues)) {
27-
setIssues(newIssues);
28-
}
29-
};
25+
const combined = [...externalIssues, ...newIssues];
3026

31-
findIssues();
32-
}, [tables, relationships, issues, types, database, enums]);
27+
if (!arrayIsEqual(combined, issues)) {
28+
setIssues(combined);
29+
}
30+
}, [tables, relationships, issues, types, database, enums, externalIssues]);
3331

3432
return (
3533
<Collapse lazyRender keepDOM={false} style={{ width: "100%" }}>

src/context/DiagramContext.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default function DiagramContextProvider({ children }) {
1212
const [database, setDatabase] = useState(DB.GENERIC);
1313
const [tables, setTables] = useState([]);
1414
const [relationships, setRelationships] = useState([]);
15+
const [externalIssues, setExternalIssues] = useState([]);
1516
const { transform } = useTransform();
1617
const { setUndoStack, setRedoStack } = useUndoRedo();
1718
const { selectedElement, setSelectedElement } = useSelect();
@@ -244,6 +245,8 @@ export default function DiagramContextProvider({ children }) {
244245
setDatabase,
245246
tablesCount: tables.length,
246247
relationshipsCount: relationships.length,
248+
externalIssues,
249+
setExternalIssues,
247250
}}
248251
>
249252
{children}

0 commit comments

Comments
 (0)