Skip to content

Commit d2982ca

Browse files
committed
v1.4.1 - Forge 1.12.2 (4/10) + requires absolute: prefix.
1 parent d7fe519 commit d2982ca

File tree

3 files changed

+42
-16
lines changed

3 files changed

+42
-16
lines changed

app/assets/js/processbuilder.js

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,32 @@ class ProcessBuilder {
174174
}
175175
}
176176

177+
/**
178+
* Test to see if this version of forge requires the absolute: prefix
179+
* on the modListFile repository field.
180+
*/
181+
_requiresAbsolute(){
182+
try {
183+
const ver = this.forgeData.id.split('-')[2]
184+
const pts = ver.split('.')
185+
const min = [14, 23, 3, 2655]
186+
for(let i=0; i<pts.length; i++){
187+
const parsed = Number.parseInt(pts[i])
188+
if(parsed < min[i]){
189+
return false
190+
} else if(parsed > min[i]){
191+
return true
192+
}
193+
}
194+
} catch (err) {
195+
// We know old forge versions follow this format.
196+
// Error must be caused by newer version.
197+
}
198+
199+
// Equal or errored
200+
return true
201+
}
202+
177203
/**
178204
* Construct a mod list json object.
179205
*
@@ -183,7 +209,7 @@ class ProcessBuilder {
183209
*/
184210
constructModList(type, mods, save = false){
185211
const modList = {
186-
repositoryRoot: path.join(this.commonDir, 'modstore')
212+
repositoryRoot: ((type === 'forge' && this._requiresAbsolute()) ? 'absolute:' : '') + path.join(this.commonDir, 'modstore')
187213
}
188214

189215
const ids = []

package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "westeroscraftlauncher",
3-
"version": "1.4.0",
3+
"version": "1.4.1",
44
"productName": "WesterosCraft Launcher",
55
"description": "Modded Minecraft Launcher",
66
"author": "Daniel Scalzi (https://github.com/dscalzi/)",
@@ -43,7 +43,7 @@
4343
"cross-env": "^5.2.0",
4444
"electron": "^4.0.0",
4545
"electron-builder": "^20.38.4",
46-
"eslint": "^5.10.0"
46+
"eslint": "^5.11.1"
4747
},
4848
"repository": {
4949
"type": "git",

0 commit comments

Comments
 (0)