Skip to content

Commit 64f3bfa

Browse files
authored
Merge pull request #72 from carlopi/apply_patches
Apply patch from duckdb/duckdb#18107
2 parents d6a472b + 8cfb0a0 commit 64f3bfa

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

.github/workflows/MainDistributionPipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
1818
with:
1919
extension_name: httpfs
20-
duckdb_version: v1.3.1
20+
duckdb_version: v1.3-ossivalis
2121
ci_tools_version: main
2222
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'
2323

@@ -29,7 +29,7 @@ jobs:
2929
secrets: inherit
3030
with:
3131
extension_name: httpfs
32-
duckdb_version: v1.3.1
32+
duckdb_version: v1.3-ossivalis
3333
ci_tools_version: main
3434
deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
3535
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads'

duckdb

Submodule duckdb updated 63 files

extension/httpfs/httpfs.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,9 @@ namespace duckdb {
2323

2424
shared_ptr<HTTPUtil> HTTPFSUtil::GetHTTPUtil(optional_ptr<FileOpener> opener) {
2525
if (opener) {
26-
auto db = opener->TryGetDatabase();
27-
if (db) {
28-
auto &config = DBConfig::GetConfig(*db);
29-
return config.http_util;
30-
}
26+
return opener->GetHTTPUtil();
3127
}
32-
return make_shared_ptr<HTTPFSUtil>();
28+
throw InternalException("FileOpener not provided, can't get HTTPUtil");
3329
}
3430

3531
unique_ptr<HTTPParams> HTTPFSUtil::InitializeParameters(optional_ptr<FileOpener> opener,

0 commit comments

Comments
 (0)