add reasonable tests

Author: guillesd

duckdb/query_graph/__main__.py

@@ -495,7 +495,6 @@ def translate_json_to_html(input_file: str = None, input_text: str = None, outpu
     else:
         print("please provide either input file or input text")
         exit(1)
-
     html_output = generate_style_html(text, True)
     highlight_metric_grid = generate_metric_grid_html(text)
     timing_table = generate_timing_html(text, query_timings)

tests/fast/test_profiler.py

@@ -1,18 +1,29 @@
 import pytest
+import json
 import duckdb
+from duckdb.query_graph import translate_json_to_html
+
+@pytest.fixture(scope="session")
+def profiling_connection():
+    con = duckdb.connect()
+    con.enable_profiling()
+    con.execute("SELECT 42;").fetchall()
+    yield con
+    con.close()
 
 class TestProfiler:
-    def test_profiler_matches_expected_format(self):
-        con = duckdb.connect()
-        con.enable_profiling()
-        con.execute("from range(100_000);")
-        
-        # Test JSON format
-        profiling_info_json = con.get_profiling_information(format="json")
+    def test_profiler_matches_expected_format(self, profiling_connection, tmp_path_factory):        
+        # Test String returned
+        profiling_info_json = profiling_connection.get_profiling_information(format="json")
         assert isinstance(profiling_info_json, str)
-        print(profiling_info_json)
 
-        # Test Text format
-        profiling_info_text = con.get_profiling_information(format="query_tree_optimizer")
-        assert isinstance(profiling_info_text, str)
-        print(profiling_info_text)  # Print to visually inspect the text format
+        # Test expected metrics are there and profiling is json loadable
+        profiling_dict = json.loads(profiling_info_json)
+        expected_keys = {'query_name', 'total_bytes_written', 'total_bytes_read', 'system_peak_temp_dir_size', 'system_peak_buffer_memory', 'rows_returned', 'result_set_size', 'latency', 'cumulative_rows_scanned', 'cumulative_cardinality', 'cpu_time', 'extra_info', 'blocked_thread_time', 'children'}
+        assert profiling_dict.keys() == expected_keys
+
+    def test_profiler_html_output(self, profiling_connection, tmp_path_factory):
+        tmp_dir = tmp_path_factory.mktemp("profiler", numbered=True)
+        profiling_info_json = profiling_connection.get_profiling_information(format="json")
+        # Test HTML execution works, nothing to assert!
+        translate_json_to_html(input_text = profiling_info_json, output_file = f"{tmp_dir}/profiler_output.html")