Skip to content

Commit e10a482

Browse files
committed
add the remaining types, remove dead code
1 parent c6fbcb5 commit e10a482

File tree

2 files changed

+27
-63
lines changed

2 files changed

+27
-63
lines changed

duckdb/__init__.py

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,33 @@ def __repr__(self):
3232
return f"<DBAPITypeObject {self.name}>"
3333

3434
# Define the standard DBAPI sentinels
35-
STRING = DBAPITypeObject("STRING", {"VARCHAR", "CHAR", "TEXT"})
36-
NUMBER = DBAPITypeObject("NUMBER", {"INTEGER", "BIGINT", "DECIMAL", "DOUBLE"})
37-
DATETIME = DBAPITypeObject("DATETIME", {"DATE", "TIME", "TIMESTAMP"})
35+
STRING = DBAPITypeObject("STRING", {"VARCHAR"})
36+
NUMBER = DBAPITypeObject("NUMBER", {
37+
"TINYINT",
38+
"UTINYINT",
39+
"SMALLINT",
40+
"USMALLINT",
41+
"INTEGER",
42+
"UINTEGER",
43+
"BIGINT",
44+
"UBIGINT",
45+
"HUGEINT",
46+
"UHUGEINT",
47+
"BIGNUM",
48+
"DECIMAL",
49+
"FLOAT",
50+
"DOUBLE"
51+
})
52+
DATETIME = DBAPITypeObject("DATETIME", {
53+
"DATE",
54+
"TIME",
55+
"TIME_TZ",
56+
"TIMESTAMP",
57+
"TIMESTAMP_TZ",
58+
"TIMESTAMP_NS",
59+
"TIMESTAMP_MS",
60+
"TIMESTAMP_SEC"
61+
})
3862
BINARY = DBAPITypeObject("BINARY", {"BLOB"})
3963
ROWID = None
4064

src/duckdb_py/pyresult.cpp

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -514,66 +514,6 @@ py::object DuckDBPyResult::FetchArrowCapsule(idx_t rows_per_batch) {
514514
return py::capsule(stream, "arrow_array_stream", ArrowArrayStreamPyCapsuleDestructor);
515515
}
516516

517-
py::str GetTypeToPython(const LogicalType &type) {
518-
switch (type.id()) {
519-
case LogicalTypeId::BOOLEAN:
520-
return py::str("bool");
521-
case LogicalTypeId::TINYINT:
522-
case LogicalTypeId::SMALLINT:
523-
case LogicalTypeId::INTEGER:
524-
case LogicalTypeId::BIGINT:
525-
case LogicalTypeId::UTINYINT:
526-
case LogicalTypeId::USMALLINT:
527-
case LogicalTypeId::UINTEGER:
528-
case LogicalTypeId::UBIGINT:
529-
case LogicalTypeId::HUGEINT:
530-
case LogicalTypeId::UHUGEINT:
531-
case LogicalTypeId::FLOAT:
532-
case LogicalTypeId::DOUBLE:
533-
case LogicalTypeId::DECIMAL: {
534-
return py::str("NUMBER");
535-
}
536-
case LogicalTypeId::VARCHAR: {
537-
if (type.HasAlias() && type.GetAlias() == "JSON") {
538-
return py::str("JSON");
539-
} else {
540-
return py::str("STRING");
541-
}
542-
}
543-
case LogicalTypeId::BLOB:
544-
case LogicalTypeId::BIT:
545-
return py::str("BINARY");
546-
case LogicalTypeId::TIMESTAMP:
547-
case LogicalTypeId::TIMESTAMP_TZ:
548-
case LogicalTypeId::TIMESTAMP_MS:
549-
case LogicalTypeId::TIMESTAMP_NS:
550-
case LogicalTypeId::TIMESTAMP_SEC: {
551-
return py::str("DATETIME");
552-
}
553-
case LogicalTypeId::TIME:
554-
case LogicalTypeId::TIME_TZ: {
555-
return py::str("Time");
556-
}
557-
case LogicalTypeId::DATE: {
558-
return py::str("Date");
559-
}
560-
case LogicalTypeId::STRUCT:
561-
case LogicalTypeId::MAP:
562-
return py::str("dict");
563-
case LogicalTypeId::LIST: {
564-
return py::str("list");
565-
}
566-
case LogicalTypeId::INTERVAL: {
567-
return py::str("TIMEDELTA");
568-
}
569-
case LogicalTypeId::UUID: {
570-
return py::str("UUID");
571-
}
572-
default:
573-
return py::str(type.ToString());
574-
}
575-
}
576-
577517
py::list DuckDBPyResult::GetDescription(const vector<string> &names, const vector<LogicalType> &types) {
578518
py::list desc;
579519

0 commit comments

Comments
 (0)