Skip to content

Commit 7e264f8

Browse files
committed
Remove showOmnibar from navigationStateChanged to fix easter egg logos
This is a leftover from Josh's loading bar experiment. Ondrej needed to account for that when adding the new Bottom Omnibar here but as Josh has removed the experiment it is no longer needed. I tested and it makes no difference and now acts the same way as the top omnibar
1 parent e7e5028 commit 7e264f8

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,10 +1508,6 @@ class BrowserTabViewModel @Inject constructor(
15081508

15091509
if (!currentBrowserViewState().browserShowing) return
15101510

1511-
if (settingsDataStore.omnibarPosition == BOTTOM) {
1512-
showOmniBar()
1513-
}
1514-
15151511
canAutofillSelectCredentialsDialogCanAutomaticallyShow = true
15161512

15171513
browserViewState.value = currentBrowserViewState().copy(
@@ -4003,12 +3999,6 @@ class BrowserTabViewModel @Inject constructor(
40033999
}
40044000
}
40054001

4006-
private fun showOmniBar() {
4007-
omnibarViewState.value = currentOmnibarViewState().copy(
4008-
navigationChange = true,
4009-
)
4010-
}
4011-
40124002
fun onUserDismissedAutoCompleteInAppMessage() {
40134003
viewModelScope.launch(dispatchers.io()) {
40144004
autoComplete.userDismissedHistoryInAutoCompleteIAM()

0 commit comments

Comments
 (0)