Fix CI issues

Author: CrisBarreiro

app/src/androidTest/java/com/duckduckgo/app/browser/DuckDuckGoWebViewTest.kt

@@ -27,7 +27,7 @@ class DuckDuckGoWebViewTest {
     @UiThreadTest
     fun whenWebViewInitialisedThenSafeBrowsingDisabled() {
         val context = InstrumentationRegistry.getInstrumentation().targetContext
-        val testee = DuckDuckGoWebView(context)
+        val testee = RealDuckDuckGoWebView(context)
         assertFalse(testee.settings.safeBrowsingEnabled)
     }
 }

app/src/test/java/com/duckduckgo/app/browser/RealDuckDuckGoWebViewTest.kt

@@ -25,6 +25,7 @@ class RealDuckDuckGoWebViewTest {
     @Before
     fun setUp() {
         testee.webViewCompatWrapper = mockWebViewCompatWrapper
+        testee.webViewCapabilityChecker = mockWebViewCapabilityChecker
     }
 
     @Test

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/RealWebViewCompatWrapper.kt

@@ -24,7 +24,12 @@ import com.duckduckgo.di.scopes.AppScope
 import com.squareup.anvil.annotations.ContributesBinding
 import javax.inject.Inject
 
-@SuppressLint("RequiresFeature")
+@SuppressLint(
+    "RequiresFeature",
+    "AddWebMessageListenerUsage",
+    "AddDocumentStartJavaScriptUsage",
+    "RemoveWebMessageListenerUsage",
+)
 @ContributesBinding(AppScope::class)
 class RealWebViewCompatWrapper @Inject constructor() : WebViewCompatWrapper {
     override fun addDocumentStartJavaScript(

lint-rules/src/main/java/com/duckduckgo/lint/WebMessageListenerUsageDetector.kt renamed to lint-rules/src/main/java/com/duckduckgo/lint/WebViewCompatApisUsageDetector.kt

@@ -5,7 +5,7 @@ import com.intellij.psi.PsiMethod
 import org.jetbrains.uast.UCallExpression
 
 @Suppress("UnstableApiUsage")
-class WebMessageListenerUsageDetector : Detector(), SourceCodeScanner {
+class WebViewCompatApisUsageDetector : Detector(), SourceCodeScanner {
 
     override fun getApplicableMethodNames(): List<String> {
         return listOf("addWebMessageListener", "removeWebMessageListener")
@@ -33,6 +33,16 @@ class WebMessageListenerUsageDetector : Detector(), SourceCodeScanner {
                     )
                 }
             }
+            "addDocumentStartJavaScript" -> {
+                if (context.evaluator.isMemberInClass(method, "androidx.webkit.WebViewCompat")) {
+                    context.report(
+                        ISSUE_ADD_DOCUMENT_START_JAVASCRIPT_USAGE,
+                        node,
+                        context.getLocation(node),
+                        ISSUE_ADD_DOCUMENT_START_JAVASCRIPT_USAGE.getExplanation(TextFormat.RAW)
+                    )
+                }
+            }
         }
     }
 
@@ -44,7 +54,7 @@ class WebMessageListenerUsageDetector : Detector(), SourceCodeScanner {
             category = Category.CORRECTNESS,
             severity = Severity.ERROR,
             implementation = Implementation(
-                WebMessageListenerUsageDetector::class.java,
+                WebViewCompatApisUsageDetector::class.java,
                 Scope.JAVA_FILE_SCOPE
             )
         )
@@ -56,7 +66,19 @@ class WebMessageListenerUsageDetector : Detector(), SourceCodeScanner {
             category = Category.CORRECTNESS,
             severity = Severity.ERROR,
             implementation = Implementation(
-                WebMessageListenerUsageDetector::class.java,
+                WebViewCompatApisUsageDetector::class.java,
+                Scope.JAVA_FILE_SCOPE
+            )
+        )
+
+        val ISSUE_ADD_DOCUMENT_START_JAVASCRIPT_USAGE: Issue = Issue.create(
+            id = "AddDocumentStartJavaScriptUsage",
+            briefDescription = "Use safe WebViewCompat methods",
+            explanation = "Use `safeAddDocumentStartJavaScript` instead of `WebViewCompat.addDocumentStartJavaScript`",
+            category = Category.CORRECTNESS,
+            severity = Severity.ERROR,
+            implementation = Implementation(
+                WebViewCompatApisUsageDetector::class.java,
                 Scope.JAVA_FILE_SCOPE
             )
         )

lint-rules/src/main/java/com/duckduckgo/lint/registry/DuckDuckGoIssueRegistry.kt

@@ -22,7 +22,6 @@ import com.android.tools.lint.client.api.Vendor
 import com.android.tools.lint.detector.api.CURRENT_API
 import com.android.tools.lint.detector.api.Issue
 import com.duckduckgo.lint.DenyListedApiDetector
-import com.duckduckgo.lint.DenyListedApiDetector.Companion
 import com.duckduckgo.lint.NoDispatcherComputation.Companion.ISSUE_AVOID_COMPUTATION
 import com.duckduckgo.lint.strings.MissingSmartlingRequiredDirectivesDetector.Companion.MISSING_SMARTLING_REQUIRED_DIRECTIVES
 import com.duckduckgo.lint.NoFragmentDetector.Companion.NO_FRAGMENT_ISSUE
@@ -32,8 +31,9 @@ import com.duckduckgo.lint.NoRetrofitCreateMethodCallDetector.Companion.NO_RETRO
 import com.duckduckgo.lint.NoRobolectricTestRunnerDetector.Companion.NO_ROBOLECTRIC_TEST_RUNNER_ISSUE
 import com.duckduckgo.lint.NoSingletonDetector.Companion.NO_SINGLETON_ISSUE
 import com.duckduckgo.lint.NoSystemLoadLibraryDetector.Companion.NO_SYSTEM_LOAD_LIBRARY
-import com.duckduckgo.lint.WebMessageListenerUsageDetector.Companion.ISSUE_ADD_WEB_MESSAGE_LISTENER_USAGE
-import com.duckduckgo.lint.WebMessageListenerUsageDetector.Companion.ISSUE_REMOVE_WEB_MESSAGE_LISTENER_USAGE
+import com.duckduckgo.lint.WebViewCompatApisUsageDetector.Companion.ISSUE_ADD_DOCUMENT_START_JAVASCRIPT_USAGE
+import com.duckduckgo.lint.WebViewCompatApisUsageDetector.Companion.ISSUE_ADD_WEB_MESSAGE_LISTENER_USAGE
+import com.duckduckgo.lint.WebViewCompatApisUsageDetector.Companion.ISSUE_REMOVE_WEB_MESSAGE_LISTENER_USAGE
 import com.duckduckgo.lint.WrongPluginPointCollectorDetector.Companion.WRONG_PLUGIN_POINT_ISSUE
 import com.duckduckgo.lint.strings.MissingInstructionDetector.Companion.MISSING_INSTRUCTION
 import com.duckduckgo.lint.strings.PlaceholderDetector.Companion.PLACEHOLDER_MISSING_POSITION
@@ -67,6 +67,7 @@ class DuckDuckGoIssueRegistry : IssueRegistry() {
             NO_ROBOLECTRIC_TEST_RUNNER_ISSUE,
             ISSUE_NON_CANCELLABLE,
             ISSUE_AVOID_COMPUTATION,
+            ISSUE_ADD_DOCUMENT_START_JAVASCRIPT_USAGE,
             ISSUE_ADD_WEB_MESSAGE_LISTENER_USAGE,
             ISSUE_REMOVE_WEB_MESSAGE_LISTENER_USAGE,
             DenyListedApiDetector.ISSUE,