Support svg-images in more Editors

- Support SVG icons as custom Extension-Element icons
- Support SVG images as About-dialog image of products
- Support SVG images as Windows image of products

and use the SVG-format in extension-point schema examples.

Author: HannesWell

ui/org.eclipse.pde.spy.core/schema/spyPart.exsd

@@ -144,7 +144,7 @@ It is also strongly recommended that you keep the key sequences short.  One or t
    <extension point="org.eclipse.tools.spy.core.spyPart">
       <spyPart
             description="Context Spy to understand what is behind the scene of injection"
-            icon="icons/annotation_obj.png"
+            icon="icons/annotation_obj.svg"
             name="Context spy"
             part="org.eclipse.tools.spy.context.ContextSpyPart"
             shortcut="M2+M3+F10">

ui/org.eclipse.pde.ui/schema/newExtension.exsd

@@ -316,7 +316,7 @@ interface.
    <wizard
          availableAsShortcut="true"
          name="Simple Java Editor Extension"
-         icon="icons/java_edit.png"
+         icon="icons/java_edit.svg"
          category="generic"
          class="com.example.xyz.SimpleJavaEditorExtension"
          id="com.example.xyz.simple">

ui/org.eclipse.pde.ui/schema/pluginContent.exsd

@@ -212,7 +212,7 @@ interface and is expected to extend <code>org.eclipse.jface.wizard.Wizard&
    <extension point="org.eclipse.pde.ui.pluginContent">
       <wizard
          name="Example Plug-in Content Generator"
-         icon="icons/content_wizard.png"
+         icon="icons/content_wizard.svg"
          class="com.example.xyz.ContentGeneratorWizard"
          id="com.example.xyz.ExampleContentGenerator">
          <description>

ui/org.eclipse.pde.ui/schema/targetLocationProvisioners.exsd

@@ -143,7 +143,7 @@ The following is an example of the extension point:
          point="org.eclipse.pde.ui.targetLocationProvisioners">
       <locationProvider
             class="org.eclipse.example.exampleTargetWizard"
-            icon="icons/obj16/exampleTargetLocation.png"
+            icon="icons/obj16/exampleTargetLocation.svg"
             id="org.eclipse.example.exampleTargetProvisioner"
             name="%targetLocationProvider.example.name"
          <description>

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java

@@ -25,6 +25,7 @@
 import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.TreeSet;
 
@@ -151,7 +152,7 @@ public class ExtensionsSection extends TreeSection implements IPropertyChangeLis
 			"commandId", "property", "activityId", //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
 			"attribute", "value"}; //$NON-NLS-1$ //$NON-NLS-2$
 
-	private static final String[] VALID_IMAGE_TYPES = {"png", "bmp", "ico", "gif", "jpg", "tiff"}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$
+	private static final Set<String> VALID_IMAGE_TYPES = Set.of("svg", "png", "bmp", "ico", "gif", "jpg", "tiff"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$
 	private static final String MENU_NEW_ID = "NewMenu"; //$NON-NLS-1$
 
 	class ExtensionContentProvider implements ITreeContentProvider {
@@ -975,15 +976,8 @@ static Image getCustomImage(IPluginElement element) {
 				if (ext == null) {
 					return null;
 				}
-				boolean valid = false;
-				// ensure the resource is an image
-				for (String imageType : VALID_IMAGE_TYPES) {
-					if (ext.equalsIgnoreCase(imageType)) {
-						valid = true;
-						break;
-					}
-				}
 				// if the resource is an image, get the image, otherwise return null
+				boolean valid = VALID_IMAGE_TYPES.contains(ext.toLowerCase(Locale.ROOT));
 				return valid ? getImageFromPlugin(element, iconPath) : null;
 			}
 		}

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/AboutSection.java

@@ -147,6 +147,7 @@ private void handleBrowse() {
 		FileExtensionsFilter filter = new FileExtensionsFilter();
 		filter.addFileExtension("gif"); //$NON-NLS-1$
 		filter.addFileExtension("png"); //$NON-NLS-1$
+		filter.addFileExtension("svg"); //$NON-NLS-1$
 		dialog.addFilter(filter);
 		dialog.setInput(PDEPlugin.getWorkspace().getRoot());
 

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/WindowImagesSection.java

@@ -173,6 +173,7 @@ private void handleBrowse(FormEntry entry) {
 		FileExtensionsFilter filter = new FileExtensionsFilter();
 		filter.addFileExtension("gif"); //$NON-NLS-1$
 		filter.addFileExtension("png"); //$NON-NLS-1$
+		filter.addFileExtension("svg"); //$NON-NLS-1$
 		dialog.addFilter(filter);
 		dialog.setInput(PDEPlugin.getWorkspace().getRoot());