How to migrate from deleted TerminalServiceFactory to new API

[jonahgraham]

@laeubi one of the things that #2025 changed was to remove TerminalServiceFactory in favour of UIPlugin.getTerminalService().

The UIPlugin is not API, but TerminalServiceFactory was API. Using this factory was the way the original terminal authors suggested (see this email) and someone migrating their RCP product is running into a problem on what to do in this area (see eclipse-cdt/cdt#1302 (comment)).

Should API consumers now implement this themselves in their own bundle? something like:

	public void start(BundleContext context) throws Exception {
		super.start(context);
		terminalServiceTracker = new ServiceTracker<>(context, ITerminalService.class, null);
		terminalServiceTracker.open();

// ...

      ITerminalService service = terminalServiceTracker.getService();

(above extracted from UIPlugin)

Or are there any other suggestions?

[laeubi]

@jonahgraham first the most important one is where do you need it? e.g. AbstractLauncherDelegate now has a convenience method AbstractLauncherDelegate#getTerminalService() because we found most of the time (if not always) i was requested from launcher delegate implementations (see for example SerialLauncherDelegate in CDT).

Then next, if you are using already any DI technique like OSGi-DS you can simply fetch it as a regular service, in E4 you can use @Inject in any of your views / handlers, or even traditional E3 has PlatformUI.getWorkbench().getService(ITerminalService.class).

If all that don't suffice, then yes a technique similar to your snippet can be used, we then can probably decide if there are other places where we should expose this if it is often needed.

[jonahgraham]

@Bio7 the above questions are really directed at you.

I can see Bio7 was using TerminalServiceFactory here but has commented out/restructured the code in the latest HEAD.

[Bio7]

@jonahgraham Thanks. My use case is, e.g., to start and control a server, interpreter, debugger, serial connection over a shell (and also interrupt, e.g., a running server calculation). I already implemented long ago a pseudo-terminal without a tty which works fine. However to control a shell with a tty (and complete ANSI) would be the icing on the cake.