Return proper exit code on failure

Author: SteveDesmond-ca

libyear

@@ -8,4 +8,5 @@ const vendor_indicator = 'vendor' . DIRECTORY_SEPARATOR . 'ecoapm' . DIRECTORY_S
 $is_vendored = strpos(__DIR__, vendor_indicator) === strlen(__DIR__) - strlen(vendor_indicator);
 require_once __DIR__ . ($is_vendored ? '/../../..' : '') . '/vendor/autoload.php';
 
-Factory::app()->run($argv);
+$result = Factory::app()->run($argv);
+exit($result ? 0 : 1);

src/App.php

@@ -5,7 +5,6 @@
 use cli\Table;
 use Garden\Cli\Cli;
 use Exception;
-use InvalidArgumentException;
 
 class App
 {
@@ -37,17 +36,18 @@ public function __construct(Cli $cli, Calculator $calculator, ComposerFile $comp
 	/**
 	 * @param string[] $args
 	 */
-	public function run(array $args): void
+	public function run(array $args): bool
 	{
 		try {
 			$arguments = $this->cli->parse($args, false);
 		} catch (Exception $e) {
-			$error = $e->getMessage();
-			fwrite($this->output, "{$error}\n");
-			if (!str_starts_with($error, "usage: ")) {
+			$msg = $e->getMessage();
+			fwrite($this->output, "{$msg}\n");
+			if (!str_starts_with($msg, "usage: ")) {
 				$this->showHelp();
+				return false;
 			}
-			return;
+			return true;
 		}
 
 		$quiet_mode = $arguments->getOpt('quiet') !== null;
@@ -73,6 +73,8 @@ public function run(array $args): void
 			fwrite($this->output, "composer.json updated\n");
 			fwrite($this->output, "A manual run of \"composer update\" is required to actually update dependencies\n");
 		}
+
+		return true;
 	}
 
 	/**

tests/AppTest.php

@@ -42,13 +42,32 @@ public function testCanDisplayHelpText()
 		$app = new App(new Cli(), self::calculator(), $composer, $output);
 
 		//act
-		$app->run(['libyear', '--help']);
+		$result = $app->run(['libyear', '--help']);
 
 		//assert
 		fseek($output, 0);
 		$console = stream_get_contents($output);
 		$this->assertStringContainsString('OPTIONS', $console);
 		$this->assertStringContainsString('ARGUMENTS', $console);
+		$this->assertTrue($result);
+	}
+
+	public function testInvalidOptionDisplaysHelpText()
+	{
+		//arrange
+		$composer = Mockery::mock(ComposerFile::class);
+		$output = fopen('php://memory', 'a+');
+		$app = new App(new Cli(), self::calculator(), $composer, $output);
+
+		//act
+		$result = $app->run(['libyear', '-x']);
+
+		//assert
+		fseek($output, 0);
+		$console = stream_get_contents($output);
+		$this->assertStringContainsString('OPTIONS', $console);
+		$this->assertStringContainsString('ARGUMENTS', $console);
+		$this->assertFalse($result);
 	}
 
 	public function testShowsAllDependenciesByDefault()
@@ -59,13 +78,14 @@ public function testShowsAllDependenciesByDefault()
 		$app = new App(new Cli(), self::calculator(), $composer, $output);
 
 		//act
-		$app->run(['libyear', '.']);
+		$result = $app->run(['libyear', '.']);
 
 		//assert
 		fseek($output, 0);
 		$console = stream_get_contents($output);
 		$this->assertStringContainsString('Test 1', $console);
 		$this->assertStringContainsString('Test 2', $console);
+		$this->assertTrue($result);
 	}
 
 	public function testQuietModeOnlyShowsOutdated()