Add 'InstantiatorService' to allow customization of object construction #3187
+742
−602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdennis
commented
Jul 21, 2023
|
|
||
| import org.ehcache.spi.service.Service; | ||
|
|
||
| public interface InstantiatorService extends Service { |
There was a problem hiding this comment.
This is the interface of interest.
chrisdennis
force-pushed
the
instantiator-service
branch
from
8bc033c to
9d9fc1a
Compare
mathieucarbou
approved these changes
Jul 31, 2023
|
Tested with the JCache changes in #3190 in the sample at ibm-wm-transition/terracotta-samples#32. Happy with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for an
InstantiatorServicewhich would allow users to customize how Ehcache creates instances of user types that support the cache. That means things like event listeners, cache loader/writers, resilience strategies etc. At this point I'm mainly interested in knowing if the interface presented here is suitable for wiring in to the Spring dependency injection system.