Add DenseDoubleValues and DenseLongValues #137817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are extensions of DoubleValues and LongValues that are guaranteed to have values for every document, which means they can also be used for iteration. This allows us to re-enable pruning on sorts that use them as sources for comparators.
romseygeek
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
Author
|
This is a pre-requisite for always using custom comparators. Once this is merged then we can stop using SortedNumericSortField anywhere, and ensure that pruning is a) always enabled when possible and b) uses our custom DISI builders for timestamp sorts. |
Contributor
Author
|
This also removes the need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are extensions of DoubleValues and LongValues that are guaranteed
to have values for every document, which means they can also be used for
iteration. This allows us to re-enable pruning on sorts that use them as sources
for comparators.