Remove test of implementation details

Author: tsullivan

packages/eui/src/components/flyout/manager/activity_stage.ts

@@ -75,8 +75,7 @@ export const useFlyoutActivityStage = ({
     if (s === STAGE_ACTIVE && !isActive) next = STAGE_CLOSING;
     else if (s === STAGE_INACTIVE && isActive) {
       next = STAGE_RETURNING;
-    }
-    else if (
+    } else if (
       level === LEVEL_MAIN &&
       isActive &&
       s === STAGE_ACTIVE &&

packages/eui/src/components/flyout/manager/flyout_managed.test.tsx

@@ -22,8 +22,6 @@ import {
   PROPERTY_FLYOUT,
   PROPERTY_LEVEL,
 } from './const';
-import * as hooks from './hooks';
-import * as selectors from './selectors';
 
 // Mock base flyout to a simple div to avoid complex internals
 jest.mock('../flyout.component', () => {
@@ -118,18 +116,7 @@ jest.mock('../../observer/resize_observer', () => ({
   useResizeObserver: () => ({ width: 480 }),
 }));
 
-// Import test utilities after mocks
-import {
-  createTestState,
-  createTestSession,
-  createTestFlyout,
-} from './__mocks__';
-
 // Helper functions for tests - these can reference the mock functions defined above
-const createFlyoutManagerMock = () => ({
-  state: createMockState(),
-  ...createMockFunctions(),
-});
 
 describe('EuiManagedFlyout', () => {
   const renderInProvider = (ui: React.ReactElement) =>
@@ -350,192 +337,4 @@ describe('EuiManagedFlyout', () => {
       expect(onClose).toHaveBeenCalledTimes(1);
     });
   });
-
-  describe('force unmount mechanism', () => {
-    it('triggers onClose when flyout is removed from state but component still exists', () => {
-      const onClose = jest.fn();
-
-      // Mock that starts with flyout in state, then removes it
-      let flyoutInState = true;
-      let isActive = true;
-
-      const useFlyoutManagerSpy = jest.spyOn(hooks, 'useFlyoutManager');
-      const useIsFlyoutActiveSpy = jest.spyOn(selectors, 'useIsFlyoutActive');
-
-      useFlyoutManagerSpy.mockImplementation(() => ({
-        state: {
-          sessions: [],
-          flyouts: flyoutInState
-            ? [{ flyoutId: 'force-unmount-test', level: LEVEL_MAIN as any }]
-            : [],
-          layoutMode: 'side-by-side',
-        },
-        dispatch: jest.fn(),
-        addFlyout: jest.fn(),
-        closeFlyout: mockCloseFlyout,
-        setActiveFlyout: jest.fn(),
-        setFlyoutWidth: jest.fn(),
-        goBack: jest.fn(),
-        goToFlyout: jest.fn(),
-        getHistoryItems: jest.fn(() => []),
-      }));
-
-      useIsFlyoutActiveSpy.mockImplementation(() => isActive);
-
-      const { rerender } = renderInProvider(
-        <EuiManagedFlyout
-          id="force-unmount-test"
-          level={LEVEL_MAIN}
-          onClose={onClose}
-          flyoutMenuProps={{ title: 'Test Flyout' }}
-        />
-      );
-
-      // Initially onClose should not be called
-      expect(onClose).not.toHaveBeenCalled();
-
-      // Simulate flyout being removed from state (e.g., back button clicked)
-      act(() => {
-        flyoutInState = false;
-        isActive = false;
-        rerender(
-          <EuiManagedFlyout
-            id="force-unmount-test"
-            level={LEVEL_MAIN}
-            onClose={onClose}
-            flyoutMenuProps={{ title: 'Test Flyout' }}
-          />
-        );
-      });
-
-      // Force unmount should trigger onClose
-      expect(onClose).toHaveBeenCalledTimes(1);
-      expect(onClose).toHaveBeenCalledWith(expect.any(MouseEvent));
-
-      // Restore mocks
-      useFlyoutManagerSpy.mockRestore();
-      useIsFlyoutActiveSpy.mockRestore();
-    });
-
-    it('does not trigger force unmount for new flyouts not yet in state', () => {
-      const onClose = jest.fn();
-
-      const useFlyoutManagerSpy = jest.spyOn(hooks, 'useFlyoutManager');
-      const useIsFlyoutActiveSpy = jest.spyOn(selectors, 'useIsFlyoutActive');
-
-      useFlyoutManagerSpy.mockReturnValue({
-        state: {
-          sessions: [],
-          flyouts: [], // Empty - flyout never added to state
-          layoutMode: 'side-by-side',
-        },
-        dispatch: jest.fn(),
-        addFlyout: jest.fn(),
-        closeFlyout: mockCloseFlyout,
-        setActiveFlyout: jest.fn(),
-        setFlyoutWidth: jest.fn(),
-        goBack: jest.fn(),
-        goToFlyout: jest.fn(),
-        getHistoryItems: jest.fn(() => []),
-      });
-
-      useIsFlyoutActiveSpy.mockReturnValue(false);
-
-      renderInProvider(
-        <EuiManagedFlyout
-          id="new-flyout-test"
-          level={LEVEL_MAIN}
-          onClose={onClose}
-          flyoutMenuProps={{ title: 'New Flyout' }}
-        />
-      );
-
-      // onClose should NOT be called for new flyouts that were never in state
-      expect(onClose).not.toHaveBeenCalled();
-
-      // Restore mocks
-      useFlyoutManagerSpy.mockRestore();
-      useIsFlyoutActiveSpy.mockRestore();
-    });
-  });
-
-  describe('back button scenario simulation', () => {
-    it('handles the back button workflow correctly', () => {
-      const onCloseB = jest.fn();
-
-      // Collection of test fixtures for state verification: A first, then A + B, then just A
-      const sessionStates = [
-        // Initial: Session A only
-        {
-          sessions: [{ main: 'session-a', child: null, title: 'Session A' }],
-          flyouts: [{ flyoutId: 'session-a', level: LEVEL_MAIN as any }],
-        },
-        // Session B added
-        {
-          sessions: [
-            { main: 'session-a', child: null, title: 'Session A' },
-            { main: 'session-b', child: null, title: 'Session B' },
-          ],
-          flyouts: [
-            { flyoutId: 'session-a', level: LEVEL_MAIN as any },
-            { flyoutId: 'session-b', level: LEVEL_MAIN as any },
-          ],
-        },
-        // Back button: Session B removed
-        {
-          sessions: [{ main: 'session-a', child: null, title: 'Session A' }],
-          flyouts: [{ flyoutId: 'session-a', level: LEVEL_MAIN as any }],
-        },
-      ];
-
-      let stateIndex = 1; // Start with both sessions
-      const useFlyoutManagerSpy = jest.spyOn(hooks, 'useFlyoutManager');
-
-      useFlyoutManagerSpy.mockImplementation(() => ({
-        state: {
-          ...sessionStates[stateIndex],
-          layoutMode: 'side-by-side',
-        },
-        dispatch: jest.fn(),
-        addFlyout: jest.fn(),
-        closeFlyout: mockCloseFlyout,
-        setActiveFlyout: jest.fn(),
-        setFlyoutWidth: jest.fn(),
-        goBack: jest.fn(),
-        goToFlyout: jest.fn(),
-        getHistoryItems: jest.fn(() => []),
-      }));
-
-      // Render Session B
-      const { rerender } = renderInProvider(
-        <EuiManagedFlyout
-          id="session-b"
-          level={LEVEL_MAIN}
-          onClose={onCloseB}
-          flyoutMenuProps={{ title: 'Session B' }}
-        />
-      );
-
-      expect(onCloseB).not.toHaveBeenCalled();
-
-      // Simulate back button: remove Session B from state
-      act(() => {
-        stateIndex = 2; // State with only Session A
-        rerender(
-          <EuiManagedFlyout
-            id="session-b"
-            level={LEVEL_MAIN}
-            onClose={onCloseB}
-            flyoutMenuProps={{ title: 'Session B' }}
-          />
-        );
-      });
-
-      // Session B's onClose should be called via force unmount
-      expect(onCloseB).toHaveBeenCalledTimes(1);
-
-      // Restore mock
-      useFlyoutManagerSpy.mockRestore();
-    });
-  });
 });