MSC4140: Remove auth from delayed event management endpoints #19152
+198
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ratelimit based on IP address, as we do for some other unauthed endpoints (like login) - Remove docstrings for methods whose parameters are self-documenting - Remove named-argument splitter (*) from methods where remaining parameters are unambiguous - Add required SQLite-specific schema migration - Apply the schema migration & update latest schema version - Apply automatic formatting & linting fixes
As long as it is still supported for backwards compatibility, want to keep testing it to guard against regressions
AndrewFerr
changed the title
Do this to prevent a false-positive failure of the check_schema_delta script that thinks indexes are being created on an existing table, when they are really being created on a new replacement table.
Member
Author
|
This will conflict with #19038, and IMO should go in first because:
|
This prevents having to break DB compatibility / having to bump SCHEMA_COMPAT_VERSION. Use UNIQUE INDEX instead of ALTER TABLE for compatibility with SQLite.
1 task
This satisfies the check-schema-delta script.
This should also fix the portdb script
Better to have this comment together with the explanation on why the upgrade should be safe
Member
Author
|
With matrix-org/complement#817 merged, this PR is now covered by Complement tests. |
This reverts commit 76872b1, which is no longer needed now that the lower-bound version of parameterized has been increased.
devonh
approved these changes
Nov 13, 2025
Member
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
Changes seem sensible to me. It's mostly just changing the API shape to align with recent developments on the MSC.
The DB index addition stuff should be okay.
AndrewFerr
added a commit
to AndrewFerr/synapse
that referenced
this pull request
Nov 14, 2025
AndrewFerr
added a commit
to AndrewFerr/synapse
that referenced
this pull request
Nov 14, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per recent proposals in MSC4140, remove authentication for restarting/cancelling/sending a delayed event, and give each of those actions its own endpoint. (The original consolidated endpoint is still supported for backwards compatibility.)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.