Skip to content

Commit 4c75730

Browse files
authored
Apply suggestions from code review
1 parent bdfa049 commit 4c75730

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/ecto/adapters/myxql/connection.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ if Code.ensure_loaded?(MyXQL) do
347347
defp distinct(%ByExpr{expr: false}, _sources, _query), do: []
348348

349349
defp distinct(%ByExpr{expr: exprs}, _sources, query) when is_list(exprs) do
350-
error!(query, "To apply DISTINCT to multiple columns at once, use distinct: true")
350+
error!(query, "to apply DISTINCT to multiple columns in MySQL, use distinct: true")
351351
end
352352

353353
defp select([], _sources, _query),

test/ecto/adapters/myxql_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ defmodule Ecto.Adapters.MyXQLTest do
385385
assert all(query) == ~s{SELECT s0.`x`, s0.`y` FROM `schema` AS s0}
386386

387387
assert_raise Ecto.QueryError,
388-
~r"To apply DISTINCT to multiple columns at once, use distinct: true",
388+
~r"to apply DISTINCT to multiple columns in MySQL, use distinct: true",
389389
fn ->
390390
query =
391391
Schema |> distinct([r], [r.x, r.y]) |> select([r], {r.x, r.y}) |> plan()
@@ -394,7 +394,7 @@ defmodule Ecto.Adapters.MyXQLTest do
394394
end
395395

396396
assert_raise Ecto.QueryError,
397-
~r"To apply DISTINCT to multiple columns at once, use distinct: true",
397+
~r"to apply DISTINCT to multiple columns in MySQL, use distinct: true",
398398
fn ->
399399
query =
400400
from(row in Schema, as: :r, select: row.x)

0 commit comments

Comments
 (0)