feat: Clean up compat

Author: jcs090218

cmds/create/elpa.js

@@ -52,7 +52,9 @@ exports.handler = async (argv) => {
     console.warn('✗ Error while cloning template project');
     console.warn('');
     console.warn('  [1] Make sure you have git installed and has the right permission');
-    process.stderr.write(`  [2] Failed because of the target directory isn't empty`);
+    console.warn(`  [2] Failed because of the target directory isn't empty`);
+    console.warn('');
+    process.stderr.write(`Visit https://emacs-eask.github.io/ for quickstart guide and full documentation.`);
   });
 }
 

lisp/_prepare.el

@@ -240,6 +240,13 @@ the `eask-start' execution.")
     (delete-region (point-min) (point))
     (eval-buffer)))
 
+;;
+;;; Compat
+
+(defun eask-always (&rest _arguments)
+  "The function `always' is supported after Emacs 28.1."
+  t)
+
 ;;
 ;;; Util
 
@@ -2230,7 +2237,6 @@ variable we use to test validation."
 ;;
 ;;; Externals
 
-(eask-load "extern/compat")
 (eask-load "extern/ansi")
 (eask-load "extern/package")
 (eask-load "extern/package-build")

lisp/create/elpa.el

@@ -19,6 +19,9 @@
                           (locate-dominating-file dir "_prepare.el"))
         nil t))
 
+;;
+;;; Core
+
 (defconst eask-create-elpa--template-name "template-elpa"
   "Holds template project name.")
 
@@ -30,7 +33,7 @@
       (goto-char (point-min))
       (search-forward "(script ")
       (forward-line 1)
-      (dolist (gitkeeps (eask-directory-files-recursively eask-file-root ".gitkeep"))
+      (dolist (gitkeeps (directory-files-recursively eask-file-root ".gitkeep"))
         (ignore-errors (delete-file gitkeeps)))
       ;; --- Start insertion
       (insert "(script \"build\" \"eask exec github-elpa build\")\n")

lisp/extern/compat.el

@@ -17,17 +17,17 @@
 ;;; Test functions
 
 (defconst compat-functions
-  '(ansi-color-filter-apply
-    thing-at-point--read-from-whole-string
-    ls-lisp-format-file-size
-    lsh
-    package--alist
-    package--activate-all
-    package-activate-all
-    package-generate-description-file
-    locate-dominating-file
-    url-file-exists-p
-    prin1-to-string)
+  '( ansi-color-filter-apply
+     thing-at-point--read-from-whole-string
+     ls-lisp-format-file-size
+     lsh
+     package--alist
+     package--activate-all
+     package-activate-all
+     package-generate-description-file
+     locate-dominating-file
+     url-file-exists-p
+     prin1-to-string)
   "List of function to check Emacs compatibility.")
 
 (message "Starting compatibility test for functions...")
@@ -45,10 +45,10 @@
 ;;; Test variables
 
 (defconst compat-variables
-  '(finder-known-keywords
-    package-quickstart-file
-    print-level
-    print-length)
+  '( finder-known-keywords
+     package-quickstart-file
+     print-level
+     print-length)
   "List of variables to check Emacs compatibility.")
 
 (message "Starting compatibility test for variables...")