Merge pull request #4567 from vDorst/i2c-pull-down-fix

stm32/i2c: Pull-down enabled when non-pull was requested.

Author: jamesmunns

embassy-stm32/CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 <!-- next-header -->
 ## Unreleased - ReleaseDate
 
+- fix: stm32/i2c: pull-down was enabled instead of pull-none when no internal pull-up was needed.
 - feat: Improve blocking hash speed
 - fix: Fix vrefbuf building with log feature
 - fix: Fix performing a hash after performing a hmac

embassy-stm32/src/i2c/config.rs

@@ -156,7 +156,7 @@ impl Config {
             self.gpio_speed,
             match self.scl_pullup {
                 true => Pull::Up,
-                false => Pull::Down,
+                false => Pull::None,
             },
         );
     }
@@ -170,7 +170,7 @@ impl Config {
             self.gpio_speed,
             match self.sda_pullup {
                 true => Pull::Up,
-                false => Pull::Down,
+                false => Pull::None,
             },
         );
     }