Make the regex less permissive

Author: wagenet

index.js

@@ -93,8 +93,8 @@ class AssetRewrite extends Filter {
      * ["\'(=] - Match one of "'(= exactly one time
      * \\s* - Any amount of white space
      * ( - Starts the first capture group
-     * [^"\'()=]* - Do not match any of ^"'()= 0 or more times
-     * [^"\n\'()\\>=]* - Do not match any of ^"\n'()\>= 0 or more times - Explicitly add \ here because of handlebars compilation
+     * (\\.?/)? - Optionally match ./ or /
+     * [^"\n\'()\\>=]* - Match any character not in ^"\n'()\>= 0 or more times - Explicitly add \ here because of handlebars compilation
      * ) - End first capture group
      * (\\?[^"\')> ]*)? - Allow for query parameters to be present after the URL of an asset
      * \\s* - Any amount of white space
@@ -104,7 +104,7 @@ class AssetRewrite extends Filter {
      */
 
     var re = new RegExp(
-      '["\'(=]\\s*([^"\'()=]*' +
+      '["\'(=]\\s*((\\.?/)?' +
         escapeRegExp(assetPath) +
         '[^"\n\'()\\>=]*)(\\?[^"\')> ]*)?\\s*\\\\*\\s*["\')>s]',
       'g'

tests/filter-tests.js

@@ -31,7 +31,7 @@ describe('broccoli-asset-rev', function () {
         src: url('fonts/Fiz/Light/Fiz-Light.eot');
         src: url('fonts/Fiz/Light/Fiz-Light.eot?#iefix') format('embedded-opentype'), url('fonts/Fiz/Light/Fiz-Light.woff') format('woff'), url('fonts/Fiz/Light/Fiz-Light.ttf') format('truetype'), url('fonts/Fiz/Light/Fiz-Light.svg#Fiz') format('svg');
       }
-      
+
       @font-face {
         font-family: Fiz;
         font-weight: 200;
@@ -62,7 +62,7 @@ describe('broccoli-asset-rev', function () {
         src: url('fonts/Fiz/Light/fingerprinted-Fiz-Light.eot');
         src: url('fonts/Fiz/Light/fingerprinted-Fiz-Light.eot?#iefix') format('embedded-opentype'), url('fonts/Fiz/Light/fingerprinted-Fiz-Light.woff') format('woff'), url('fonts/Fiz/Light/fingerprinted-Fiz-Light.ttf') format('truetype'), url('fonts/Fiz/Light/fingerprinted-Fiz-Light.svg#Fiz') format('svg');
       }
-      
+
       @font-face {
         font-family: Fiz;
         font-weight: 200;
@@ -521,4 +521,44 @@ describe('broccoli-asset-rev', function () {
 
     expect(run2ProcessedCount).to.equal(0);
   });
+
+  it('ignores remote URLs', async function () {
+    var sourcePath = 'tests/fixtures/remote-url';
+    var node = new AssetRewrite(sourcePath + '/input', {
+      replaceExtensions: ['js'],
+      assetMap: {
+        'the.map': 'the-other-map',
+        'app.js': 'http://cdn.absolute.com/app.js',
+      },
+      prepend: '/',
+    });
+
+    let output = createBuilder(node);
+
+    await output.build();
+
+    expect(output.read()).to.deep.equal({
+      'snippet.js': '<script src="http://example.com/app/app.js"></script>\n',
+    });
+  });
+
+  it('ignores partial matches', async function () {
+    var sourcePath = 'tests/fixtures/partial-match';
+    var node = new AssetRewrite(sourcePath + '/input', {
+      replaceExtensions: ['js'],
+      assetMap: {
+        'the.map': 'the-other-map',
+        'app.js': 'http://cdn.absolute.com/app.js',
+      },
+      prepend: '/',
+    });
+
+    let output = createBuilder(node);
+
+    await output.build();
+
+    expect(output.read()).to.deep.equal({
+      'snippet.js': '<script src="other-app/app.js"></script>\n',
+    });
+  });
 });

tests/fixtures/partial-match/input/snippet.js

@@ -0,0 +1 @@
+<script src="other-app/app.js"></script>

tests/fixtures/remote-url/input/snippet.js

@@ -0,0 +1 @@
+<script src="http://example.com/app/app.js"></script>